Re: [cp-patches] RFC: fix JarEntry cert lookup

2006-11-25 Thread Raif S. Naffah
hello Casey, On Tuesday 21 November 2006 08:35, Casey Marshall wrote: > ... > This patch fixes an issue with JarEntry objects that are created > before the entry is verified: we used to bind the certificates to a > JarEntry at creation time, so if the entry has not been verified yet, > the certifi

Re: [cp-patches] RFC: fix JarEntry cert lookup

2006-11-26 Thread Casey Marshall
On Nov 25, 2006, at 3:59 PM, Raif S. Naffah wrote: hello Casey, On Tuesday 21 November 2006 08:35, Casey Marshall wrote: ... This patch fixes an issue with JarEntry objects that are created before the entry is verified: we used to bind the certificates to a JarEntry at creation time, so if the

Re: [cp-patches] RFC: fix JarEntry cert lookup

2006-11-27 Thread Raif S. Naffah
On Sunday 26 November 2006 19:58, Casey Marshall wrote: > On Nov 25, 2006, at 3:59 PM, Raif S. Naffah wrote: > > On Tuesday 21 November 2006 08:35, Casey Marshall wrote: > >> ... > >> This patch fixes an issue with JarEntry objects that are created > >> before the entry is verified... > > > > ...be

Re: [cp-patches] RFC: fix JarEntry cert lookup

2006-11-27 Thread Casey Marshall
On Nov 27, 2006, at 12:08 AM, Raif S. Naffah wrote: On Sunday 26 November 2006 19:58, Casey Marshall wrote: On Nov 25, 2006, at 3:59 PM, Raif S. Naffah wrote: On Tuesday 21 November 2006 08:35, Casey Marshall wrote: ... This patch fixes an issue with JarEntry objects that are created before t

Re: [cp-patches] RFC: fix JarEntry cert lookup

2006-11-27 Thread Casey Marshall
On Nov 27, 2006, at 10:52 AM, Casey Marshall wrote: On Nov 27, 2006, at 12:08 AM, Raif S. Naffah wrote: any reason why you didn't address the synchronization issue in JarEntry#getCertificates()? I wasn't sure if it was needed. It is needed, and JarFile explains that you need to lock on the