Re: [cp-patches] RFC: tweaks to java.util.zip.ZipEntry

2008-02-07 Thread Ian Rogers
Mark Wielaard wrote: On Tue, 2008-02-05 at 06:07 -0700, Tom Tromey wrote: "Ian" == Ian Rogers <[EMAIL PROTECTED]> writes: Ian> the attached patch stops the lazy initialization of a Calendar object Ian> in ZipEntry and instead uses a static final one. I thought this could lead

Re: [cp-patches] RFC: tweaks to java.util.zip.ZipEntry

2008-02-05 Thread Mark Wielaard
On Tue, 2008-02-05 at 06:07 -0700, Tom Tromey wrote: > > "Ian" == Ian Rogers <[EMAIL PROTECTED]> writes: > > Ian> the attached patch stops the lazy initialization of a Calendar object > Ian> in ZipEntry and instead uses a static final one. > > I thought this could lead to odd results sometim

RE: [cp-patches] RFC: tweaks to java.util.zip.ZipEntry

2008-02-05 Thread Jeroen Frijters
Ian Rogers wrote: > the attached patch stops the lazy initialization of a Calendar object > in ZipEntry and instead uses a static final one. It also modifies the > clone method to instead of using Object.clone to use the ZipEntry's own > copy constructor. ZipEntry isn't final, so you must use Obje

Re: [cp-patches] RFC: tweaks to java.util.zip.ZipEntry

2008-02-05 Thread Tom Tromey
> "Ian" == Ian Rogers <[EMAIL PROTECTED]> writes: Ian> the attached patch stops the lazy initialization of a Calendar object Ian> in ZipEntry and instead uses a static final one. I thought this could lead to odd results sometimes, when the calendrical data is in a zip. But it is hard to reme