> JFileChooser - empty file size issue fixed.
> For empty file, now the size 0 bytes.
> Manual Test Case "ZeroFileSizeCheck.java" created.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
alignment, newline and bytes handling fix
-
On Wed, 13 Jul 2022 06:20:06 GMT, Abhishek Kumar wrote:
>> JFileChooser - empty file size issue fixed.
>> For empty file, now the size 0 bytes.
>> Manual Test Case "ZeroFileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since
On Wed, 13 Jul 2022 05:20:39 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> alignment, newline and bytes handling fix
>
> src/java.desktop/share/classes/sun/swing/FilePane.java line 1203
On Fri, 8 Jul 2022 16:01:13 GMT, Andy Goryachev wrote:
>>> Shall we handle "1 byte"?
>>
>> "1 byte" is not handled separately. In that case, should I replace "0 bytes"
>> with "{0} B" ?
>
> Please refer to MessageFormat javadoc:
>
> `For more sophisticated patterns, you can use a ChoiceFormat
On Tue, 12 Jul 2022 09:44:52 GMT, Prasanta Sadhukhan
wrote:
> `recursionCount` counter added in fix of JDK-8224267 is only reset when limit
> is reached, so it will behave incorrectly if JOptionPane.showMessageDialog
> continuously with the same message having newlines, so it needs to be rese
On Tue, 12 Jul 2022 22:20:08 GMT, Phil Race wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> make method inline + clean commented line
>
> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderer.m line
On Tue, 12 Jul 2022 19:49:49 GMT, Harshitha Onkar wrote:
>> Damon Nguyen has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commi
> When a JComboBox is editable, the button segment of the combo box is
> misaligned vertically and has a different height. This change fixes these
> issues and adds a manual test that checks the appearance of an editable and
> non-editable JComboBox.
>
> One of the discussions revolving this is
On Tue, 28 Jun 2022 11:15:41 GMT, Abhishek Kumar wrote:
>> JLabel and AbstractButton's imageUpdate method description updated.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> passed in text added
Will there be an update
On Mon, 11 Jul 2022 11:46:21 GMT, Сергей Цыпанов wrote:
>> We can skip bounds check and null check for Charset in case we use the array
>> entirely and the Charset is either default one or proven to be non-null.
>>
>> Benchmark results:
>>
>> before
>>
>> Benchmark
On Tue, 12 Jul 2022 09:44:52 GMT, Prasanta Sadhukhan
wrote:
> `recursionCount` counter added in fix of JDK-8224267 is only reset when limit
> is reached, so it will behave incorrectly if JOptionPane.showMessageDialog
> continuously with the same message having newlines, so it needs to be rese
On Fri, 24 Jun 2022 05:31:33 GMT, Ajit Ghaisas wrote:
>> J2DBench test option files attached to
>> [JDK-8288948](https://bugs.openjdk.org/browse/JDK-8288948) indicate lower
>> drawing performance on macOS with Metal rendering pipeline as compared to
>> OpenGL rendering pipeline.
>>
>> **Analy
What is a “PC keyboard”? Do you mean a keyboard attached to a machine running
Windows?
> On Jul 12, 2022, at 12:51 PM, Sergey Bylokhov wrote:
>
> So I do not see a reason why the "right option" - "alt gr" key on the PC
> keyboard cannot be mapped to the ALT_GRAPH, same as "left option" - "alt
On Tue, 12 Jul 2022 18:16:06 GMT, Damon Nguyen wrote:
> When a JComboBox is editable, the button segment of the combo box is
> misaligned vertically and has a different height. This change fixes these
> issues and adds a manual test that checks the appearance of an editable and
> non-editable
On Tue, 12 Jul 2022 10:58:02 GMT, Prasanta Sadhukhan
wrote:
>> As per offline discussion with @prrace ALT_GRAPH support done via
>> JDK-8151136 is reverted and tests testing ALT_GRAPH in macos is excluded..
>> @prrace can you please review?
>
> Even if JavaFX, Left and Right Option key is mappe
On Thu, 30 Jun 2022 23:58:44 GMT, lawrence.andrews wrote:
> Fixed the java.lang.NullPointerException & tested .
>
> @shurymury
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9342
When a JComboBox is editable, the button segment of the combo box is misaligned
vertically and has a different height. This change fixes these issues and adds
a manual test that checks the appearance of an editable and non-editable
JComboBox.
One of the discussions revolving this issue is the n
On Fri, 17 Jun 2022 14:28:15 GMT, Manukumar V S wrote:
> javax/swing/JInternalFrame/Test6505027.java seems to be unstable in MacOS
> machines, especially in MacOSX 12 machines and it fails intermittently in CI
> causing some noise.
> It seems to be a testbug as adding some stability improvement
On Wed, 29 Jun 2022 06:53:29 GMT, Manukumar V S wrote:
>> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS
>> machines, especially in MacOSX 12 machines. It seems to be a testbug as
>> adding some stability improvements fix the issue. It intermittently fails in
>> CI cau
On Fri, 8 Jul 2022 08:02:07 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java line 95:
>>
>>> 93: "alt altgraph LEFT", DefaultEditorKit.previousWordAction,
>>> 94: "alt altgraph RIGHT", DefaultEditorKit.nextWordAction,
>>> 95:
`recursionCount` counter added in fix of JDK-8224267 is only reset when limit
is reached, so it will behave incorrectly if JOptionPane.showMessageDialog
continuously with the same message having newlines, so it needs to be reset
also at appropriate location.
Fix to reset the counter before the
21 matches
Mail list logo
