Re: RFR: 8286270: [java.desktop] Replace color search in XColors with a switch statement [v3]

2022-07-15 Thread SWinxy
On Fri, 20 May 2022 00:53:27 GMT, SWinxy wrote: >> The current implementation creates ~750 new objects on load, and uses a >> binary array search with a Comparable implementation. This implementation is >> probably bad. Instead, we can use the enhanced switch feature to possibly >> save time,

RFR: JDK-8289075: Change manual tests to use PassFailJFrame test framework

2022-07-15 Thread Harshitha Onkar
Additional position setting (LEFT_HALF) and a method to obtain bounds of test instruction frame are added to PassFailJFrame to handle positioning of multiple test frames. These changes have been added as part of [JDK-8289075](https://bugs.openjdk.org/browse/JDK-8289075) changes. -

Re: RFR: 8284767: Create an automated test for JDK-4422535 [v4]

2022-07-15 Thread Srinivas Mandalika
On Wed, 22 Jun 2022 11:42:06 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535) >> AccessibleValue implementation only accept Integers >> The AccessibleValue implementations of the following components: >> >> java.a

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v4]

2022-07-15 Thread Srinivas Mandalika
On Wed, 22 Jun 2022 12:52:42 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362) >> >> The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return >> BoundedRangeModel.getMaximum() from getMaximumAcce

Re: RFR: 8286172: Create an automated test for JDK-4516019 [v4]

2022-07-15 Thread Srinivas Mandalika
On Thu, 9 Jun 2022 07:32:29 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4516019](https://bugs.openjdk.java.net/browse/JDK-4516019) >> >> Clicking on the increment/decrement buttons of the spinner does not install >> focus on the spinner or one of its focusable child

Re: RFR: 6391806: JLabel and AbstractButton's imageUpdate method should be better specified [v6]

2022-07-15 Thread Phil Race
On Wed, 13 Jul 2022 07:25:32 GMT, Abhishek Kumar wrote: >> JLabel and AbstractButton's imageUpdate method description updated. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > JLabel and AbstractButton imageUpdate method d

RFR: 8290334: Update FreeType to 2.12.1

2022-07-15 Thread Phil Race
This is a very minor upgrade from ft 2.12.0 to 2.12.1 A good number of the changes (from upstream!) are just white space for whatever reason. - Commit messages: - 8290334 Changes: https://git.openjdk.org/jdk/pull/9524/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9524&ran

Re: RFR: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines [v3]

2022-07-15 Thread Phil Race
On Wed, 29 Jun 2022 06:53:29 GMT, Manukumar V S wrote: >> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS >> machines, especially in MacOSX 12 machines. It seems to be a testbug as >> adding some stability improvements fix the issue. It intermittently fails in >> CI cau

Re: RFR: 8264999: GeneralPath.lineTo() to itself produces jagged lines [v4]

2022-07-15 Thread Phil Race
On Fri, 10 Jun 2022 01:24:48 GMT, Jeremy wrote: >> Previously when you drew a line that moved exactly (+0, +0) with a miter >> stroke the Stroker class acted like a horizontal miter was appropriate. Now >> we abort instead, so no miter is applied. >> >> The new unit test tests the original ste

Re: RFR: 8286172: Create an automated test for JDK-4516019 [v4]

2022-07-15 Thread Phil Race
On Thu, 9 Jun 2022 07:32:29 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4516019](https://bugs.openjdk.java.net/browse/JDK-4516019) >> >> Clicking on the increment/decrement buttons of the spinner does not install >> focus on the spinner or one of its focusable child

Re: RFR: 8284767: Create an automated test for JDK-4422535 [v4]

2022-07-15 Thread Phil Race
On Wed, 22 Jun 2022 11:42:06 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535) >> AccessibleValue implementation only accept Integers >> The AccessibleValue implementations of the following components: >> >> java.a

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v4]

2022-07-15 Thread Phil Race
On Wed, 22 Jun 2022 12:52:42 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362) >> >> The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return >> BoundedRangeModel.getMaximum() from getMaximumAcce

Re: RFR: 8288428: javax/swing/JInternalFrame/Test6505027.java fails frequently in MacOS 12 machines

2022-07-15 Thread Phil Race
On Fri, 17 Jun 2022 14:28:15 GMT, Manukumar V S wrote: > javax/swing/JInternalFrame/Test6505027.java seems to be unstable in MacOS > machines, especially in MacOSX 12 machines and it fails intermittently in CI > causing some noise. > It seems to be a testbug as adding some stability improvement

Re: RFR: 8288948: Few J2DBench tests indicate lower primitive drawing performance with metal rendering pipeline [v2]

2022-07-15 Thread Phil Race
On Fri, 24 Jun 2022 05:31:33 GMT, Ajit Ghaisas wrote: >> J2DBench test option files attached to >> [JDK-8288948](https://bugs.openjdk.org/browse/JDK-8288948) indicate lower >> drawing performance on macOS with Metal rendering pipeline as compared to >> OpenGL rendering pipeline. >> >> **Analy

Re: RFR: 8282526: Default icon is not painted properly [v8]

2022-07-15 Thread Phil Race
On Fri, 15 Jul 2022 19:15:52 GMT, Alexander Zuev wrote: >> Detect the situation where we do need to perform interpolation during >> ImageIcon >> painting and set a hint to the rendering to perform bicubic approximation so >> image details are preserved during transition. > > Alexander Zuev has u

Re: RFR: 8282526: Default icon is not painted properly [v8]

2022-07-15 Thread Alexander Zuev
> Detect the situation where we do need to perform interpolation during > ImageIcon > painting and set a hint to the rendering to perform bicubic approximation so > image details are preserved during transition. Alexander Zuev has updated the pull request incrementally with one additional commit

Re: RFR: 8271846 a11y API lacks setSelectedIndex method [v2]

2022-07-15 Thread Phil Race
On Mon, 11 Jul 2022 13:38:58 GMT, Artem Semenov wrote: > @azuev-java @prrace please review this CSR ticket > [JDK-8286674](https://bugs.openjdk.org/browse/JDK-8286674) Before we get to that 1) You did not acknowledge this is not a backportable fix 2) I'd like you to explain why calling setSelec

Re: RFR: 8269806: Emoji rendering on Linux [v8]

2022-07-15 Thread Nikita Gubarkov
> It was implemented in JetBrains Runtime a year ago and was ported & > refactored for this PR > It includes: > - Bitmap glyph loading via Freetype > - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or > bilinear-mipmap style algorithms depending on the text antialiasing h

Re: RFR: 8269806: Emoji rendering on Linux [v7]

2022-07-15 Thread Nikita Gubarkov
On Fri, 15 Jul 2022 13:25:34 GMT, Nikita Gubarkov wrote: >> It was implemented in JetBrains Runtime a year ago and was ported & >> refactored for this PR >> It includes: >> - Bitmap glyph loading via Freetype >> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or >> bili

Re: RFR: 8269806: Emoji rendering on Linux [v7]

2022-07-15 Thread Nikita Gubarkov
> It was implemented in JetBrains Runtime a year ago and was ported & > refactored for this PR > It includes: > - Bitmap glyph loading via Freetype > - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or > bilinear-mipmap style algorithms depending on the text antialiasing h

Re: RFR: 8269806: Emoji rendering on Linux [v6]

2022-07-15 Thread Nikita Gubarkov
> It was implemented in JetBrains Runtime a year ago and was ported & > refactored for this PR > It includes: > - Bitmap glyph loading via Freetype > - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or > bilinear-mipmap style algorithms depending on the text antialiasing h

Re: RFR: 8269806: Emoji rendering on Linux [v5]

2022-07-15 Thread Nikita Gubarkov
> It was implemented in JetBrains Runtime a year ago and was ported & > refactored for this PR > It includes: > - Bitmap glyph loading via Freetype > - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or > bilinear-mipmap style algorithms depending on the text antialiasing h

RFR: 8290344: Start/stop displaysync affects performance in metal rendering pipeline

2022-07-15 Thread Alexey Ushakov
Reuse displaysync thread for subsequent updates - Commit messages: - 8290344: Start/stop displaysync affects performance in metal rendering pipeline Changes: https://git.openjdk.org/jdk/pull/9512/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9512&range=00 Issue: https:/

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

2022-07-15 Thread Prasanta Sadhukhan
On Thu, 14 Jul 2022 16:25:12 GMT, Damon Nguyen wrote: >. I tried these but none removed the border (even though appearance changes >for a standard JButton in testing): > > * arrowButton.setBorder(javax.swing.BorderFactory.createEmptyBorder()); > * arrowButton.setBorderPainted(false); > * arrowB

Re: RFR: 8290278: JavaDoc of index parameter of method JTabbedPane.insertTab

2022-07-15 Thread Tejesh R
On Thu, 14 Jul 2022 15:58:18 GMT, Tejesh R wrote: > JavaDoc of _JTabbedPane.inseetTab()_ is updated. The index position to insert > a new tab ranges from 0 to _TabCount_(Position after the last tab position), > the same is updated from _> 0_ to _>= 0_ . I'll raise CSR..? - PR

Re: RFR: 8290278: JavaDoc of index parameter of method JTabbedPane.insertTab

2022-07-15 Thread Tejesh R
On Fri, 15 Jul 2022 06:55:54 GMT, Prasanta Sadhukhan wrote: > Did you check that it indeed accept 0 as a valid parameter and no exception > is thrown? Also, you need to raise a csr for this. Yes, I checked with 0 and have gone through the code as well. 0 position indicates index before 1st ex

Re: RFR: 8290278: JavaDoc of index parameter of method JTabbedPane.insertTab

2022-07-15 Thread Prasanta Sadhukhan
On Thu, 14 Jul 2022 15:58:18 GMT, Tejesh R wrote: > JavaDoc of _JTabbedPane.inseetTab()_ is updated. The index position to insert > a new tab ranges from 0 to _TabCount_(Position after the last tab position), > the same is updated from _> 0_ to _>= 0_ . Did you check that it indeed accept 0 as