Integrated: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent

2022-08-08 Thread Sergey Bylokhov
On Fri, 17 Jun 2022 00:09:28 GMT, Sergey Bylokhov wrote: > The specification of the ICC_ColorSpace.fromCIEXYZ method > [says](https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/java/awt/color/ICC_ColorSpace.java#L428): > >> * This method

Re: RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v6]

2022-08-08 Thread Harshitha Onkar
On Fri, 5 Aug 2022 23:55:00 GMT, Harshitha Onkar wrote: >> @aivanov-jdk As suggested, separating the common code into a helper method >> would make the code look cleaner. >> >> Earlier I did think about having the setVisible for both the testWindow and >> instruction frame within the position

Re: RFR: 6521141: DebugGraphics NPE @ setFont(); [v10]

2022-08-08 Thread Tejesh R
> `DebugGraphics` class has a Graphics instance which is been used in slowed > down drawing. The `graphics` object is not initialized anywhere inside the > class, where it is expected to set explicitly by the user. When the user > doesn't set it and try to use the any mehtods like `drawing/setFo

Re: RFR: 6521141: DebugGraphics NPE @ setFont(); [v9]

2022-08-08 Thread Tejesh R
On Mon, 8 Aug 2022 12:05:51 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > src/java.desktop/share/classes/javax/swing/DebugGraphics.java line 89: > >> 87:

Re: RFR: 6521141: DebugGraphics NPE @ setFont(); [v9]

2022-08-08 Thread Prasanta Sadhukhan
On Fri, 5 Aug 2022 11:35:54 GMT, Tejesh R wrote: >> `DebugGraphics` class has a Graphics instance which is been used in slowed >> down drawing. The `graphics` object is not initialized anywhere inside the >> class, where it is expected to set explicitly by the user. When the user >> doesn't se

Re: RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v6]

2022-08-08 Thread Alexey Ivanov
On Fri, 5 Aug 2022 20:26:31 GMT, Phil Race wrote: >> Is that possible? Toolkit thread is not EDT, therefore native events are >> processed, it's probably enough to update the frame coordinates while EDT is >> blocked and doesn't handle events. > > Can you expand on what you mean ? > What's the

Re: RFR: 8281966: Absolute path of symlink is null in JFileChooser [v7]

2022-08-08 Thread Alexey Ivanov
On Mon, 8 Aug 2022 04:13:17 GMT, Tejesh R wrote: >> Absolute path of Symbolic Link created in Windows is set to `null` in >> `BasicFileChooserUI` class. This happens when propertyChangeListener is >> implemented to get the Symbolic link's Absolute path on Mouse click through >> JFileChooser. T

Integrated: 8064787: [macosx] In Nimbus LaF, Ctrl+Alt mnemonic doesn't work

2022-08-08 Thread Prasanta Sadhukhan
On Thu, 14 Jul 2022 08:03:34 GMT, Prasanta Sadhukhan wrote: > In SwingSet2 application, "File" menu has a visible mnemonic set on F. > > ![image](https://user-images.githubusercontent.com/43534309/178932400-ab70602a-9c4f-4cab-b3b7-0508b26d2ebe.png) > > Now, in MacOS, with Aqua, Java (Metal), a

Integrated: 8259687: JTabbedPane.setComponentAt doesn't hide previously visible tab component

2022-08-08 Thread Harshitha Onkar
On Thu, 28 Jul 2022 21:38:56 GMT, Harshitha Onkar wrote: > A simple change listener is used in JTabbedPane to lazily fill with > components - this is done by adding the components to JTabbedPane using the > `setComponentAt` in the change listener. > > Previously, if the change listener was pla

Re: RFR: 7189422: [macosx] Submenu's arrow have a wrong position

2022-08-08 Thread Prasanta Sadhukhan
On Fri, 5 Aug 2022 17:34:00 GMT, Phil Race wrote: >> Issue is Arrow in submenu with empty title have a wrong position in Aqua L&F >> as can be seen >> >> > src="https://user-images.githubusercontent.com/43534309/183023538-de8e51b4-31e6-45d7-b2bd-35da5e29c1e8.png";> >> >> >> which is because t

Re: RFR: 8054572: [macosx] JComboBox paints the border incorrectly [v2]

2022-08-08 Thread Damon Nguyen
On Thu, 14 Jul 2022 16:25:12 GMT, Damon Nguyen wrote: > Can you please show before and after fix image of the editable combobox? It > seems the border around the button makes it feel it's still not aligned > properly which gives the impression that the button is bigger than textfield. > Probab

Re: RFR: 8292026: Remove redundant allocations from DoubleByteEncoder

2022-08-08 Thread Dio Brando
On Fri, 5 Aug 2022 07:07:57 GMT, Andrey Turbanov wrote: > There are couple places where new byte array is allocated and then thrown > away. Marked as reviewed by aj1032...@github.com (no known OpenJDK username). - PR: https://git.openjdk.org/jdk/pull/9767

Re: RFR: 8291266: RenderPerfTest: missing content while rendering some primitives [v2]

2022-08-08 Thread Ajit Ghaisas
On Fri, 5 Aug 2022 18:01:26 GMT, Alexey Ushakov wrote: >> Do not cause redundant endEncoder calls with batch processing of drawing >> primitives > > Alexey Ushakov has updated the pull request incrementally with one additional > commit since the last revision: > > 8291266: RenderPerfTest: mi

Re: RFR: 8292026: Remove redundant allocations from DoubleByteEncoder

2022-08-08 Thread Сергей Цыпанов
On Fri, 5 Aug 2022 07:07:57 GMT, Andrey Turbanov wrote: > There are couple places where new byte array is allocated and then thrown > away. Marked as reviewed by stsypa...@github.com (no known OpenJDK username). - PR: https://git.openjdk.org/jdk/pull/9767

Re: RFR: 8292026: Remove redundant allocations from DoubleByteEncoder

2022-08-08 Thread Сергей Цыпанов
On Fri, 5 Aug 2022 07:07:57 GMT, Andrey Turbanov wrote: > There are couple places where new byte array is allocated and then thrown > away. Nice catch! - Marked as reviewed by stsypa...@github.com (no known OpenJDK username). PR: https://git.openjdk.org/jdk/pull/9767

RFR: 8292026: Remove redundant allocations from DoubleByteEncoder

2022-08-08 Thread Andrey Turbanov
There are couple places where new byte array is allocated and then thrown away. - Commit messages: - [PATCH] Remove redundant allocations from DoubleByteEncoder Changes: https://git.openjdk.org/jdk/pull/9767/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9767&range=00 Iss