On Tue, 4 Oct 2022 18:31:01 GMT, Alexey Ivanov wrote:
>> That was my initial thought too. But, as the loopCount won't be really large
>> (Eg. it is 15 for 300% scaling) and it wouldn't affect the performance
>> drastically, I have retained the original approach to draw the bulk of the
>> borde
On Tue, 4 Oct 2022 19:50:15 GMT, Alexey Ivanov wrote:
> It looks good to me, except for the comments I left on the coding style.
>
> Yet there's one thing which I noticed in the rendered border. The top left
> corner has one pixel which is painted over the title bar. It's present in the
> orig
Many `installDefaults` methods set the font, foreground, and background on
objects but their inverse methods `uninstallDefaults` do not remove them. I've
added an inverse method to remove the colors and font to call for the
`uninstallDefaults` methods that install defaults.
`AquaButtonUI` can c
> JInternalFrame background color seems to overflow into the border region.
> This issue is more prominently seen on Windows - Metal LAF (with fractional
> scaling, as shown below). The primary reason is border scaling issue as
> observed in - [JDK-8279614](https://bugs.openjdk.org/browse/JDK-82
On Tue, 4 Oct 2022 20:37:35 GMT, Harshitha Onkar wrote:
>> JInternalFrame background color seems to overflow into the border region.
>> This issue is more prominently seen on Windows - Metal LAF (with fractional
>> scaling, as shown below). The primary reason is border scaling issue as
>> obse
> JInternalFrame background color seems to overflow into the border region.
> This issue is more prominently seen on Windows - Metal LAF (with fractional
> scaling, as shown below). The primary reason is border scaling issue as
> observed in - [JDK-8279614](https://bugs.openjdk.org/browse/JDK-82
On Tue, 4 Oct 2022 20:21:10 GMT, Alexey Ivanov wrote:
> I fixed the typo “serie” → "series" which was highlighted by a spellchecker.
>
> I also simplified the description, fixed the grammar, added `{@code}` around
> types, added link to `requestFocus` in the example.
src/java.desktop/share/cla
On Tue, 4 Oct 2022 20:21:10 GMT, Alexey Ivanov wrote:
> I fixed the typo “serie” → "series" which was highlighted by a spellchecker.
>
> I also simplified the description, fixed the grammar, added `{@code}` around
> types, added link to `requestFocus` in the example.
src/java.desktop/share/cla
I fixed the typo “serie” → "series" which was highlighted by a spellchecker.
I also simplified the description, fixed the grammar, added `{@code}` around
types, added link to `requestFocus` in the example.
-
Commit messages:
- Amend the javadoc for SunToolkit.realSync(long)
Change
On Tue, 4 Oct 2022 18:35:34 GMT, Harshitha Onkar wrote:
>> [`roundHalfDown`](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/math/RoundingMode.html#HALF_DOWN)?
>
> @stanio Thank you for the suggestion- roundHalfDown fits the rounding
> functionality I was looking for.
Since yo
On Tue, 4 Oct 2022 17:48:55 GMT, Harshitha Onkar wrote:
>> JInternalFrame background color seems to overflow into the border region.
>> This issue is more prominently seen on Windows - Metal LAF (with fractional
>> scaling, as shown below). The primary reason is border scaling issue as
>> obse
On Tue, 4 Oct 2022 19:37:32 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review changes, saving a scaled version of image
>
> test/jdk/javax/swing/JInternalFrame/InternalFrameBorderTest.jav
On Tue, 4 Oct 2022 17:48:55 GMT, Harshitha Onkar wrote:
>> JInternalFrame background color seems to overflow into the border region.
>> This issue is more prominently seen on Windows - Metal LAF (with fractional
>> scaling, as shown below). The primary reason is border scaling issue as
>> obse
On Fri, 23 Sep 2022 01:11:14 GMT, SWinxy wrote:
> I also took the opportunity to link to `realSync(long)`.
>
> /**
> * Parameterless version of realsync which uses default timout (see
> DEFAUL_WAIT_TIME).
> */
>
>
> /**
> * Parameterless version of {@link #realSync(long)} which uses
>
On Fri, 23 Sep 2022 01:11:14 GMT, SWinxy wrote:
> I also took the opportunity to link to `realSync(long)`.
>
> /**
> * Parameterless version of realsync which uses default timout (see
> DEFAUL_WAIT_TIME).
> */
>
>
> /**
> * Parameterless version of {@link #realSync(long)} which uses
>
On Mon, 3 Oct 2022 06:41:03 GMT, Jayathirth D V wrote:
>> src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageWriter.java
>> line 1463:
>>
>>> 1461: return false;
>>> 1462: }
>>> 1463: if (compressionType == BI_RLE4 && bpp != 4) {
>>
>> I'm confused.
On Mon, 26 Sep 2022 13:20:36 GMT, Jayathirth D V wrote:
>> This is redo of https://bugs.openjdk.org/browse/JDK-8262297
>> In https://bugs.openjdk.org/browse/JDK-8262297 we added similar change but
>> we didnt allow 15bpp image in BMP, because of which many tests which were
>> using USHORT_555_R
On Tue, 4 Oct 2022 18:32:33 GMT, Alexey Ivanov wrote:
>>> Out of curiosity, can this test use `BufferedImage` to render
>>> `JInternalFrame` into?
>>
>> @aivanov-jdk Thank you for reviewing. I wanted to clarify whether you meant
>> saving just the JInternalFrame into BufferedImage?
>
>> > Out
On Mon, 3 Oct 2022 13:59:25 GMT, Jayathirth D V wrote:
> In https://bugs.openjdk.org/browse/JDK-8270915 we have a valid GIF image
> which was generated using a third party app, but it contains large amount of
> Metadata(numerous Application extension blocks).
>
> Also GIFImageReader doesn't us
On Mon, 3 Oct 2022 20:37:11 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated the
On Mon, 3 Oct 2022 22:29:06 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line
>> 336:
>>
>>> 334: // Draw the Long highlight lines
>>> 335: g.setColor(highlight);
>>> 336: g.drawLine(scaled
On Mon, 3 Oct 2022 22:43:40 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line
>> 329:
>>
>>> 327:
>>> 328: // Draw the bulk of the border
>>> 329: for (int i = 1; i <= loopCount; i++) {
>>
>> Should we redo the
On Tue, 4 Oct 2022 18:26:26 GMT, Stanimir Stamenkov wrote:
>> Yes, that is correct. The method doc does clarify the purpose. But I see
>> your point - probably `roundOff()` would sound less ambiguous and neutral?
>
> [`roundHalfDown`](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/
On Mon, 3 Oct 2022 22:16:56 GMT, Harshitha Onkar wrote:
> > Out of curiosity, can this test use `BufferedImage` to render
> > `JInternalFrame` into?
>
> @aivanov-jdk Thank you for reviewing. I wanted to clarify whether you meant
> saving just the JInternalFrame into BufferedImage?
Yes, just `
On Tue, 4 Oct 2022 18:23:17 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line
>> 255:
>>
>>> 253: * @return a {@code int} which is the rounded value of
>>> provided number
>>> 254: */
>>> 255: private static in
On Mon, 3 Oct 2022 22:02:28 GMT, Alisen Chung wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed redundant jtreg header
>
> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line
> 25
On Wed, 28 Sep 2022 15:32:11 GMT, Michael Ernst wrote:
> The title was edited by someone other than me, as you can see from the PR
> history.
The PR title needs to match the CR synopsis, so update the CR first, and then
update the PR.
-
PR: https://git.openjdk.org/jdk/pull/10029
On Tue, 4 Oct 2022 17:57:46 GMT, Damon Nguyen wrote:
>> src/java.desktop/share/legal/freetype.md line 542:
>>
>>> 540: /*
>>> 541: * Copyright 2000 Computing Research Labs, New Mexico State University
>>> 542: * Copyright 2001-2015
>>
>> Why did this notice need to be moved down to the end of
On Tue, 4 Oct 2022 18:03:39 GMT, Damon Nguyen wrote:
>> Update the freetype md file with the newly generated md file from
>> attribution tool. The new format slightly differs from the previous version
>> when separating different licenses. Added logic for combining of copyright
>> lines and su
On Mon, 3 Oct 2022 21:57:17 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed redundant jtreg header
>
> Out of curiosity, can this test use `BufferedImage` to render
> `JInternalFrame`
On Fri, 12 Aug 2022 23:10:01 GMT, lawrence.andrews wrote:
> 1) Fixed Parse Exception by removing yesno
> test result: Error. Parse Exception: Arguments to `manual' option not
> supported: yesno
> 2) Throw jtreg.SkippedException when printer is not configured on the test
> host
> 3) Replaced Sys
On Tue, 4 Oct 2022 17:52:05 GMT, Phil Race wrote:
>> Damon Nguyen has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits sinc
On Tue, 4 Oct 2022 17:55:51 GMT, Phil Race wrote:
>> src/java.desktop/share/legal/freetype.md line 2:
>>
>>> 1: ## The FreeType Project: Freetype v2.12.1
>>> 2:
>>
>> Why does this show a .0 -> .1 update ?
>> The currently checked in file was updated in July so it already has .1 .. so
>> that
On Tue, 4 Oct 2022 17:49:40 GMT, Phil Race wrote:
>> Damon Nguyen has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits sinc
On Tue, 4 Oct 2022 18:00:32 GMT, Damon Nguyen wrote:
>> Update the freetype md file with the newly generated md file from
>> attribution tool. The new format slightly differs from the previous version
>> when separating different licenses. Added logic for combining of copyright
>> lines and su
> Update the freetype md file with the newly generated md file from attribution
> tool. The new format slightly differs from the previous version when
> separating different licenses. Added logic for combining of copyright lines
> and support for other licenses such as MIT.
Damon Nguyen has upd
On Mon, 3 Oct 2022 21:18:55 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed redundant jtreg header
>
> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java line
> 3
> JInternalFrame background color seems to overflow into the border region.
> This issue is more prominently seen on Windows - Metal LAF (with fractional
> scaling, as shown below). The primary reason is border scaling issue as
> observed in - [JDK-8279614](https://bugs.openjdk.org/browse/JDK-82
Update the freetype md file with the newly generated md file from attribution
tool. The new format slightly differs from the previous version when separating
different licenses. Added logic for combining of copyright lines and support
for other licenses such as MIT.
-
Commit messag
On Wed, 21 Sep 2022 20:15:48 GMT, Alisen Chung wrote:
> changed return to cleanup in getAllConfigs
> changed cleanup to loop thru and free all allocated memory adjacent to
> graphicsConfig pointer
This pull request has now been integrated.
Changeset: 1166a8ab
Author:Alisen Chung
Committer
On Mon, 3 Oct 2022 20:56:48 GMT, Alisen Chung wrote:
>> changed return to cleanup in getAllConfigs
>> changed cleanup to loop thru and free all allocated memory adjacent to
>> graphicsConfig pointer
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since t
On Fri, 23 Sep 2022 01:11:14 GMT, SWinxy wrote:
> I also took the opportunity to link to `realSync(long)`.
>
> /**
> * Parameterless version of realsync which uses default timout (see
> DEFAUL_WAIT_TIME).
> */
>
>
> /**
> * Parameterless version of {@link #realSync(long)} which uses
>
> When a custom `FileView` is used and folder traversal is restricted to a
> particular directory NPE occurs when user tries to traverse/select other
> folders except traversable folder. This is caused because when user selects
> folder other than traversable, the traversal is rejected and hence
43 matches
Mail list logo
