On Fri, 7 Oct 2022 19:50:19 GMT, Alexey Ivanov wrote:
>> I guess Integer.MAX_VALUE should be valid "int" value, its because of
>> internal calculation which is causing it to overflow so I guess we should
>> not update the spec for wrongful calculation.
>> I have fixed the overflow in
> DefaultListSelectionModel.removeIndexInterva accepts `int` value which allows
> it to take in Integer.MAX_VALUE theoratically but it does calculation with
> that value which can results in IOOBE.
> Fix is to make sure the calculation stays within bounds.
Prasanta Sadhukhan has updated the
On Tue, 11 Oct 2022 14:17:42 GMT, Manukumar V S wrote:
> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS
> machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as
> adding some stability improvements fixes the issue. It intermittently fails
> in CI
On Mon, 10 Oct 2022 19:05:50 GMT, Harshitha Onkar wrote:
> Suggestion: Does running the test - CustomComboBoxFocusTest.java with uiScale
> always set to 1 make it more robust?
Sure, I can add a uiscale of 1 for robustness. Seems like a good idea since
Jay's results at different uiscales may
> The previous change to AquaComboBoxUI had 1 pixel of overlap between the text
> field and the combo button. This caused a few pixels to darken sometimes when
> an editable combobox is displayed. Since this test passes sometimes and fails
> some other times, it was not initially detected.
>
>
On Tue, 11 Oct 2022 07:08:57 GMT, Prasanta Sadhukhan
wrote:
>> Damon Nguyen has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge branch 'master' into 8294254/overlapFixEditableCombobox
>> - Merge branch
java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS
machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as
adding some stability improvements fixes the issue. It intermittently fails in
CI causing some noise. This test was already problem listed in
On Fri, 7 Oct 2022 13:36:17 GMT, Manukumar V S wrote:
> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS
> machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as
> adding some stability improvements fixes the issue. It intermittently fails
> in CI
On Mon, 10 Oct 2022 17:59:23 GMT, Sergey Bylokhov wrote:
>> But, is there any way we can capture the current screen where the frame is
>> displayed?
>
> You can pass coordinates/bounds of that screen to the createScreenCapture.
Will do that in a new PR as something went wrong with this and
On Tue, 11 Oct 2022 13:48:34 GMT, Alexey Ivanov wrote:
> You did something wrong, now there are 40 commits and 126 files changed. It
> doesn't look right.
>
> Merging master should result in one commit only even though it brings
> multiple commits into the history.
Yea, I have seen that. I
On Fri, 7 Oct 2022 13:36:17 GMT, Manukumar V S wrote:
> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS
> machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as
> adding some stability improvements fixes the issue. It intermittently fails
> in CI
> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS
> machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as
> adding some stability improvements fixes the issue. It intermittently fails
> in CI causing some noise. This test was already problem listed
On Thu, 22 Sep 2022 12:48:14 GMT, Abhishek Kumar wrote:
> When a user selects ../ from directory list in GTK FileChooser continuosly,
> it leads to '../../../.' in combobox and selection textarea even though
> it the current directory is at root level.
>
> Fix for the issue is to remove
On Tue, 11 Oct 2022 10:12:47 GMT, Abhishek Kumar wrote:
>> When a user selects ../ from directory list in GTK FileChooser continuosly,
>> it leads to '../../../.' in combobox and selection textarea even though
>> it the current directory is at root level.
>>
>> Fix for the issue is to
On Tue, 11 Oct 2022 10:42:46 GMT, Prasanta Sadhukhan
wrote:
> Please confirm that along with ubuntu, you have tested on Oracle Linux too.
I have checked in Oracle Linux, Fix is working fine.
-
PR: https://git.openjdk.org/jdk/pull/10390
It's still there.
https://github.com/openjdk/jdk/tree/master/src/demo/share/jfc/SwingSet2
Btw, client-libs-dev@openjdk.org (included) is the relevant mailing list
for this message, not core-libs-dev.
-- Kevin
On 10/11/2022 1:54 AM, David Holmes wrote:
On 11/10/2022 4:38 pm, Amit wrote:
On Thu, 29 Sep 2022 11:12:41 GMT, Tejesh R wrote:
> When a custom `FileView` is used and folder traversal is restricted to a
> particular directory NPE occurs when user tries to traverse/select other
> folders except traversable folder. This is caused because when user selects
> folder other
On Tue, 11 Oct 2022 07:52:42 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JFileChooser/FileViewNPETest.java line 39:
>
>> 37: * @test
On Tue, 11 Oct 2022 10:35:35 GMT, Tejesh R wrote:
>> When a custom `FileView` is used and folder traversal is restricted to a
>> particular directory NPE occurs when user tries to traverse/select other
>> folders except traversable folder. This is caused because when user selects
>> folder
On Tue, 11 Oct 2022 10:12:47 GMT, Abhishek Kumar wrote:
>> When a user selects ../ from directory list in GTK FileChooser continuosly,
>> it leads to '../../../.' in combobox and selection textarea even though
>> it the current directory is at root level.
>>
>> Fix for the issue is to
On Tue, 11 Oct 2022 10:12:47 GMT, Abhishek Kumar wrote:
>> When a user selects ../ from directory list in GTK FileChooser continuosly,
>> it leads to '../../../.' in combobox and selection textarea even though
>> it the current directory is at root level.
>>
>> Fix for the issue is to
Hi Phillip:
Actual name is Anton. Understood.
For various reasons, I am not interested in becoming a contributor at this
point. I was simply looking for a current contributor that would pick up a
small change. I'll drop this.
Thank you all.
Anton
From: Philip Race
On Tue, 11 Oct 2022 10:27:23 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JFileChooser/FileViewNPETest.java line 39:
>
>> 37: * @test
> When a custom `FileView` is used and folder traversal is restricted to a
> particular directory NPE occurs when user tries to traverse/select other
> folders except traversable folder. This is caused because when user selects
> folder other than traversable, the traversal is rejected and
On Tue, 11 Oct 2022 04:54:14 GMT, Tejesh R wrote:
>> When a custom `FileView` is used and folder traversal is restricted to a
>> particular directory NPE occurs when user tries to traverse/select other
>> folders except traversable folder. This is caused because when user selects
>> folder
On Tue, 11 Oct 2022 10:15:10 GMT, Tejesh R wrote:
>> When a custom `FileView` is used and folder traversal is restricted to a
>> particular directory NPE occurs when user tries to traverse/select other
>> folders except traversable folder. This is caused because when user selects
>> folder
On Tue, 11 Oct 2022 07:46:06 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JFileChooser/FileViewNPETest.java line 77:
>
>> 75:
On Tue, 11 Oct 2022 08:54:45 GMT, Abhishek Kumar wrote:
>>> Few lines are going beyond 80 columns, can you please update them?
>>
>> I agree, line 80 could be wrapped, it's 92 columns long. At the same, I
>> wouldn't have insisted because it contains the parameters to
>> `PassFailJFrame`
On Tue, 11 Oct 2022 08:50:48 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JFileChooser/FileViewNPETest.java line 39:
>>
>>> 37: * @test
>>> 38: * @bug 6616245
>>> 39: * @key headful
>>
>> Is it required to have a `key` tag for manual test case?
>
>> Is it required to have a `key` tag
> When a custom `FileView` is used and folder traversal is restricted to a
> particular directory NPE occurs when user tries to traverse/select other
> folders except traversable folder. This is caused because when user selects
> folder other than traversable, the traversal is rejected and
> When a user selects ../ from directory list in GTK FileChooser continuosly,
> it leads to '../../../.' in combobox and selection textarea even though
> it the current directory is at root level.
>
> Fix for the issue is to remove "../" entry from JFileChooser directory list
> in GTK LAF
On Tue, 11 Oct 2022 09:55:23 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix
>
> test/jdk/javax/swing/JFileChooser/TestFileChooserDirectorySelection.java line
> 34:
>
On Tue, 11 Oct 2022 09:10:10 GMT, Abhishek Kumar wrote:
>> When a user selects ../ from directory list in GTK FileChooser continuosly,
>> it leads to '../../../.' in combobox and selection textarea even though
>> it the current directory is at root level.
>>
>> Fix for the issue is to
> When a user selects ../ from directory list in GTK FileChooser continuosly,
> it leads to '../../../.' in combobox and selection textarea even though
> it the current directory is at root level.
>
> Fix for the issue is to remove "../" entry from JFileChooser directory list
> in GTK LAF
On Tue, 11 Oct 2022 07:31:10 GMT, Abhishek Kumar wrote:
>> I guess that's what you commented "if current directory is root"
>
> Ok... I will check this.
> Is it not possible to use "FileSystemView.isFileSystemRoot(File)" for this?
Updated.
-
PR:
On Tue, 11 Oct 2022 04:54:14 GMT, Tejesh R wrote:
>> When a custom `FileView` is used and folder traversal is restricted to a
>> particular directory NPE occurs when user tries to traverse/select other
>> folders except traversable folder. This is caused because when user selects
>> folder
On Tue, 11 Oct 2022 08:48:20 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JFileChooser/FileViewNPETest.java line 80:
>>
>>> 78: """;
>>> 79: frame = new JFrame("JFileChooser File View NPE test");
>>> 80: passFailJFrame = new PassFailJFrame("Test
On Tue, 11 Oct 2022 07:52:42 GMT, Abhishek Kumar wrote:
> Is it required to have a `key` tag for manual test case?
A manual test is declared by its `@run` tag:
* @run main/manual FileViewNPETest
If `-a` (automatic tests) is passed to jtreg, this test isn't selected for
running.
On Tue, 11 Oct 2022 07:57:26 GMT, Abhishek Kumar wrote:
> Few lines are going beyond 80 columns, can you please update them?
I agree, line 80 could be wrapped, it's 92 columns long. At the same, I
wouldn't have insisted because it contains the parameters to `PassFailJFrame`
which aren't so
On Tue, 11 Oct 2022 04:54:14 GMT, Tejesh R wrote:
>> When a custom `FileView` is used and folder traversal is restricted to a
>> particular directory NPE occurs when user tries to traverse/select other
>> folders except traversable folder. This is caused because when user selects
>> folder
On Tue, 11 Oct 2022 04:54:14 GMT, Tejesh R wrote:
>> When a custom `FileView` is used and folder traversal is restricted to a
>> particular directory NPE occurs when user tries to traverse/select other
>> folders except traversable folder. This is caused because when user selects
>> folder
On Tue, 11 Oct 2022 04:54:14 GMT, Tejesh R wrote:
>> When a custom `FileView` is used and folder traversal is restricted to a
>> particular directory NPE occurs when user tries to traverse/select other
>> folders except traversable folder. This is caused because when user selects
>> folder
On Tue, 11 Oct 2022 07:22:32 GMT, Prasanta Sadhukhan
wrote:
>> I have not checked this.
>> Do you mean to check `FileSystemView.isFileSystemRoot(crntDir )` ?
>
> I guess that's what you commented "if current directory is root"
Ok... I will check this.
-
PR:
On Tue, 11 Oct 2022 07:06:35 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKFileChooserUI.java
>> line 997:
>>
>>> 995: File crntDir = getFileChooser().getCurrentDirectory();
>>> 996: if (crntDir != null &&
On Mon, 10 Oct 2022 18:41:24 GMT, Damon Nguyen wrote:
>> The previous change to AquaComboBoxUI had 1 pixel of overlap between the
>> text field and the combo button. This caused a few pixels to darken
>> sometimes when an editable combobox is displayed. Since this test passes
>> sometimes and
On Tue, 11 Oct 2022 07:02:18 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix and test case changed to manual
>
>
On Tue, 11 Oct 2022 06:42:37 GMT, Abhishek Kumar wrote:
>> When a user selects ../ from directory list in GTK FileChooser continuosly,
>> it leads to '../../../.' in combobox and selection textarea even though
>> it the current directory is at root level.
>>
>> Fix for the issue is to
On Tue, 11 Oct 2022 06:42:37 GMT, Abhishek Kumar wrote:
>> When a user selects ../ from directory list in GTK FileChooser continuosly,
>> it leads to '../../../.' in combobox and selection textarea even though
>> it the current directory is at root level.
>>
>> Fix for the issue is to
On Mon, 26 Sep 2022 14:05:04 GMT, Jayathirth D V wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Comment added and test case condotion update
>
> What is the behaviour in other LAF's?
> Also lets change title of
> When a user selects ../ from directory list in GTK FileChooser continuosly,
> it leads to '../../../.' in combobox and selection textarea even though
> it the current directory is at root level.
>
> Fix for the issue is to check if current directory is root then don't process
> the
On Mon, 10 Oct 2022 18:41:24 GMT, Damon Nguyen wrote:
>> The previous change to AquaComboBoxUI had 1 pixel of overlap between the
>> text field and the combo button. This caused a few pixels to darken
>> sometimes when an editable combobox is displayed. Since this test passes
>> sometimes and
On Mon, 10 Oct 2022 18:41:24 GMT, Damon Nguyen wrote:
>> The previous change to AquaComboBoxUI had 1 pixel of overlap between the
>> text field and the combo button. This caused a few pixels to darken
>> sometimes when an editable combobox is displayed. Since this test passes
>> sometimes and
On Wed, 21 Sep 2022 08:03:24 GMT, Andrey Turbanov wrote:
> Fields `methods`, `properties`, `eventSets` are not volatile and read
> multiple times. This makes it an incorrect DCL.
This pull request has now been integrated.
Changeset: e775acf8
Author:Andrey Turbanov
URL:
On Mon, 10 Oct 2022 17:23:16 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JFileChooser/FileViewNPETest.java line 82:
>
>> 80:
54 matches
Mail list logo
