Re: RFR: 8295248: JEditorPane HTML form with multi selection broke drawing after reseting [v2]

2022-10-21 Thread Damon Nguyen
On Mon, 17 Oct 2022 01:38:00 GMT, Toshio Nakamura wrote: >> When JEditorPane shown HTML form with multi-selection, the reset operation >> broke its drawing. >> >> There are two issues. The current method >> `OptionListModel.removeIndexInterval()` disabled selections, but it didn't >> fire

Re: RFR: JDK-8015739: Background of JInternalFrame is located out of JInternalFrame [v11]

2022-10-21 Thread Harshitha Onkar
On Fri, 21 Oct 2022 22:21:09 GMT, Harshitha Onkar wrote: >> JInternalFrame background color seems to overflow into the border region. >> This issue is more prominently seen on Windows - Metal LAF (with fractional >> scaling, as shown below). The primary reason is border scaling issue as >>

Re: RFR: JDK-8015739: Background of JInternalFrame is located out of JInternalFrame [v11]

2022-10-21 Thread Harshitha Onkar
> JInternalFrame background color seems to overflow into the border region. > This issue is more prominently seen on Windows - Metal LAF (with fractional > scaling, as shown below). The primary reason is border scaling issue as > observed in -

Re: RFR: 6187113: DefaultListSelectionModel.removeIndexInterval(0, Integer.MAX_VALUE) fails [v7]

2022-10-21 Thread Alexey Ivanov
On Fri, 21 Oct 2022 03:37:16 GMT, Prasanta Sadhukhan wrote: >> DefaultListSelectionModel.removeIndexInterva accepts `int` value which >> allows it to take in Integer.MAX_VALUE theoratically but it does calculation >> with that value which can results in IOOBE. >> Fix is to make sure the

RFR: 8295430: Use cmsDoTransformLineStride instead of cmsDoTransform in the loop

2022-10-21 Thread Sergey Bylokhov
This is the request to improve the change made by the [8005530: [lcms] Improve performance of ColorConverOp for default destinations](http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fd8810d50c99) Right now the LCMSTransform mantain the special "imageAtOnce" flags and call cmsDoTransform function

Re: RFR: 8295430: Use cmsDoTransformLineStride instead of cmsDoTransform in the loop

2022-10-21 Thread Sergey Bylokhov
On Wed, 19 Oct 2022 02:59:37 GMT, Sergey Bylokhov wrote: > This is the request to improve the change made by the > [8005530: [lcms] Improve performance of ColorConverOp for default > destinations](http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fd8810d50c99) > > Right now the LCMSTransform

Re: RFR: 8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java [v2]

2022-10-21 Thread Sergey Bylokhov
On Fri, 21 Oct 2022 16:10:17 GMT, Alexey Ivanov wrote: >> The automated test follows the instructions of the manual test that was >> added in #10485. >> >> Instead of selecting the parent folder from the **Look in** combo box, it >> calls `setCurrentDirectory` directly with the parent of the

Re: RFR: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java [v2]

2022-10-21 Thread Sergey Bylokhov
On Fri, 21 Oct 2022 11:34:05 GMT, Alexey Ivanov wrote: >> This automates the test added in #9327. >> >> The test has a set of objects which store the size of the file and the >> expected displayed size, the file name is generated automatically. The >> pattern for the file names ensures the

Re: RFR: 8295554: Move the "sizecalc.h" to the correct location

2022-10-21 Thread Sergey Bylokhov
On Fri, 21 Oct 2022 10:18:26 GMT, Magnus Ihse Bursie wrote: > Can you please refrain from integrating this while I investigate while this > was originally moved? sure. - PR: https://git.openjdk.org/jdk/pull/10757

Re: RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation

2022-10-21 Thread SWinxy
On Fri, 21 Oct 2022 08:42:12 GMT, Alexander Scherbatiy wrote: > A printed content is truncated on macOS if the content paper size width > larger than height with portrait orientation or width is less than height > with landscape orientation. > > To reproduce the issue run the >

Re: RFR: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java [v2]

2022-10-21 Thread Abhishek Kumar
On Fri, 21 Oct 2022 11:34:05 GMT, Alexey Ivanov wrote: >> This automates the test added in #9327. >> >> The test has a set of objects which store the size of the file and the >> expected displayed size, the file name is generated automatically. The >> pattern for the file names ensures the

RFR: 6244831: JFileChooser does not have tooltip for Desktop, Recent etc ToggleButton on Windows Look and feel

2022-10-21 Thread Tejesh R
Tooltip is not shown for the buttons placed in left side of JFileChooser(In Windows Look And Feel), namely the shellFolder like (Recent Items, Desktop, Documents). Hence the tooltip is added for those shell folders/WindowBar when they are constructed. The Automatic test is added. -

Re: RFR: 8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java [v2]

2022-10-21 Thread Alexey Ivanov
> The automated test follows the instructions of the manual test that was added > in #10485. > > Instead of selecting the parent folder from the **Look in** combo box, it > calls `setCurrentDirectory` directly with the parent of the path which is not > traversable. Thus, the current directory

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Andy Goryachev
On Fri, 21 Oct 2022 16:04:14 GMT, Naoto Sato wrote: > replace those dangling white spaces with explicit Unicode escapes this is a *very good* idea. - PR: https://git.openjdk.org/jdk/pull/10792

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Naoto Sato
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to

Re: RFR: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java [v2]

2022-10-21 Thread Alexey Ivanov
On Thu, 20 Oct 2022 23:36:40 GMT, Sergey Bylokhov wrote: >> Alexey Ivanov has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Set the locale to US >> - Adjust wrapping for error message >> - Use local variable to store first error

Re: RFR: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java [v2]

2022-10-21 Thread Alexey Ivanov
On Thu, 20 Oct 2022 23:31:58 GMT, Sergey Bylokhov wrote: >> Alexey Ivanov has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Set the locale to US >> - Adjust wrapping for error message >> - Use local variable to store first error

Re: RFR: 8295779: Xcode 14.0 fails to build jdk on m1 macos

2022-10-21 Thread Archie L . Cobbs
On Wed, 19 Oct 2022 15:33:31 GMT, Archie L. Cobbs wrote: > Building on MacOS 12.6 M1 with Xcode 14.0 fails due to C compiler unused > parameter warnings: > > Creating support/modules_libs/java.desktop/libosx.dylib from 1 file(s) Thanks for doing that! PR title updated. - PR:

Re: RFR: 8295779: Xcode 14.0 fails to build jdk on m1 macos

2022-10-21 Thread Vladimir Kempik
On Wed, 19 Oct 2022 15:33:31 GMT, Archie L. Cobbs wrote: > Building on MacOS 12.6 M1 with Xcode 14.0 fails due to C compiler unused > parameter warnings: > > Creating support/modules_libs/java.desktop/libosx.dylib from 1 file(s) Hello, a jbs bug needs to be created first, let me create one

RFR: 8295779: Xcode 14.0 fails to build jdk on m1 macos

2022-10-21 Thread Archie L . Cobbs
Building on MacOS 12.6 M1 with Xcode 14.0 fails due to C compiler unused parameter warnings: Creating support/modules_libs/java.desktop/libosx.dylib from 1 file(s) - Commit messages: - Fix build failure on MacOS 12.6 M1 with Xcode 14.0. Changes:

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Erik Joelsson
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to

Re: RFR: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java [v2]

2022-10-21 Thread Alexey Ivanov
On Thu, 20 Oct 2022 23:34:42 GMT, Sergey Bylokhov wrote: >> Alexey Ivanov has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Set the locale to US >> - Adjust wrapping for error message >> - Use local variable to store first error

Re: RFR: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java [v2]

2022-10-21 Thread Alexey Ivanov
On Thu, 20 Oct 2022 23:37:41 GMT, Sergey Bylokhov wrote: >> Alexey Ivanov has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Set the locale to US >> - Adjust wrapping for error message >> - Use local variable to store first error

Re: RFR: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java [v2]

2022-10-21 Thread Alexey Ivanov
> This automates the test added in #9327. > > The test has a set of objects which store the size of the file and the > expected displayed size, the file name is generated automatically. The > pattern for the file names ensures the files are displayed in the expected > order up to and including

Re: RFR: 8295554: Move the "sizecalc.h" to the correct location

2022-10-21 Thread Magnus Ihse Bursie
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote: > The "sizecalc.h" file is moved out from java.desktop/share/native/include, > the files in that folder appear in the jdk bundle after installation like the > "jawt.h". Can you please refrain from integrating this while I investigate

Re: RFR: 8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java

2022-10-21 Thread Tejesh R
On Thu, 20 Oct 2022 19:31:27 GMT, Alexey Ivanov wrote: > The automated test follows the instructions of the manual test that was added > in #10485. > > Instead of selecting the parent folder from the **Look in** combo box, it > calls `setCurrentDirectory` directly with the parent of the path

RFR: 8295737: macOS: Print content cut off when width > height with portrait orientation

2022-10-21 Thread Alexander Scherbatiy
A printed content is truncated on macOS if the content paper size width larger than height with portrait orientation or width is less than height with landscape orientation. To reproduce the issue run the [CutOffImage](https://bugs.openjdk.org/secure/attachment/101145/CutOffImage.java) sample

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Magnus Ihse Bursie
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v2]

2022-10-21 Thread Magnus Ihse Bursie
> Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the coverage of the > whitespace checks (in the old mercurial

Re: RFR: 8295767: Remove unused fields in sun.awt.geom.Edge

2022-10-21 Thread Sergey Bylokhov
On Sun, 16 Oct 2022 21:30:47 GMT, Andrey Turbanov wrote: > Remove couple of unused `static` fields in `sun.awt.geom.Edge` class. Looks fine. - PR: https://git.openjdk.org/jdk/pull/10720

Re: RFR: 8295767: Remove unused fields in sun.awt.geom.Edge

2022-10-21 Thread SWinxy
On Sun, 16 Oct 2022 21:30:47 GMT, Andrey Turbanov wrote: > Remove couple of unused `static` fields in `sun.awt.geom.Edge` class. I wonder what they were originally meant for. Some sort of growable list? - Marked as reviewed by swi...@github.com (no known OpenJDK username). PR:

RFR: 8295767: Remove unused fields in sun.awt.geom.Edge

2022-10-21 Thread Andrey Turbanov
Remove couple of unused `static` fields in `sun.awt.geom.Edge` class. - Commit messages: - [PATCH] Remove unused fields in sun.awt.geom.Edge Changes: https://git.openjdk.org/jdk/pull/10720/files Webrev: https://webrevs.openjdk.org/?repo=jdk=10720=00 Issue:

Re: RFR: 8295298: Automate javax/swing/JFileChooser/FileViewNPETest.java

2022-10-21 Thread Tejesh R
On Thu, 20 Oct 2022 19:31:27 GMT, Alexey Ivanov wrote: > The automated test follows the instructions of the manual test that was added > in #10485. > > Instead of selecting the parent folder from the **Look in** combo box, it > calls `setCurrentDirectory` directly with the parent of the path