> This testcase Verify the content changes of a TextField for the following
> assertions.
>
> a. TextListener get invoked when the content of a TextField gets changed.
> b. TextListener not get invoked during text selection or when Special keys
> such as Function Keys are pressed.
>
>
>
On Wed, 23 Nov 2022 18:46:22 GMT, Harshitha Onkar wrote:
>> ravi gupta has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8297489: bug added
>
> test/jdk/java/awt/event/ComponentEvent/TextFieldTextEventTest.java line 2:
>
>> 1: /*
>> 2:
On Tue, 22 Nov 2022 15:53:20 GMT, Abhishek Kumar wrote:
> If JFileChooser current directory is set to root directory then pressing
> BackSpace key changes to user's home directory in GTK LAF which is incorrect.
> It should remain at root directory. Planning to raise a new bug for this.
On Wed, 23 Nov 2022 20:40:33 GMT, Daniel D. Daugherty
wrote:
> This PR hasn't been touched in 8 days. I'm going to ProblemListing this test
> on windowx-x64 since we're up to 7 Tier3 failures in the jdk/jdk CI.
Working on getting more info about the failure since the issue is intermittent.
I
On Sun, 20 Nov 2022 09:10:48 GMT, Sergey Bylokhov wrote:
> The quality of the cmm library is increased since the bug was reported. This
> is the request to import the test from the bug description to improve the
> code coverage.
This pull request has now been integrated.
Changeset: abeddab9
On Wed, 23 Nov 2022 16:59:05 GMT, Naveen Narayanan wrote:
> This testcase will
> 1) Verify the handleQuitRequestWith() method of QuitHandler interface.
> 2) Check that the response is passed to the handler by means of quit
> notification generated by a key combination of META+Q (Mac) or
On Sun, 20 Nov 2022 09:10:48 GMT, Sergey Bylokhov wrote:
> The quality of the cmm library is increased since the bug was reported. This
> is the request to import the test from the bug description to improve the
> code coverage.
Added test locally and tested on all platforms. Looks good
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>>
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>>
On Wed, 23 Nov 2022 00:46:57 GMT, Harshitha Onkar wrote:
> Updated Metal Border code for JInternalFrame.
>
> - Added instanceof check before casting Graphics to G2D.
> - Replaced roundHalfDown with Region.clipRound()
Changes requested by aivanov (Reviewer).
On Wed, 23 Nov 2022 22:40:34 GMT, Alexey Ivanov wrote:
>> Updated Metal Border code for JInternalFrame.
>>
>> - Added instanceof check before casting Graphics to G2D.
>> - Replaced roundHalfDown with Region.clipRound()
>
> src/java.desktop/share/classes/javax/swing/plaf/metal/MetalBorders.java
On Fri, 11 Nov 2022 08:18:19 GMT, Tejesh R wrote:
> Observation found when JFileChooser is instantiated in WindowsLookAndFeel
> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find
> the exact root cause so predicting it to be an issue with icons not loaded
> where
On Wed, 23 Nov 2022 19:20:53 GMT, Daniel Fuchs wrote:
> The java.base/net/, java.http/, java.naming/ changes look reasonable to me -
> though like Alan I wonder if it wouldn't be better to have an inline `{@spec
> }` tag - similar to `{@systemProperty }`, rather than repeating all the
>
On Fri, 11 Nov 2022 08:18:19 GMT, Tejesh R wrote:
> Observation found when JFileChooser is instantiated in WindowsLookAndFeel
> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find
> the exact root cause so predicting it to be an issue with icons not loaded
> where
On Wed, 23 Nov 2022 18:57:03 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>>
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed in the `@spec` tags.
>
> "Somewhat automated" means that
On Wed, 23 Nov 2022 15:29:35 GMT, ravi gupta wrote:
>> This testcase Verify the content changes of a TextField for the following
>> assertions.
>>
>> a. TextListener get invoked when the content of a TextField gets changed.
>> b. TextListener not get invoked during text selection or when
On Wed, 23 Nov 2022 16:59:05 GMT, Naveen Narayanan wrote:
> This testcase will
> 1) Verify the handleQuitRequestWith() method of QuitHandler interface.
> 2) Check that the response is passed to the handler by means of quit
> notification generated by a key combination of META+Q (Mac) or
On Wed, 23 Nov 2022 15:29:35 GMT, ravi gupta wrote:
>> This testcase Verify the content changes of a TextField for the following
>> assertions.
>>
>> a. TextListener get invoked when the content of a TextField gets changed.
>> b. TextListener not get invoked during text selection or when
This testcase will
1) Verify the handleQuitRequestWith() method of QuitHandler interface.
2) Check that the response is passed to the handler by means of quit
notification generated by a key combination of META+Q (Mac) or ALT+F4(Windows &
Linux).
3) Confirm that the active window is closed.
On Wed, 23 Nov 2022 12:43:16 GMT, Daniel Fuchs wrote:
> Thanks for adding the RFC prefix to the RFC link. What is the purpose of
> editing non exported classes though, like those in the `sun.net` subpackages?
That was not intentional, and is a result of the scripted edit. I will look to
On Wed, 23 Nov 2022 08:18:32 GMT, Matthias Baesken wrote:
> Seems there is a remaining GetPrimitiveArrayCritical in imageioJPEG that
> misses a result - NULL check, this should be added.
Marked as reviewed by jdv (Reviewer).
> Hello , I did a few more grepping and source reading and while 98
> This testcase Verify the content changes of a TextField for the following
> assertions.
>
> a. TextListener get invoked when the content of a TextField gets changed.
> b. TextListener not get invoked during text selection or when Special keys
> such as Function Keys are pressed.
>
>
>
This testcase Verify the content changes of a TextField for the following
assertions.
a. TextListener get invoked when the content of a TextField gets changed.
b. TextListener not get invoked during text selection or when Special keys such
as Function Keys are pressed.
Testing:
Tested using
On Wed, 23 Nov 2022 14:26:34 GMT, Jayathirth D V wrote:
> Update header to add extra space
This pull request has now been integrated.
Changeset: e6e57fe8
Author:Jayathirth D V
URL:
https://git.openjdk.org/jdk/commit/e6e57fe86da44d43a21d2d6e2753f7a7bb5352ff
Stats: 2 lines in 1
On Wed, 23 Nov 2022 14:56:58 GMT, Alexey Ivanov wrote:
> It makes sense to copy the license header from another file in the same
> directory to make sure nothing's missing.
Exactly. That's how I spotted the second problem -- by doing a diff with
another file that wasn't touched by the PR in
On Wed, 23 Nov 2022 15:04:52 GMT, Daniel D. Daugherty
wrote:
> Here's the diffs that work:
Yes, that's what Jay tested.
-
PR: https://git.openjdk.org/jdk/pull/11324
On Wed, 23 Nov 2022 14:51:08 GMT, Jayathirth D V wrote:
>> Update header to add extra space
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update header to include extra space
With latest change i checked
On Wed, 23 Nov 2022 14:51:08 GMT, Jayathirth D V wrote:
>> Update header to add extra space
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update header to include extra space
Here's the diffs that work:
$ git diff
On Wed, 23 Nov 2022 15:08:13 GMT, Jayathirth D V wrote:
>> Update header to add extra space
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add additional space
Marked as reviewed by aivanov (Reviewer).
-
On Wed, 23 Nov 2022 15:08:13 GMT, Jayathirth D V wrote:
>> Update header to add extra space
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add additional space
Thumbs up.
-
Marked as reviewed by dcubed
On Wed, 23 Nov 2022 15:08:13 GMT, Jayathirth D V wrote:
>> Update header to add extra space
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add additional space
Updated fix looks good now.
Marked as reviewed by kcr
> Update header to add extra space
Jayathirth D V has updated the pull request incrementally with one additional
commit since the last revision:
Add additional space
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11324/files
- new:
On Wed, 23 Nov 2022 14:51:08 GMT, Jayathirth D V wrote:
>> Update header to add extra space
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update header to include extra space
It makes sense to copy the license header
On Wed, 23 Nov 2022 14:51:08 GMT, Jayathirth D V wrote:
>> Update header to add extra space
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update header to include extra space
Marked as reviewed by dfuchs (Reviewer).
On Wed, 23 Nov 2022 14:51:08 GMT, Jayathirth D V wrote:
>> Update header to add extra space
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update header to include extra space
I think you have another missing space.
I
On Wed, 23 Nov 2022 14:45:17 GMT, Jayathirth D V wrote:
>> The reason for the Tier1 build failure is a missing space (the official
>> license template has two spaces after the `.` and before `Oracle designates')
>
> Thanks Kevin. I have updated the PR.
This is not an easy thing to see.
On Wed, 23 Nov 2022 14:39:50 GMT, Kevin Rushforth wrote:
>> src/java.desktop/share/classes/sun/java2d/marlin/DPQSSorterContext.java line
>> 7:
>>
>>> 5: * This code is free software; you can redistribute it and/or modify it
>>> 6: * under the terms of the GNU General Public License version 2
On Wed, 23 Nov 2022 14:45:37 GMT, Jayathirth D V wrote:
>> Update header to add extra space
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update header to include extra space
Presuming this passes Tier1, this looks
On Wed, 23 Nov 2022 14:45:37 GMT, Jayathirth D V wrote:
>> Update header to add extra space
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update header to include extra space
Marked as reviewed by ihse (Reviewer).
On Wed, 23 Nov 2022 14:45:37 GMT, Jayathirth D V wrote:
>> Update header to add extra space
>
> Jayathirth D V has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update header to include extra space
Marked as reviewed by aivanov (Reviewer).
> Update header to add extra space
Jayathirth D V has updated the pull request incrementally with one additional
commit since the last revision:
Update header to include extra space
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11324/files
- new:
On Wed, 23 Nov 2022 14:37:06 GMT, Kevin Rushforth wrote:
>> Update header to remove classpath exception
>
> src/java.desktop/share/classes/sun/java2d/marlin/DPQSSorterContext.java line
> 7:
>
>> 5: * This code is free software; you can redistribute it and/or modify it
>> 6: * under the terms
On Wed, 23 Nov 2022 14:26:34 GMT, Jayathirth D V wrote:
> Update header to remove classpath exception
src/java.desktop/share/classes/sun/java2d/marlin/DPQSSorterContext.java line 7:
> 5: * This code is free software; you can redistribute it and/or modify it
> 6: * under the terms of the GNU
On Wed, 23 Nov 2022 08:18:32 GMT, Matthias Baesken wrote:
> Seems there is a remaining GetPrimitiveArrayCritical in imageioJPEG that
> misses a result - NULL check, this should be added.
Yes some Windows tests are failing; however it seems they miss getting the BOOT
JDK or other components
Update header to remove classpath exception
-
Commit messages:
- Update header
Changes: https://git.openjdk.org/jdk/pull/11324/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11324=00
Issue: https://bugs.openjdk.org/browse/JDK-8297507
Stats: 3 lines in 1 file changed: 0
On Wed, 23 Nov 2022 08:18:32 GMT, Matthias Baesken wrote:
> Seems there is a remaining GetPrimitiveArrayCritical in imageioJPEG that
> misses a result - NULL check, this should be added.
Hello , I did a few more grepping and source reading and while 98 or 99 percent
of the
On Thu, 17 Nov 2022 22:51:00 GMT, Laurent Bourgès wrote:
> Initial PR
This pull request has now been integrated.
Changeset: 5b3d86f2
Author:Laurent Bourgès
URL:
https://git.openjdk.org/jdk/commit/5b3d86f2296ec011f70cebe80a221b8a6f926912
Stats: 4286 lines in 38 files changed:
On Wed, 23 Nov 2022 01:56:30 GMT, Sergey Bylokhov wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed class header comment
>
> test/jdk/sun/java2d/marlin/HugePolygonClipTest.java line 68:
>
>> 66:
On Tue, 22 Nov 2022 22:04:57 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>>
On Wed, 23 Nov 2022 08:18:32 GMT, Matthias Baesken wrote:
> Seems there is a remaining GetPrimitiveArrayCritical in imageioJPEG that
> misses a result - NULL check, this should be added.
Thanks for the fix. Change looks good to me.
I am running ImageIO tests with fix and will approve soon.
On Wed, 23 Nov 2022 09:29:16 GMT, Jayathirth D V wrote:
> Did we actually hit null pointer issue in some specific condition using
> ImageIO or this bug got identified because of some static analysis?
I just grepped the codebase for GetPrimitiveArrayCritical usages and while
doing so saw this.
On Wed, 23 Nov 2022 08:57:23 GMT, Srinivas Mandalika
wrote:
> 8297481: Create a regression test for JDK-4424517
Marked as reviewed by kirak...@github.com (no known OpenJDK username).
-
PR: https://git.openjdk.org/jdk/pull/11313
res the KeyLocation mapping to
these are accurate.
This review is for migrating tests from a closed test suite to open.
Mach5 Test Results (60 repetitions across 3 platforms)
https://mach5.us.oracle.com/mdash/jobs/jpg-closedjdk_mainline-20221123-0508-38875640
-
PR: https://git.openjdk.org/jdk/p
On Wed, 23 Nov 2022 08:18:32 GMT, Matthias Baesken wrote:
> Seems there is a remaining GetPrimitiveArrayCritical in imageioJPEG that
> misses a result - NULL check, this should be added.
Did we actually hit null pointer issue in some specific condition using ImageIO
or this bug got identified
8297481: Create a regression test for JDK-4424517
-
Commit messages:
- 8297481: Create a regression test for JDK-4424517
Changes: https://git.openjdk.org/jdk/pull/11313/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11313=00
Issue:
On Thu, 15 Sep 2022 16:51:27 GMT, Olga Mikhaltsova
wrote:
> This is a fix for LineBreakMeasurer. It takes into account the
> TextAttribute.TRACKING value (not eq 0) while calculating the line breaks.
>
> Tested on Linux x64, Windows x64, macOS x64 with the reproducer
> (LineBreakSample.java)
On Thu, 15 Sep 2022 16:51:27 GMT, Olga Mikhaltsova
wrote:
> This is a fix for LineBreakMeasurer. It takes into account the
> TextAttribute.TRACKING value (not eq 0) while calculating the line breaks.
>
> Tested on Linux x64, Windows x64, macOS x64 with the reproducer
> (LineBreakSample.java)
Seems there is a remaining GetPrimitiveArrayCritical in imageioJPEG that misses
a result - NULL check, this should be added.
-
Commit messages:
- JDK-8297480
Changes: https://git.openjdk.org/jdk/pull/11312/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11312=00
Issue:
59 matches
Mail list logo
