On Fri, 2 Dec 2022 19:53:14 GMT, Alisen Chung wrote:
>> Test was run on mac, windows, linux 50 times and passed after change
>> Before fix, test fails about once every 50 runs on linux and windows
>> platforms
>
> Alisen Chung has updated the pull request incrementally with one additional
> com
On Fri, 2 Dec 2022 23:07:45 GMT, Phil Race wrote:
> The compilation of a number of tests that use regtesthelpers/Util.java are
> getting a warning about
> the deprecation-for-removal of the SecurityManager.
> This suppresses that warning.
Marked as reviewed by kizune (Reviewer).
-
On Fri, 2 Dec 2022 03:43:57 GMT, Sergey Bylokhov wrote:
>> The above test was failing due to incorrect pixel color and wrong window
>> bounds on Mac-ARM, Windows and Linux platforms.
>>
>> The following changes have been made:
>> - Correct window bounds are obtained using the current ScreenDevi
On Thu, 1 Dec 2022 19:38:44 GMT, Nikita Gubarkov wrote:
>> It was implemented in JetBrains Runtime a year ago and was ported &
>> refactored for this PR
>> It includes:
>> - Bitmap glyph loading via Freetype
>> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or
>> bilin
On Fri, 2 Dec 2022 19:27:30 GMT, Phil Race wrote:
>> Nikita Gubarkov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix pointer to jlong conversion on x86
>
> I imported the changes and submitted to our CI test system. There seem to be
On Fri, 2 Dec 2022 19:27:30 GMT, Phil Race wrote:
>> Nikita Gubarkov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix pointer to jlong conversion on x86
>
> I imported the changes and submitted to our CI test system. There seem to be
On Fri, 2 Dec 2022 23:52:55 GMT, Alexander Zuev wrote:
>> Set the text caret to be visible but not blinking on the non-editable text
>> area.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Handling the case when blink r
On Fri, 2 Dec 2022 04:16:21 GMT, Sergey Bylokhov wrote:
> I wonder how other native applications handle this. Can the non-blinking
> cursor be considered a hang of the application?
Different application handle it differently but most os them do not claim to
pass the VPAT certification. I do no
> Set the text caret to be visible but not blinking on the non-editable text
> area.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Handling the case when blink rate is set while component is unedited
Test HidingSelectionTest.ja
On Thu, 1 Dec 2022 19:38:44 GMT, Nikita Gubarkov wrote:
>> It was implemented in JetBrains Runtime a year ago and was ported &
>> refactored for this PR
>> It includes:
>> - Bitmap glyph loading via Freetype
>> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or
>> bilin
The compilation of a number of tests that use regtesthelpers/Util.java are
getting a warning about
the deprecation-for-removal of the SecurityManager.
This suppresses that warning.
-
Commit messages:
- 8273357
Changes: https://git.openjdk.org/jdk/pull/11492/files
Webrev: https://w
On Fri, 2 Dec 2022 17:12:55 GMT, Andy Goryachev wrote:
>> This turned out to be much more complicated than anticipated. I am going to
>> close this PR (and bug), and instead I have split up this work in five
>> different bugs:
>>
>> [JDK-8298047](https://bugs.openjdk.org/browse/JDK-8298047) is
On Fri, 2 Dec 2022 16:38:54 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
On Fri, 2 Dec 2022 03:43:57 GMT, Sergey Bylokhov wrote:
>> The above test was failing due to incorrect pixel color and wrong window
>> bounds on Mac-ARM, Windows and Linux platforms.
>>
>> The following changes have been made:
>> - Correct window bounds are obtained using the screen device bein
> Test was run on mac, windows, linux 50 times and passed after change
> Before fix, test fails about once every 50 runs on linux and windows platforms
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fixed imports, changed robot autod
On Thu, 1 Dec 2022 19:38:44 GMT, Nikita Gubarkov wrote:
>> It was implemented in JetBrains Runtime a year ago and was ported &
>> refactored for this PR
>> It includes:
>> - Bitmap glyph loading via Freetype
>> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or
>> bilin
On Fri, 2 Dec 2022 03:47:16 GMT, Sergey Bylokhov wrote:
>> The above test was failing due to incorrect pixel color and wrong window
>> bounds on Mac-ARM, Windows and Linux platforms.
>>
>> The following changes have been made:
>> - Correct window bounds are obtained using the screen device bein
On Fri, 2 Dec 2022 03:37:47 GMT, Sergey Bylokhov wrote:
>> The above test was failing due to incorrect pixel color and wrong window
>> bounds on Mac-ARM, Windows and Linux platforms.
>>
>> The following changes have been made:
>> - Correct window bounds are obtained using the screen device bein
On Fri, 2 Dec 2022 17:10:17 GMT, Magnus Ihse Bursie wrote:
> and instead I have split up this work in five different bugs
would you consider also adding a unit test to check whether the localized
resources also contain leading/trailing whitespace, and possibly special
characters (like {, }, ,
[JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an
attempt to remove all trailing whitespace from properties files, and enable a
jcheck verification that they did not come back, similar to other source code.
It turned out that this was not so simple, however, since trai
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
According to [the
specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
trailing whitespaces in the values of properties files are (somewhat
surprisingly) actually significant.
We have multiple files in the JDK with trailing
On Fri, 2 Dec 2022 16:38:54 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
On Fri, 2 Dec 2022 08:41:18 GMT, Ichiroh Takiguchi
wrote:
> I changed GCC toolchain from GCC6 to GCC8 on SLES12SP5 Linux s390x.
> I could see following errors:
>
> src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c: In
> function 'allocateRasterArray':
> src/java.desktop/share/
On Thu, 1 Dec 2022 19:38:44 GMT, Nikita Gubarkov wrote:
>> It was implemented in JetBrains Runtime a year ago and was ported &
>> refactored for this PR
>> It includes:
>> - Bitmap glyph loading via Freetype
>> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or
>> bilin
On Fri, 2 Dec 2022 08:41:18 GMT, Ichiroh Takiguchi
wrote:
> I changed GCC toolchain from GCC6 to GCC8 on SLES12SP5 Linux s390x.
> I could see following errors:
>
> src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c: In
> function 'allocateRasterArray':
> src/java.desktop/share/
On Thu, 1 Dec 2022 19:36:16 GMT, Jonathan Gibbons wrote:
>> Please review a "somewhat automated" change to insert `@spec` tags into doc
>> comments, as appropriate, to leverage the recent new javadoc feature to
>> generate a new page listing the references to all external specifications
>> lis
On Thu, 1 Dec 2022 15:29:48 GMT, Prasanta Sadhukhan
wrote:
> Test seems to fail intermittently in ubuntu OCI VM although it passes locally
> and in other physical system.
> Although I am not able to reproduce it on VM, tried some robot safeguards
> used in other tests.
> Modified tests passed
I changed GCC toolchain from GCC6 to GCC8 on SLES12SP5 Linux s390x.
I could see following errors:
src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c: In function
'allocateRasterArray':
src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c:2944:73:
error: 'roff[3]' ma
30 matches
Mail list logo
