Integrated: 8298887: On the latest macOS+XCode the Robot API may report wrong colors

2022-12-21 Thread Sergey Bylokhov
On Mon, 19 Dec 2022 21:48:54 GMT, Sergey Bylokhov wrote: > The new macOS SDK provided by XCode 14.2 changed this macro: > `# define kCGBitmapByteOrder32Host kCGBitmapByteOrder32Little` > to this constant > `static const CGBitmapInfo kCGBitmapByteOrder32Host = > kCGBitmapByteOrder32Little;` > >

Re: [jdk20] RFR: 8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java

2022-12-21 Thread Jayathirth D V
On Thu, 22 Dec 2022 05:39:54 GMT, Ajit Ghaisas wrote: > - Regression test test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java was > added as part of [JDK-8291266](https://bugs.openjdk.org/browse/JDK-8291266). > We had to revert [JDK-8291266](https://bugs.openjdk.org/browse/JDK-8291266) >

[jdk20] RFR: 8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java

2022-12-21 Thread Ajit Ghaisas
- Regression test test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java was added as part of [JDK-8291266](https://bugs.openjdk.org/browse/JDK-8291266). We had to revert [JDK-8291266](https://bugs.openjdk.org/browse/JDK-8291266) while fixing

Re: RFR: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null' [v4]

2022-12-21 Thread Tejesh R
> Observation found when JFileChooser is instantiated in WindowsLookAndFeel > which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find > the exact root cause so predicting it to be an issue with icons not loaded > where resolutionVariants map is empty in _public Image >

Re: RFR: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null' [v3]

2022-12-21 Thread Tejesh R
On Wed, 21 Dec 2022 17:22:35 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line > 1408:

[jdk20] Integrated: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-21 Thread Alexander Zuev
On Tue, 20 Dec 2022 23:38:31 GMT, Alexander Zuev wrote: > Slightly updated original fix - got rid of the extra flasher reset. Tests are > fixed to be more stable and pass on the corresponding platforms. This pull request has now been integrated. Changeset: fef70d78 Author:Alexander Zuev

Re: RFR: JDK-8294680: Refactor scaled border rendering [v3]

2022-12-21 Thread Harshitha Onkar
> In this fix, the common code required for scaled border rendering is unified > and added to SwingUtilities3. This is achieved by adding a functional > interface to SwingUtilities3 and calling the the respective paintBorder > function passed as parameter to method. > > Following are the

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11

2022-12-21 Thread Harshitha Onkar
On Wed, 21 Dec 2022 20:03:38 GMT, Alexey Ivanov wrote: >> @jaikiran Thank you for the details. I'll check if the duration of run >> differed drastically. I thought all the client tests run in non-concurrent >> mode by default or does this differ for headful and headless test? > > *Headful*

Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-21 Thread Alexander Zuev
On Wed, 21 Dec 2022 17:00:47 GMT, Alexey Ivanov wrote: > When the caret doesn't need to blink because the component is read-only, we > call the public method `setBlinkRate` to set the rate to 0. At the same time, > `getBlinkRate` continues to return non-zero value. This is confusing. > > I

Re: RFR: 8200192: Verify exported symbols in java.desktop

2022-12-21 Thread Alexey Ivanov
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel JeliƄski wrote: > Did not verify the other issues reported in the linked JBS ticket. Then I suggest filing a new bug to track additional issues raised in [JDK-8200192](https://bugs.openjdk.org/browse/JDK-8200192) and editing the description and the

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11

2022-12-21 Thread Alexey Ivanov
On Tue, 20 Dec 2022 23:25:30 GMT, Harshitha Onkar wrote: > ViewportOverlapping was failing intermittently on Windows (Win10 & 11). Added > robot.setAutoWaitForIdle() to ViewportOverlapping and its base class > (OverlappingTestBase) to stabilize the test. > > Additionally added awt & swings

Integrated: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails

2022-12-21 Thread Damon Nguyen
On Mon, 21 Nov 2022 20:56:40 GMT, Damon Nguyen wrote: > Test ran on all OS 100 times and passed. Test previously failed on macOS but > no longer reproducible. Added screen capture on moment of failure to have > more evidence of failures in the future (previously a runtime exception was >

Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus [v2]

2022-12-21 Thread Alexander Zuev
On Wed, 21 Dec 2022 19:50:33 GMT, Phil Race wrote: > "Full test run" means what ? Remember that even if you run every test > everywhere, we can't be 100% certain of no regressions since we'll never have > tests for every scenario. > > And which manual tests did you run ? Are you SURE no

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11

2022-12-21 Thread Alexey Ivanov
On Wed, 21 Dec 2022 17:25:20 GMT, Harshitha Onkar wrote: >> test/jdk/TEST.ROOT line 36: >> >>> 34: com/sun/net/httpserver/simpleserver \ >>> 35: java/awt \ >>> 36: javax/swing >> >> Hello Harshitha, I don't have any knowledge of the client area, but I see >> that there are a large number of

Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus [v2]

2022-12-21 Thread Phil Race
On Wed, 21 Dec 2022 19:40:09 GMT, Alexander Zuev wrote: >> Slightly updated original fix - got rid of the extra flasher reset. Tests >> are fixed to be more stable and pass on the corresponding platforms. > > Alexander Zuev has updated the pull request incrementally with one additional >

Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus [v2]

2022-12-21 Thread Alexey Ivanov
On Wed, 21 Dec 2022 19:40:09 GMT, Alexander Zuev wrote: >> Slightly updated original fix - got rid of the extra flasher reset. Tests >> are fixed to be more stable and pass on the corresponding platforms. > > Alexander Zuev has updated the pull request incrementally with one additional >

Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus [v2]

2022-12-21 Thread Alexander Zuev
On Wed, 21 Dec 2022 16:40:05 GMT, Alexey Ivanov wrote: > Less indentation and the same behaviour. Agreed. Fixed. - PR: https://git.openjdk.org/jdk20/pull/68

Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus [v2]

2022-12-21 Thread Alexander Zuev
> Slightly updated original fix - got rid of the extra flasher reset. Tests are > fixed to be more stable and pass on the corresponding platforms. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Simplifying the two nested if

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11

2022-12-21 Thread Harshitha Onkar
On Wed, 21 Dec 2022 01:12:12 GMT, Jaikiran Pai wrote: >> ViewportOverlapping was failing intermittently on Windows (Win10 & 11). >> Added robot.setAutoWaitForIdle() to ViewportOverlapping and its base class >> (OverlappingTestBase) to stabilize the test. >> >> Additionally added awt & swings

Re: RFR: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null' [v3]

2022-12-21 Thread Alexey Ivanov
On Tue, 20 Dec 2022 08:18:11 GMT, Tejesh R wrote: >> Observation found when JFileChooser is instantiated in WindowsLookAndFeel >> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not >> find the exact root cause so predicting it to be an issue with icons not >> loaded

Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-21 Thread Alexey Ivanov
On Tue, 20 Dec 2022 23:38:31 GMT, Alexander Zuev wrote: > Slightly updated original fix - got rid of the extra flasher reset. Tests are > fixed to be more stable and pass on the corresponding platforms. When the caret doesn't need to blink because the component is read-only, we call the

Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-21 Thread Alexander Zvegintsev
On Tue, 20 Dec 2022 23:38:31 GMT, Alexander Zuev wrote: > Slightly updated original fix - got rid of the extra flasher reset. Tests are > fixed to be more stable and pass on the corresponding platforms. Marked as reviewed by azvegint (Reviewer). - PR:

Re: [jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus

2022-12-21 Thread Alexey Ivanov
On Tue, 20 Dec 2022 23:38:31 GMT, Alexander Zuev wrote: > Slightly updated original fix - got rid of the extra flasher reset. Tests are > fixed to be more stable and pass on the corresponding platforms. Marked as reviewed by aivanov (Reviewer).

Re: RFR: 8298887: On the latest macOS+XCode the Robot API may report wrong colors

2022-12-21 Thread Alexander Zvegintsev
On Mon, 19 Dec 2022 21:48:54 GMT, Sergey Bylokhov wrote: > The new macOS SDK provided by XCode 14.2 changed this macro: > `# define kCGBitmapByteOrder32Host kCGBitmapByteOrder32Little` > to this constant > `static const CGBitmapInfo kCGBitmapByteOrder32Host = > kCGBitmapByteOrder32Little;` > >

Re: RFR: 8299199: Avoid redundant split calls in FontConfiguration.initReorderMap implementations

2022-12-21 Thread Alexey Ivanov
On Wed, 21 Dec 2022 11:56:52 GMT, Andrey Turbanov wrote: >> src/java.desktop/share/classes/sun/awt/FontConfiguration.java line 856: >> >>> 854: >>> 855: protected String[] split(String sequence) { >>> 856: Vector v = splitSequence(sequence); >> >> Can `splitSequence` be replaced

Re: RFR: 8299199: Avoid redundant split calls in FontConfiguration.initReorderMap implementations

2022-12-21 Thread Alexey Ivanov
On Wed, 21 Dec 2022 11:03:08 GMT, Andrey Turbanov wrote: > `FontConfiguration.split` uses legacy synchronized `Vector` class. But > actually there is no need to use it, because input arguments are known at > compile time. Instead of split usages we can just create String[] array with > filled

Re: RFR: 8299199: Avoid redundant split calls in FontConfiguration.initReorderMap implementations

2022-12-21 Thread Andrey Turbanov
On Wed, 21 Dec 2022 11:35:47 GMT, Alexey Ivanov wrote: >> `FontConfiguration.split` uses legacy synchronized `Vector` class. But >> actually there is no need to use it, because input arguments are known at >> compile time. Instead of split usages we can just create String[] array with >>

Re: RFR: 8299199: Avoid redundant split calls in FontConfiguration.initReorderMap implementations

2022-12-21 Thread Alexey Ivanov
On Wed, 21 Dec 2022 11:03:08 GMT, Andrey Turbanov wrote: > `FontConfiguration.split` uses legacy synchronized `Vector` class. But > actually there is no need to use it, because input arguments are known at > compile time. Instead of split usages we can just create String[] array with > filled

Re: RFR: 8218474: JComboBox display issue with GTKLookAndFeel

2022-12-21 Thread Andrey Turbanov
On Wed, 7 Dec 2022 10:25:31 GMT, Abhishek Kumar wrote: > In case of GTK LAF, the current selected element was not visible due to > arrowbutton is rendered in entire display area of Combobox. > > The proposed fix is to set the `squareButton `property of combobox to `false > `so that the

Re: RFR: JDK-8294680: Refactor scaled border rendering [v2]

2022-12-21 Thread Andrey Turbanov
On Mon, 12 Dec 2022 22:43:08 GMT, Harshitha Onkar wrote: >> In this fix, the common code required for scaled border rendering is unified >> and added to SwingUtilities3. This is achieved by adding a functional >> interface to SwingUtilities3 and calling the the respective paintBorder >>

Re: RFR: 6603771: Nimbus L: Ctrl+F7 keybinding for Jinternal Frame throws a NPE. [v4]

2022-12-21 Thread Andrey Turbanov
On Wed, 14 Dec 2022 10:58:47 GMT, Prasanta Sadhukhan wrote: >> In Swingset2 JInternalFrame demo, focusing on any internalframes and >> pressing Ctrl+F7 and then any of up/down/left/arrow key to move the internal >> frames results in NPE in NimbusL >> It is because

RFR: 8299199: Avoid redundant split calls in FontConfiguration.initReorderMap implementations

2022-12-21 Thread Andrey Turbanov
`FontConfiguration.split` uses legacy synchronized `Vector` class. But actually there is no need to use it, because input arguments are known at compile time. Instead of split usages we can just create String[] array with filled values directly. - Commit messages: - [PATCH] Avoid

Integrated: 8296275: Write a test to verify setAccelerator method of JMenuItem

2022-12-21 Thread Naveen Narayanan
On Tue, 8 Nov 2022 08:57:54 GMT, Naveen Narayanan wrote: > This testcase will > 1) Verify setAccelerator method of JMenuitem. > 2) Check that the selection of a menu item in the menu bar will generate > action by a key combination of META+M. > > Testing: > Tested using Mach5(20 times per

Integrated: JDK-8299025: BMPImageReader.java readColorPalette could use staggeredReadByteStream

2022-12-21 Thread Matthias Baesken
On Mon, 19 Dec 2022 13:49:18 GMT, Matthias Baesken wrote: > Looks like the coding in > jdk/src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java > readColorPalette is rather close to what staggeredReadByteStream does, so we > could instead use staggeredReadByteStream