Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v5]

2023-01-08 Thread David Holmes
On Sat, 7 Jan 2023 21:08:07 GMT, Archie L. Cobbs wrote: >> This PR adds a new lint warning category `this-escape`. >> >> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to >> allow the JDK to continue to compile with `-Xlint:all`. >> >> A 'this' escape warning is gener

Re: RFR: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines [v2]

2023-01-08 Thread Manukumar V S
On Fri, 6 Jan 2023 07:21:12 GMT, Manukumar V S wrote: >> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS >> machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as >> adding some stability improvements fixes the issue. It intermittently fails >> in

Withdrawn: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

2023-01-08 Thread Manukumar V S
On Tue, 11 Oct 2022 14:17:42 GMT, Manukumar V S wrote: > java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS > machines, especially in MacOSX 12 & 13 machines. It seems to be a testbug as > adding some stability improvements fixes the issue. It intermittently fails > in CI

Re: RFR: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

2023-01-08 Thread Manukumar V S
On Tue, 3 Jan 2023 16:45:52 GMT, Alexey Ivanov wrote: > I also suggest removing the second asterisk at line 43, so that jtreg tags > don't result javadoc warnings. > > If you also remove `throws Exception` clause from `openPopup`, the test will > become warning-free. Fixed the review comments

Integrated: 8218474: JComboBox display issue with GTKLookAndFeel

2023-01-08 Thread Abhishek Kumar
On Wed, 7 Dec 2022 10:25:31 GMT, Abhishek Kumar wrote: > In case of GTK LAF, the current selected element was not visible due to > arrowbutton is rendered in entire display area of Combobox. > > The proposed fix is to set the `squareButton `property of combobox to `false > `so that the arrowbu

Re: RFR: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null' [v4]

2023-01-08 Thread Tejesh R
On Sun, 8 Jan 2023 09:09:56 GMT, Sergey Bylokhov wrote: > > I have tested in headful system multiple time, never reproduced this > > issue.. Can timing affect in headless and not in headful..? > > It should not. Does it actually have any dependency on "headful" envirement? > The native

Re: RFR: 4934362: see also refers to self [v4]

2023-01-08 Thread Prasanta Sadhukhan
> Some methods and constants has a hyperreference to self in javadoc which is > rectified to reference proper methods Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Point to isEditable method - Changes: - all:

Integrated: 8299774: SYNTH_BUTTON_UI_KEY field is unused

2023-01-08 Thread SWinxy
On Sat, 7 Jan 2023 03:34:02 GMT, SWinxy wrote: > Added in JDK-8192888, and became unused in JDK-8213843. This pull request has now been integrated. Changeset: 7607c07e Author:SWinxy Committer: Julian Waters URL: https://git.openjdk.org/jdk/commit/7607c07e002cd86cf2a0f44df9933612550

Re: RFR: 8218474: JComboBox display issue with GTKLookAndFeel [v2]

2023-01-08 Thread Sergey Bylokhov
On Thu, 22 Dec 2022 10:35:32 GMT, Abhishek Kumar wrote: >> In case of GTK LAF, the current selected element was not visible due to >> arrowbutton is rendered in entire display area of Combobox. >> >> The proposed fix is to set the `squareButton `property of combobox to `false >> `so that the a

Re: RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard

2023-01-08 Thread Sergey Bylokhov
On Fri, 6 Jan 2023 22:07:33 GMT, Alisen Chung wrote: > Removed check for MapVirtualKeyEx return value causing some keys to become > undefined That check was added as part of the https://bugs.openjdk.org/browse/JDK-8139189, can we check that functionality is not broken by the current change?

Re: RFR: 8299774: SYNTH_BUTTON_UI_KEY field is unused

2023-01-08 Thread Sergey Bylokhov
On Sat, 7 Jan 2023 03:34:02 GMT, SWinxy wrote: > Added in JDK-8192888, and became unused in JDK-8213843. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11890

Re: RFR: 8299774: SYNTH_BUTTON_UI_KEY field is unused

2023-01-08 Thread Sergey Bylokhov
On Sat, 7 Jan 2023 03:34:02 GMT, SWinxy wrote: > Added in JDK-8192888, and became unused in JDK-8213843. The change looks fine - PR: https://git.openjdk.org/jdk/pull/11890

RFR: 8299774: SYNTH_BUTTON_UI_KEY field is unused

2023-01-08 Thread SWinxy
Added in JDK-8192888, and became unused in JDK-8213843. - Commit messages: - SYNTH_BUTTON_UI_KEY field is unused Changes: https://git.openjdk.org/jdk/pull/11890/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11890&range=00 Issue: https://bugs.openjdk.org/browse/JDK-829977

Re: OS/X GUI applications

2023-01-08 Thread Michael Hall
> On Jan 6, 2023, at 4:35 PM, Michael Hall wrote: > > I haven’t verified if this would further allow changing the java.awt.Desktop > about handler. I did check that custom AboutHandlers are possible for OS/X JavaFX applications. With… static { //java.awt.Toolkit.ge

Re: [PATCH] 7000965: Paste fails when X clipboard is in a certain state

2023-01-08 Thread Flaviu Tamas
Hi, following up here. Turns out this bug has already been reported: https://bugs.openjdk.org/browse/JDK-7000965 Would appreciate it if someone would sponsor this work, as described in https://openjdk.org/contribute/, section 4. On Mon, Jan 2, 2023 at 8:00 AM Flaviu Tamas wrote: > > Sometimes, t

Integrated: 8298921: Create a regression test for JDK-8139581

2023-01-08 Thread Srinivas Mandalika
On Fri, 16 Dec 2022 10:21:35 GMT, Srinivas Mandalika wrote: > Create a regression test for JDK-8139581 > > As described in JDK-8139581, when an AWT panel with AWT components, for > example "java.awt.Button", is removed from AWT frame and added again to the > same frame, then some AWT componen

Re: RFR: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null' [v4]

2023-01-08 Thread Sergey Bylokhov
On Tue, 3 Jan 2023 05:19:55 GMT, Tejesh R wrote: > I have tested in headful system multiple time, never reproduced this > issue.. Can timing affect in headless and not in headful..? It should not. Does it actually have any dependency on "headful" envirement? The native code we used doe