Re: RFR: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case

On Wed, 18 Jan 2023 06:37:30 GMT, Tejesh R wrote: > This is a diagnostic update related to > [JDK-8295804](https://bugs.openjdk.org/browse/JDK-8295804). The issue was not > reproducible and was showing up in particular machines (Where the machines > are down now). So adding a screen capture to

RFR: 8300409: Create an automated regression test for JComboBox titled border issues(JDK-8300269)

Create a automated regression test for JComboBox titled border issues([JDK-8300269](https://bugs.openjdk.org/browse/JDK-8300269)). This test passes in JDK-20-ea+16 and fails in JDK-20-ea+16 and above. - Commit messages: - 8300409: Create an automated regression test for JComboBox t

Re: RFR: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case

On Wed, 18 Jan 2023 07:06:26 GMT, Abhishek Kumar wrote: > In [JDK-8295804](https://bugs.openjdk.org/browse/JDK-8295804), it is > mentioned that failure was observed in macOS 13 also. Did you try to > reproduce the issue in macOS 13? Not yet, since any particular host is not mentioned in JBS I

Re: RFR: 8298266: "java.home property not set" error in Graal when sun.awt.fontconfig java property is set on Windows [v2]

On Tue, 17 Jan 2023 20:51:36 GMT, Phil Race wrote: > Maybe core libs could add such a test. It is tested by conformance tests but a test could be added to the OpenJDK jtreg tests if needed. - PR: https://git.openjdk.org/jdk/pull/11559

RFR: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case

This is a diagnostic update related to [JDK-8295804](https://bugs.openjdk.org/browse/JDK-8295804). The issue was not reproducible and was showing up in particular machines (Where the machines are down now). So adding a screen capture to `BufferedImage` in case of failure so that it will help in

Withdrawn: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null'

On Fri, 11 Nov 2022 08:18:19 GMT, Tejesh R wrote: > Observation found when JFileChooser is instantiated in WindowsLookAndFeel > which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find > the exact root cause so predicting it to be an issue with icons not loaded > where res

Re: RFR: 8300169: Build failure with clang-15

On Tue, 17 Jan 2023 18:12:44 GMT, Phil Race wrote: > client changes are OK by me. Thanks @prrace . - PR: https://git.openjdk.org/jdk/pull/12005

Re: RFR: 8300169: Build failure with clang-15

v. 2023 ? 17:55, Alan Bateman a ?crit : > > -- next part -- An HTML attachment was scrubbed... > URL: > <https://mail.openjdk.org/pipermail/build-dev/attachments/20230117/4dc50b9b/attachment.htm> - PR: https://git.openjdk.org/jdk/pull/12005

Integrated: JDK-8300279: Use generalized see and link tags in core libs in client libs

On Tue, 17 Jan 2023 20:06:01 GMT, Joe Darcy wrote: > Use new javadoc capabilities courtesy JDK-8200337 to use more readable in > javadoc source anchors AWT's Shape interface. Analogous change is out for > review in core libs, JDK-8300133. This pull request has now been integrated. Changeset:

Re: RFR: 8297191: [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS leads to not print

On Thu, 29 Dec 2022 09:36:32 GMT, Tibor Malanik wrote: > The problem is noticeable when setPageable on java.awt.print.PrinterJob is > used So why is the Test.java in the bugreport not using it ? And yet claiming it shows the problem > And can we have a test with this fix, even if it is manual,

Re: RFR: 8282217: Key events (key char and key code) changed for Swiss keyboard

On Fri, 6 Jan 2023 22:07:33 GMT, Alisen Chung wrote: > Removed check for MapVirtualKeyEx return value causing some keys to become > undefined My (US QWERTY) keyboard doesn't have a key between the Z and L shift keys, so I used the on screen keyboard in German. I typed the OEM 102 key and C x2

Re: RFR: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null' [v4]

On Thu, 22 Dec 2022 05:13:34 GMT, Tejesh R wrote: >> Observation found when JFileChooser is instantiated in WindowsLookAndFeel >> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not >> find the exact root cause so predicting it to be an issue with icons not >> loaded where

Re: RFR: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null'

On Mon, 16 Jan 2023 14:19:52 GMT, Alexey Ivanov wrote: > This is somewhat a continuation of #11104 where the issue was discussed and > where I found [the root > cause](https://github.com/openjdk/jdk/pull/11104#issuecomment-1382435784). > > **Root Cause** > > The icon extraction code compares

Re: RFR: JDK-8300279: Use generalized see and link tags in core libs in client libs

On Tue, 17 Jan 2023 20:06:01 GMT, Joe Darcy wrote: > Use new javadoc capabilities courtesy JDK-8200337 to use more readable in > javadoc source anchors AWT's Shape interface. Analogous change is out for > review in core libs, JDK-8300133. Marked as reviewed by prr (Reviewer). - P

Re: RFR: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null' [v4]

On Thu, 22 Dec 2022 05:13:34 GMT, Tejesh R wrote: >> Observation found when JFileChooser is instantiated in WindowsLookAndFeel >> which invokes getSystemIcon() from WindowsFileChooserUI class. Could not >> find the exact root cause so predicting it to be an issue with icons not >> loaded where

GraphicsDevice#getAvailableAcceleratedMemory

Hi all, getAvailableAcceleratedMemory 's implementation (and lack thereof) is in conflict with the documentation, making it quite problematic. Windows is the only OS that

Re: RFR: JDK-8300279: Use generalized see and link tags in core libs in client libs

On Tue, 17 Jan 2023 20:06:01 GMT, Joe Darcy wrote: > Use new javadoc capabilities courtesy JDK-8200337 to use more readable in > javadoc source anchors AWT's Shape interface. Analogous change is out for > review in core libs, JDK-8300133. Marked as reviewed by aivanov (Reviewer).

Re: RFR: 8298266: "java.home property not set" error in Graal when sun.awt.fontconfig java property is set on Windows [v2]

On Fri, 6 Jan 2023 22:54:30 GMT, Sergey Bylokhov wrote: > But I assume we should have a test somewhere that validates that this option > is not null = "is not optional"? Maybe core libs could add such a test. The link doesn't work for me but I expect I'd need to look at each of those cases

Re: RFR: 8280359: Try to remove duplicate code for coordinate calculation

On Mon, 12 Dec 2022 01:49:23 GMT, Sergey Bylokhov wrote: > The code from `AccessibilityGraphicsEnvironment` is moved/merged back to the > `SunGraphicsEnvironment` from where it was initially > [copied](https://github.com/openjdk/jdk18/pull/72#issuecomment-1001050200). > The required API is exp

Re: RFR: 8299333: Unify exceptions used by all variants of ICC_Profile.getInstance(null)

On Fri, 23 Dec 2022 23:32:45 GMT, Sergey Bylokhov wrote: > I tried to clean up the documentation in the `java.awt.color` package and > specify how the `null` parameters are handled here and there. But it looks > like the `ICC_profile` class is too specific so I would like to discuss it > separ

RFR: JDK-8300279: Use generalized see and link tags in core libs in client libs

Use new javadoc capabilities courtesy JDK-8200337 to use more readable in javadoc source anchors AWT's Shape interface. Analogous change is out for review in core libs, JDK-8300133. - Commit messages: - JDK-8300279: Use generalized see and link tags in core libs in client libs Cha

Re: RFR: 8286581: Make Java process DPI Aware if sun.java2d.dpiaware property is set [v2]

On Tue, 17 Jan 2023 19:43:40 GMT, Phil Race wrote: > Can you explain why you think this change is needed if its already set ? Initially, I proposed to remove the property and code associated with it because its value isn't respected as the DPI Awareness is set in the manifest. You [asked](htt

Re: RFR: 8286581: Make Java process DPI Aware if sun.java2d.dpiaware property is set [v2]

On Tue, 17 Jan 2023 17:01:48 GMT, Rajat Mahajan wrote: >> I tested by removing dpi-awareness settings from the manifest file, and then >> running my app with -Dsun.java2d.dpiaware=false. This showed java.exe as >> "Unaware" in task-manager, and with it set to true I saw "Per-Monitor (v2)" >> d

Re: RFR: 8299772: The ColorModel.getRGBdefault() method is not thread-safe

On Sun, 8 Jan 2023 01:09:30 GMT, Sergey Bylokhov wrote: > The getRGBdefault() was made thread safe via holder implemented as a local > interface. Marked as reviewed by prr (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11895

Re: RFR: 8300117: Replace use of JNI_COMMIT mode with mode 0

On Tue, 17 Jan 2023 07:43:41 GMT, Daniel Jeliński wrote: > Please review this patch that fixes memory leaks in native code. > > The call to `ReleaseXXArrayElements` with `JNI_COMMIT` parameter does not > release the native buffer allocated by the previous `GetXXArrayElements` > call. The buffe

Re: RFR: 8300169: Build failure with clang-15

On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > >1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning >2) src/hotspot/share/runtime/notificationThre

Re: RFR: 8300169: Build failure with clang-15

On Tue, 17 Jan 2023 13:35:25 GMT, Kevin Rushforth wrote: >>> Normally, such changes in third-party libraries need to be done upstream, >>> and not locally. @prrace can confirm. >> >> Thanks @kevinrushforth for your review. >> >> Yes, it had been fixed in the upstream and I just follow it. >> P

Re: RFR: 8286581: Make Java process DPI Aware if sun.java2d.dpiaware property is set [v2]

On Tue, 17 Jan 2023 17:01:48 GMT, Rajat Mahajan wrote: >> I tested by removing dpi-awareness settings from the manifest file, and then >> running my app with -Dsun.java2d.dpiaware=false. This showed java.exe as >> "Unaware" in task-manager, and with it set to true I saw "Per-Monitor (v2)" >> d

Integrated: 8283203: Fix typo in SystemTray.getTrayIconSize javadoc

On Tue, 17 Jan 2023 01:53:05 GMT, SWinxy wrote: > Please review this itty-bitty typo fix. This pull request has now been integrated. Changeset: 8c12ae86 Author:SWinxy Committer: Alexey Ivanov URL: https://git.openjdk.org/jdk/commit/8c12ae867350a866a6a110ea85d86404f1efb0fb Stats:

Re: RFR: 8299522: Incorrect size of Approve button in custom JFileChooser [v10]

On Tue, 17 Jan 2023 05:00:47 GMT, Tejesh R wrote: >> test/jdk/javax/swing/JFileChooser/CustomApproveButtonTest.java line 71: >> >>> 69: frame.setVisible(true); >>> 70: >>> 71: JButton customApproveButton = >>> fileChooser.getUI().getDefaultButton(fileChooser); >> >> we

Re: RFR: 8283203: Fix typo in SystemTray.getTrayIconSize javadoc [v2]

On Tue, 17 Jan 2023 16:23:36 GMT, SWinxy wrote: >> Please review this itty-bitty typo fix. > > SWinxy has updated the pull request incrementally with one additional commit > since the last revision: > > Copyright & rm fluff @TheShermanTanker if you're good to sponsor. - PR: htt

Re: RFR: 8299522: Incorrect size of Approve button in custom JFileChooser [v12]

On Tue, 17 Jan 2023 05:37:38 GMT, Tejesh R wrote: >> FileChooser Open/Approve button size is shown incorrectly when no Approve >> button text is set in `CUSTOM_DIALOG` type. Reason being that no default >> Approve Button text is returned during Dialog Type Property change. Since >> `null` is r

Re: RFR: 8286581: Make Java process DPI Aware if sun.java2d.dpiaware property is set [v2]

> I tested by removing dpi-awareness settings from the manifest file, and then > running my app with -Dsun.java2d.dpiaware=false. This showed java.exe as > "Unaware" in task-manager, and with it set to true I saw "Per-Monitor (v2)" > dpi awareness for java.exe. Rajat Mahajan has updated the pul

Re: RFR: 8300169: Build failure with clang-15

no you have to revert the commit Le mar. 17 janv. 2023 à 17:55, Alan Bateman a écrit : > On Tue, 17 Jan 2023 13:33:06 GMT, Kevin Rushforth wrote: > > >> Hi all, > >> > >> Please review the fix for the build failure with clang-15. > >> > >> 1. -Wbitwise-instead-of-logical > >> > >>1) src/ho

Re: RFR: 8283203: Fix typo in SystemTray.getTrayIconSize javadoc [v2]

On Tue, 17 Jan 2023 16:23:36 GMT, SWinxy wrote: >> Please review this itty-bitty typo fix. > > SWinxy has updated the pull request incrementally with one additional commit > since the last revision: > > Copyright & rm fluff Marked as reviewed by aivanov (Reviewer). - PR: https:

Re: RFR: 8300169: Build failure with clang-15

On Tue, 17 Jan 2023 13:33:06 GMT, Kevin Rushforth wrote: >> Hi all, >> >> Please review the fix for the build failure with clang-15. >> >> 1. -Wbitwise-instead-of-logical >> >>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the >> warning >>2) src/hotspot/share/runtim

Re: RFR: 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu [v2]

On Tue, 17 Jan 2023 05:14:35 GMT, Prasanta Sadhukhan wrote: >> SWinxy has updated the pull request incrementally with one additional commit >> since the last revision: >> >> Single-class imports > > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java > line 35: > >>

Re: RFR: 8267582: BasicLookAndFeel should not call getComponentPopupMenu twice to get a popup menu [v2]

> Please review this small change to cache a component's popup menu in BLAF. SWinxy has updated the pull request incrementally with one additional commit since the last revision: Single-class imports - Changes: - all: https://git.openjdk.org/jdk/pull/12017/files - new: https:

Re: RFR: 8283203: Fix typo in SystemTray.getTrayIconSize javadoc [v2]

> Please review this itty-bitty typo fix. SWinxy has updated the pull request incrementally with one additional commit since the last revision: Copyright & rm fluff - Changes: - all: https://git.openjdk.org/jdk/pull/12020/files - new: https://git.openjdk.org/jdk/pull/12020/fi

Re: RFR: 8283203: Fix typo in SystemTray.getTrayIconSize javadoc

On Tue, 17 Jan 2023 01:53:05 GMT, SWinxy wrote: > Please review this itty-bitty typo fix. I submitted [JDK-8300280](https://bugs.openjdk.org/browse/JDK-8300280) regarding *“…the size **in pixels**…”*: https://github.com/openjdk/jdk/blob/a9b9831f2a88ed3b7701d402b167a096b94aeb98/src/java.desktop/

Re: RFR: 8283203: Fix typo in SystemTray.getTrayIconSize javadoc

On Tue, 17 Jan 2023 01:53:05 GMT, SWinxy wrote: > Please review this itty-bitty typo fix. Thank you for taking this one. It looks good to me except for additional words in the description. Could you also update the copyright year? src/java.desktop/share/classes/java/awt/SystemTray.java line 3

Re: RFR: 8300166: Unused array allocation in ProcessPath.doProcessPath

On Sat, 7 Jan 2023 19:29:17 GMT, Andrey Turbanov wrote: > I don't see this array in > `src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c` too. Seems > leftovers from refactoring? Looks good to me. Builds are fine, clientlibs tests pass successfully. - Marked as rev

Re: RFR: 8300169: Build failure with clang-15

On Sun, 15 Jan 2023 01:56:06 GMT, Jie Fu wrote: >> src/java.desktop/share/native/libharfbuzz/hb-meta.hh line 191: >> >>> 189: #define hb_int_max(T) hb_int_max::value >>> 190: >>> 191: #if defined(__GNUC__) && __GNUC__ < 5 && !defined(__clang__) >> >> Normally, such changes in third-party libra

Re: RFR: 8300169: Build failure with clang-15

On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > >1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning >2) src/hotspot/share/runtime/notificationThre

Re: RFR: 8300117: Replace use of JNI_COMMIT mode with mode 0

On Tue, 17 Jan 2023 07:43:41 GMT, Daniel Jeliński wrote: > Please review this patch that fixes memory leaks in native code. > > The call to `ReleaseXXArrayElements` with `JNI_COMMIT` parameter does not > release the native buffer allocated by the previous `GetXXArrayElements` > call. The buffe

Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

On Tue, 17 Jan 2023 11:44:32 GMT, Vladimir Sitnikov wrote: >> @RogerRiggs Thanks! > > @magicus , have you considered adding `.editorconfig` file (see > https://editorconfig.org/ ) so it configures developers' editors to trim the > whitespace? > > Of course, `.editorconfig` does not enforce th

Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

On Mon, 16 Jan 2023 18:52:24 GMT, Magnus Ihse Bursie wrote: >> The non-client parts look fine. > > @RogerRiggs Thanks! @magicus , have you considered adding `.editorconfig` file (see https://editorconfig.org/ ) so it configures developers' editors to trim the whitespace? Of course, `.editorco

Re: RFR: 8300169: Build failure with clang-15

On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote: > Hi all, > > Please review the fix for the build failure with clang-15. > > 1. -Wbitwise-instead-of-logical > >1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the > warning >2) src/hotspot/share/runtime/notificationThre

Integrated: 8300168: Typo in AccessibleJTableHeaderEntry javadoc

On Tue, 17 Jan 2023 08:01:03 GMT, Abhishek Kumar wrote: > There was a typo error in method description of `public > AccessibleJTableHeaderEntry(int c, JTableHeader p, JTable t)`. Replaced the > text `AccessiblJTableHeaaderEntry` with `AccessibleJTableHeaderEntry`. This pull request has now bee

Re: RFR: 8300168: Typo in AccessibleJTableHeaderEntry javadoc [v2]

On Tue, 17 Jan 2023 08:33:43 GMT, Abhishek Kumar wrote: >> There was a typo error in method description of `public >> AccessibleJTableHeaderEntry(int c, JTableHeader p, JTable t)`. Replaced the >> text `AccessiblJTableHeaaderEntry` with `AccessibleJTableHeaderEntry`. > > Abhishek Kumar has upda

Re: RFR: 8300168: Typo in AccessibleJTableHeaderEntry javadoc [v2]

On Tue, 17 Jan 2023 08:33:43 GMT, Abhishek Kumar wrote: >> There was a typo error in method description of `public >> AccessibleJTableHeaderEntry(int c, JTableHeader p, JTable t)`. Replaced the >> text `AccessiblJTableHeaaderEntry` with `AccessibleJTableHeaderEntry`. > > Abhishek Kumar has upda

Re: RFR: 8300168: Typo in AccessibleJTableHeaderEntry javadoc [v2]

> There was a typo error in method description of `public > AccessibleJTableHeaderEntry(int c, JTableHeader p, JTable t)`. Replaced the > text `AccessiblJTableHeaaderEntry` with `AccessibleJTableHeaderEntry`. Abhishek Kumar has updated the pull request incrementally with one additional commit s

Re: RFR: 8300168: Typo in AccessibleJTableHeaderEntry javadoc [v2]

On Tue, 17 Jan 2023 08:24:15 GMT, Prasanta Sadhukhan wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removed extra space > > src/java.desktop/share/classes/javax/swing/table/JTableHeader.java line 938: > >> 936

Re: RFR: 8300168: Typo in AccessibleJTableHeaderEntry javadoc

On Tue, 17 Jan 2023 08:01:03 GMT, Abhishek Kumar wrote: > There was a typo error in method description of `public > AccessibleJTableHeaderEntry(int c, JTableHeader p, JTable t)`. Replaced the > text `AccessiblJTableHeaaderEntry` with `AccessibleJTableHeaderEntry`. src/java.desktop/share/classe

Integrated: JDK-8300205: Swing test bug8078268 make latch timeout configurable

On Mon, 16 Jan 2023 15:09:27 GMT, Matthias Baesken wrote: > The test javax/swing/text/html/parser/Parser/8078268/bug8078268.java has a > latch timeout that is currently fix but should better be configurable to > better deal with slow test infrastructures. This pull request has now been integra

Re: RFR: JDK-8300205: Swing test bug8078268 make latch timeout configurable [v2]

> The test javax/swing/text/html/parser/Parser/8078268/bug8078268.java has a > latch timeout that is currently fix but should better be configurable to > better deal with slow test infrastructures. Matthias Baesken has updated the pull request incrementally with one additional commit since the

RFR: 8300117: Replace use of JNI_COMMIT mode with mode 0

Please review this patch that fixes memory leaks in native code. The call to `ReleaseXXArrayElements` with `JNI_COMMIT` parameter does not release the native buffer allocated by the previous `GetXXArrayElements` call. The buffer pointers were only stored in local variables and were lost on func

RFR: 8300168: Typo in AccessibleJTableHeaderEntry javadoc

There was a typo error in method description of `public AccessibleJTableHeaderEntry(int c, JTableHeader p, JTable t)`. Replaced the text `AccessiblJTableHeaaderEntry` with `AccessibleJTableHeaderEntry`. - Commit messages: - Typo error fix Changes: https://git.openjdk.org/jdk/pull/