On Fri, 20 Jan 2023 06:02:53 GMT, Sergey Bylokhov wrote:
> The "default destination" for the ColorConverOp is used when the user passes
> "null" as the DST parameter. In this case, the "ColorConverOp.filter" creates
> the default image and uses ComponentColorModel: 8 bits per color component
On Sat, 21 Jan 2023 02:03:57 GMT, Phil Race wrote:
> So there are 3 TCK tests for the behaviour of getInstance(InputStream) which
> expect the specified IOException or an IAE in the event the arg is null. It
> will fail if we throw NPE (ie these 3 tests fail on all platforms with your
>
API docs of `java.awt.image.renderable.ParameterBlock` and
`java.awt.font.LineBreakMeasurer` used deprecated constructors of
`java.lang.Short` and `java.lang.Float`.
Replacing by `valueOf` factory methods.
-
Commit messages:
- Update LineBreakMeasurer.java
- Update
On Fri, 20 Jan 2023 20:20:32 GMT, Sergey Bylokhov wrote:
>> I tried to clean up the documentation in the `java.awt.color` package and
>> specify how the `null` parameters are handled here and there. But it looks
>> like the `ICC_profile` class is too specific so I would like to discuss it
>>
On Fri, 20 Jan 2023 23:47:37 GMT, Dan Lutker wrote:
>> Disabling warnings for bundled Freetype
>
> Dan Lutker has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains one commit:
>
> 8300692: GCC 12 reports some compiler warnings in
> Disabling warnings for bundled Freetype
Dan Lutker has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase.
-
Changes:
- all:
> Disabling warnings for bundled Freetype
Dan Lutker has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains two additional commits since the
last revision:
> The fixed height causes the titled border insets to reserve a majority of the
> height available for the component. This fixed height is meant for the
> default AquaComboBox usage, so the old default height is more applicable when
> a border, such as TitledBorder, is set on an Aqua Editable
On Fri, 20 Jan 2023 06:41:46 GMT, Prasanta Sadhukhan
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add test
>
> test/jdk/javax/swing/JComboBox/JComboBoxWithTitledBorderTest.java line 168:
>
>> 166: try
On Thu, 19 Jan 2023 19:32:05 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with `null`: it was just created. Java
> guarantees that all elements of array are `null`s anyway.
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12101
On Fri, 20 Jan 2023 06:41:36 GMT, Prasanta Sadhukhan
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add test
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxUI.java line 460:
>
>> 458:
On Fri, 20 Jan 2023 20:16:09 GMT, Sergey Bylokhov wrote:
> Something like this?
Yes.
If you file the CSR I will review it.
But I also want to run a test job to see if there are any tests that need
adjusting or excluding.
-
PR: https://git.openjdk.org/jdk/pull/11784
On Fri, 23 Dec 2022 23:32:45 GMT, Sergey Bylokhov wrote:
> I tried to clean up the documentation in the `java.awt.color` package and
> specify how the `null` parameters are handled here and there. But it looks
> like the `ICC_profile` class is too specific so I would like to discuss it
>
> I tried to clean up the documentation in the `java.awt.color` package and
> specify how the `null` parameters are handled here and there. But it looks
> like the `ICC_profile` class is too specific so I would like to discuss it
> separately.
>
> The ICC_Profile has these methods:
> *
On Fri, 20 Jan 2023 06:02:53 GMT, Sergey Bylokhov wrote:
> The "default destination" for the ColorConverOp is used when the user passes
> "null" as the DST parameter. In this case, the "ColorConverOp.filter" creates
> the default image and uses ComponentColorModel: 8 bits per color component
On Wed, 7 Dec 2022 13:20:10 GMT, Alexander Scherbatiy
wrote:
> **Environment**:
> GraalVM 22.3.0 with jdk 19, Windows OS.
>
> **Description**:
> Create a native image of Swing application using GraalVM and run it with `
> -Dsun.awt.fontconfig=fontconfig.properties.src` java property.
>
On Thu, 19 Jan 2023 19:32:05 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with `null`: it was just created. Java
> guarantees that all elements of array are `null`s anyway.
Marked as reviewed by prr (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12101
On Fri, 20 Jan 2023 06:02:53 GMT, Sergey Bylokhov wrote:
> The "default destination" for the ColorConverOp is used when the user passes
> "null" as the DST parameter. In this case, the "ColorConverOp.filter" creates
> the default image and uses ComponentColorModel: 8 bits per color component
The "default destination" for the ColorConverOp is used when the user passes
"null" as the DST parameter. In this case, the "ColorConverOp.filter" creates
the default image and uses ComponentColorModel: 8 bits per color component and
optionally 8 bits for the alpha channel. For example for the
On Mon, 12 Dec 2022 01:49:23 GMT, Sergey Bylokhov wrote:
> The code from `AccessibilityGraphicsEnvironment` is moved/merged back to the
> `SunGraphicsEnvironment` from where it was initially
> [copied](https://github.com/openjdk/jdk18/pull/72#issuecomment-1001050200).
> The required API is
On Fri, 20 Jan 2023 09:41:37 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JFileChooser/JFileChooserSetLocationTest.java line 189:
>>
>>> 187: System.out.println("Test passed");
>>> 188: } else {
>>> 189: Dimension screenSize =
>>>
> Please review this patch that fixes and re-enables a few warnings in libawt
> compilation.
>
> Verified that debug and release builds finish successfully on Win, Mac and
> Linux. Also verified that client libs tests still pass.
Daniel Jeliński has updated the pull request with a new target
On Wed, 4 Jan 2023 12:44:39 GMT, Daniel Jeliński wrote:
> Please review this patch that fixes and re-enables a few warnings in libawt
> compilation.
>
> Verified that debug and release builds finish successfully on Win, Mac and
> Linux. Also verified that client libs tests still pass.
In
On Fri, 20 Jan 2023 08:09:38 GMT, Sergey Bylokhov wrote:
>> This is a diagnostic update related to
>> [JDK-8295804](https://bugs.openjdk.org/browse/JDK-8295804). The issue was
>> not reproducible and was showing up in particular machines (Where the
>> machines are down now). So adding a
On Thu, 19 Jan 2023 19:32:05 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with `null`: it was just created. Java
> guarantees that all elements of array are `null`s anyway.
looks fine
-
PR: https://git.openjdk.org/jdk/pull/12101
On Thu, 19 Jan 2023 19:32:05 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with `null`: it was just created. Java
> guarantees that all elements of array are `null`s anyway.
Marked as reviewed by swi...@github.com (no known OpenJDK username).
-
PR:
No need to fill elements of array with `null`: it was just created. Java
guarantees that all elements of array are `null`s anyway.
-
Commit messages:
- [PATCH] Avoid unnecessary array fill after creation
Changes: https://git.openjdk.org/jdk/pull/12101/files
Webrev:
On Wed, 18 Jan 2023 06:37:30 GMT, Tejesh R wrote:
> This is a diagnostic update related to
> [JDK-8295804](https://bugs.openjdk.org/browse/JDK-8295804). The issue was not
> reproducible and was showing up in particular machines (Where the machines
> are down now). So adding a screen capture
28 matches
Mail list logo
