Re: RFR: 8301342: Prefer ArrayList to LinkedList in LayoutComparator

2023-02-04 Thread Sergey Bylokhov
On Sat, 28 Jan 2023 14:54:38 GMT, Andrey Turbanov wrote: > There is only add/iterator calls on this list. No removes from the head or > something like this. Not sure why LinkedList was used, but ArrayList should > be preferred as more efficient and widely used (more chances for JIT) > collecti

Re: RFR: 6753661: JFileChooser font not reset after Look & Feel change [v2]

2023-02-04 Thread Sergey Bylokhov
On Fri, 3 Feb 2023 04:26:39 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/JFileChooser/JFileChooserFontReset.java line 58: >> >>> 56: SwingUtilities.updateComponentTreeUI(fc); >>> 57: System.out.println("Nimbus font " + fc.getFont()); >>> 58: SwingUt

Re: RFR: 8301820: C4819 warnings were reported on Windows

2023-02-04 Thread Yasumasa Suenaga
On Sat, 4 Feb 2023 09:42:57 GMT, Yasumasa Suenaga wrote: > C4819 warnings were reported when I tried to build JDK on Windows with VS2022. > This PR contains changes both HotSpot and client libraries. Let me know if > they should be separated. > > * HotSpot > * stubGenerator_x86_64_poly.cpp

Re: RFR: 8301820: C4819 warnings were reported on Windows

2023-02-04 Thread Mikael Vidstedt
On Sat, 4 Feb 2023 09:42:57 GMT, Yasumasa Suenaga wrote: > C4819 warnings were reported when I tried to build JDK on Windows with VS2022. > This PR contains changes both HotSpot and client libraries. Let me know if > they should be separated. > > * HotSpot > * stubGenerator_x86_64_poly.cpp

Re: RFR: 8301822: BasicLookAndFeel does not need to check for null after checking for type

2023-02-04 Thread Julian Waters
On Mon, 16 Jan 2023 20:30:08 GMT, SWinxy wrote: > BasicLookAndFeel checks an instanceof in its `AWTEventHelper` listener class, > but the result of that will always be non-null. The check should be removed. https://bugs.openjdk.org/browse/JDK-8301822 - PR: https://git.openjdk.org/

Re: RFR: 8301822: BasicLookAndFeel does not need to check for null after checking for type

2023-02-04 Thread Sergey Bylokhov
On Mon, 16 Jan 2023 20:30:08 GMT, SWinxy wrote: > BasicLookAndFeel checks an instanceof in its `AWTEventHelper` listener class, > but the result of that will always be non-null. The check should be removed. Looks fine. - PR: https://git.openjdk.org/jdk/pull/12019

RFR: 8301822: BasicLookAndFeel does not need to check for null after checking for type

2023-02-04 Thread SWinxy
BasicLookAndFeel checks an instanceof in its `AWTEventHelper` listener class, but the result of that will always be non-null. The check should be removed. - Commit messages: - BasicLookAndFeel does not need to check for null after checking for type Changes: https://git.openjdk.org/

Re: RFR: 8301443: Clean broken comments from Windows code [v2]

2023-02-04 Thread Alexey Ivanov
On Sat, 4 Feb 2023 13:36:54 GMT, Weijun Wang wrote: >> I did think about that too when I first saw it, but the command this is >> often run from is the Windows CMD, which does not accept `` to escape to the >> next line. MSYS bash does not have the required environment set up outside >> of con

Re: RFR: 8301443: Clean broken comments from Windows code [v2]

2023-02-04 Thread Weijun Wang
On Sat, 4 Feb 2023 07:42:37 GMT, Julian Waters wrote: >> src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 31: >> >>> 29: // This library can be built directly with the following command: >>> 30: // cl -I %OPENJDK%\src\java.security.jgss\share\native\libj2gss\ >>> sspi.cpp >>

RFR: 8301820: C4819 warnings were reported on Windows

2023-02-04 Thread Yasumasa Suenaga
C4819 warnings were reported when I tried to build JDK on Windows with VS2022. This PR contains changes both HotSpot and client libraries. Let me know if they should be separated. * HotSpot * stubGenerator_x86_64_poly.cpp * elfFile.hpp * libfontmanager * hb.hh * libfreetype * afbl