On Fri, 31 Mar 2023 09:11:20 GMT, Dmitry Cherepanov
wrote:
> Please review this PR which suggests to skip updateIconImages() for not yet
> visible windows. The displayChanged notification can be sent to a window that
> is in the process of initiailization and calling updateIconImages() may lea
On Fri, 21 Apr 2023 21:08:51 GMT, Sergey Bylokhov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment update
>
> test/jdk/java/awt/MenuItem/MenuSetLabelTest.java line 29:
>
>> 27: @summary Menu disp
> This PR is to open source MenuItem AWT tests.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Review comment update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13589/files
- new: https://git.openjdk.org/jd
On Tue, 25 Apr 2023 02:47:39 GMT, Phil Race wrote:
>> test/jdk/java/awt/ScrollPane/ScrollPaneWindowsTest/ScrollPaneWindowsTest.java
>> line 91:
>>
>>> 89: System.out.println("This test is for Windows 2000/2003/XP
>>> only.");
>>> 90: return;
>>> 91: }
>>
>> Aga
On Mon, 24 Apr 2023 18:57:45 GMT, Alexey Ivanov wrote:
>> Open source few AWT ScrollPane related tests.
>
> test/jdk/java/awt/ScrollPane/RemoveChild/ScrollPaneRemoveAdd.java line 84:
>
>> 82: pane.remove(0);
>> 83: pane.add(button);
>> 84: });
On Tue, 25 Apr 2023 05:21:26 GMT, Tejesh R wrote:
>> test/jdk/java/awt/ScrollPane/RemoveChild/ScrollPaneRemoveAdd.java line 94:
>>
>>> 92: robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
>>> 93:
>>> 94: Toolkit.getDefaultToolkit().sync();
>>
>> Shouldn't `sync` be rep
> This opensources few AWT Graphics & GridBagLayout tests
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
space fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13570/files
- new: https://git.openjdk.org/
On Mon, 24 Apr 2023 18:43:51 GMT, Sergey Bylokhov wrote:
>> As the test summary mentioned, it supposed to "Check getGraphics doesn't
>> throw NullPointerExcepton for invalid colors and font"...the closed test was
>> also like it...was applet based which is just converted to use
>> BufferedImag
On Mon, 24 Apr 2023 18:59:29 GMT, Alexey Ivanov wrote:
>> Open source few AWT ScrollPane related tests.
>
> test/jdk/java/awt/ScrollPane/RemoveChild/ScrollPaneRemoveAdd.java line 94:
>
>> 92: robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
>> 93:
>> 94: Toolkit.getDefa
> This opensources few AWT Graphics & GridBagLayout tests
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
GetGraphics fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13570/files
- new: https://git.openjd
On Mon, 24 Apr 2023 09:51:50 GMT, Prasanta Sadhukhan
wrote:
> This opensources few Swing event and AbstractAction tests
This pull request has now been integrated.
Changeset: 31a73b0d
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/commit/31a73b0d7088d10a5ffb5541d66806a92
On Mon, 24 Apr 2023 18:52:17 GMT, Phil Race wrote:
>>> I preferred asynchronous EDT would be better since its finally block. Is
>>> there any particular reason that we should use `invokeAndWait` than
>>> `invokeLater`?
>>
>> You want to **wait** until the frame is disposed of before exiting th
On Mon, 24 Apr 2023 19:22:47 GMT, Alexey Ivanov wrote:
>> Open source few AWT ScrollPane related tests.
>
> test/jdk/java/awt/ScrollPane/ScrollPaneWindowsTest/ScrollPaneWindowsTest.java
> line 91:
>
>> 89: System.out.println("This test is for Windows 2000/2003/XP
>> only.");
>> 90:
On Mon, 24 Apr 2023 17:39:20 GMT, Phil Race wrote:
> Open source a few more AWT Choice tests
This pull request has now been integrated.
Changeset: f39641cc
Author:Phil Race
URL:
https://git.openjdk.org/jdk/commit/f39641ccbd670853b3c021dd4e490151cbc77ed6
Stats: 535 lines in 4 fil
On Mon, 24 Apr 2023 17:25:31 GMT, Phil Race wrote:
> Open sourcing several AWT Choice regression tests
This pull request has now been integrated.
Changeset: b5362dad
Author:Phil Race
URL:
https://git.openjdk.org/jdk/commit/b5362dadc59570d1f7fd7899be5ec11187168a16
Stats: 1048 lin
On Mon, 24 Apr 2023 19:20:54 GMT, Phil Race wrote:
> There were missing platforms in a couple of problem list entries.
> I verified the intended platforms are still needed and the other platforms
> pass.
Marked as reviewed by iris (Reviewer).
test/jdk/ProblemList.txt line 444:
> 442: java/awt
On Mon, 24 Apr 2023 09:51:50 GMT, Prasanta Sadhukhan
wrote:
> This opensources few Swing event and AbstractAction tests
Marked as reviewed by prr (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13608#pullrequestreview-1398862928
There were missing platforms in a couple of problem list entries.
I verified the intended platforms are still needed and the other platforms pass.
-
Commit messages:
- 8306765
Changes: https://git.openjdk.org/jdk/pull/13626/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=136
On Mon, 24 Apr 2023 16:40:53 GMT, Tejesh R wrote:
>> This open source AWT Mouse Info related tests.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Looks fine, please confirm that mach5 is gree
On Mon, 24 Apr 2023 19:25:59 GMT, Archie Cobbs wrote:
>> The `Introspector` class was never updated to include `default` methods
>> inherited from interfaces.
>>
>> This patch attempts to fix that omission.
>
> Archie Cobbs has updated the pull request incrementally with two additional
> commi
On Mon, 24 Apr 2023 17:39:17 GMT, Tejesh R wrote:
> Open source few AWT ScrollPane related tests.
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/ScrollPane/RemoveChild/ScrollPaneRemoveAdd.java line 84:
> 82: pane.remove(0);
> 83: pane.add(but
On Mon, 24 Apr 2023 18:14:05 GMT, Sergey Bylokhov wrote:
>> Archie Cobbs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add braces around if clause.
>
> test/jdk/java/beans/Introspector/DefaultMethodBeanPropertyTest.java line 34:
>
>>
> The `Introspector` class was never updated to include `default` methods
> inherited from interfaces.
>
> This patch attempts to fix that omission.
Archie Cobbs has updated the pull request incrementally with two additional
commits since the last revision:
- Jam lines into 80 columns.
- Add
On Mon, 24 Apr 2023 18:43:26 GMT, Alexey Ivanov wrote:
>> I preferred asynchronous EDT would be better since its finally block. Is
>> there any particular reason that we should use `invokeAndWait` than
>> `invokeLater`?
>
>> I preferred asynchronous EDT would be better since its finally block.
On Mon, 24 Apr 2023 17:39:17 GMT, Tejesh R wrote:
> Open source few AWT ScrollPane related tests.
> I thought the preferred layout for tests is to use a flat layout without
> creating _additional folder_ for each test.
>
> So,
> `test/jdk/java/awt/ScrollPane/ComponentScrollTest/ComponentScrol
On Mon, 24 Apr 2023 17:39:17 GMT, Tejesh R wrote:
> Open source few AWT ScrollPane related tests.
I thought the preferred layout for tests is to use a flat layout without
creating *additional folder* for each test.
So, `test/jdk/java/awt/ScrollPane/ComponentScrollTest/ComponentScrollTest.java`
On Mon, 24 Apr 2023 18:41:27 GMT, Sergey Bylokhov wrote:
> invokeLater may not be executed before the test stops by the jtreg, EDT could
> be killed at that point. It is better to use invokeAndWait or somehow make
> sure it will ends.
Totally agree.
-
PR Review Comment: https://g
On Mon, 24 Apr 2023 03:10:38 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/java/awt/Graphics/GetGraphicsTest.java line 35:
>>
>>> 33: import java.awt.Graphics;
>>> 34:
>>> 35: public class GetGraphicsTest {
>>
>> What this test is expected to test? the getBackground/getForeground/getFont
>> see
On Mon, 24 Apr 2023 18:36:56 GMT, Tejesh R wrote:
> I preferred asynchronous EDT would be better since its finally block. Is
> there any particular reason that we should use `invokeAndWait` than
> `invokeLater`?
You want to **wait** until the frame is disposed of before exiting the main
threa
On Sat, 22 Apr 2023 00:21:06 GMT, Alexander Zuev wrote:
>> Cleaned up and stabilized four Dialog-related tests.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added couple of empty lines to make code nore readable.
test
On Mon, 24 Apr 2023 18:23:14 GMT, Sergey Bylokhov wrote:
>> Open source few AWT ScrollPane related tests.
>
> test/jdk/java/awt/ScrollPane/ComponentScrollTest/ComponentScrollTest.java
> line 87:
>
>> 85: });
>> 86: } finally {
>> 87: EventQueue.invokeLater(() ->
On Mon, 24 Apr 2023 17:48:37 GMT, Archie Cobbs wrote:
>> The `Introspector` class was never updated to include `default` methods
>> inherited from interfaces.
>>
>> This patch attempts to fix that omission.
>
> Archie Cobbs has updated the pull request incrementally with one additional
> commi
On Mon, 24 Apr 2023 09:51:50 GMT, Prasanta Sadhukhan
wrote:
> This opensources few Swing event and AbstractAction tests
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13608#pullrequestreview-1398581656
On Mon, 24 Apr 2023 17:25:31 GMT, Phil Race wrote:
> Open sourcing several AWT Choice regression tests
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13620#pullrequestreview-1398579071
On Mon, 24 Apr 2023 17:39:17 GMT, Tejesh R wrote:
> Open source few AWT ScrollPane related tests.
test/jdk/java/awt/ScrollPane/ComponentScrollTest/ComponentScrollTest.java line
87:
> 85: });
> 86: } finally {
> 87: EventQueue.invokeLater(() -> {
Why the invokeL
On Mon, 24 Apr 2023 17:39:20 GMT, Phil Race wrote:
> Open source a few more AWT Choice tests
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13622#pullrequestreview-1398575644
On Mon, 24 Apr 2023 17:48:37 GMT, Archie Cobbs wrote:
>> The `Introspector` class was never updated to include `default` methods
>> inherited from interfaces.
>>
>> This patch attempts to fix that omission.
>
> Archie Cobbs has updated the pull request incrementally with one additional
> commi
On Mon, 24 Apr 2023 17:39:17 GMT, Tejesh R wrote:
> Open source few AWT ScrollPane related tests.
test/jdk/java/awt/ScrollPane/ComponentScrollTest/ComponentScrollTest.java line
48:
> 46: public Frame frame;
> 47: public int count = 0;
> 48: public static void main(String[] args) th
On Mon, 24 Apr 2023 17:30:56 GMT, Alexey Ivanov wrote:
>> Archie Cobbs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commi
> The `Introspector` class was never updated to include `default` methods
> inherited from interfaces.
>
> This patch attempts to fix that omission.
Archie Cobbs has updated the pull request incrementally with one additional
commit since the last revision:
Add braces around if clause.
-
Open source few AWT ScrollPane related tests.
-
Commit messages:
- Converted test
Changes: https://git.openjdk.org/jdk/pull/13621/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13621&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8306137
Stats: 822 lines in 7 files
Open source a few more AWT Choice tests
-
Commit messages:
- 8306682
Changes: https://git.openjdk.org/jdk/pull/13622/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13622&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8306682
Stats: 535 lines in 4 files changed: 535
Open sourcing several AWT Choice regression tests
-
Commit messages:
- 8306484
Changes: https://git.openjdk.org/jdk/pull/13620/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13620&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8306484
Stats: 1048 lines in 6 files c
On Fri, 21 Apr 2023 20:27:57 GMT, Archie Cobbs wrote:
>> The `Introspector` class was never updated to include `default` methods
>> inherited from interfaces.
>>
>> This patch attempts to fix that omission.
>
> Archie Cobbs has updated the pull request with a new target base due to a
> merge o
On Fri, 21 Apr 2023 20:27:57 GMT, Archie Cobbs wrote:
>> The `Introspector` class was never updated to include `default` methods
>> inherited from interfaces.
>>
>> This patch attempts to fix that omission.
>
> Archie Cobbs has updated the pull request with a new target base due to a
> merge o
On Fri, 21 Apr 2023 20:27:57 GMT, Archie Cobbs wrote:
>> The `Introspector` class was never updated to include `default` methods
>> inherited from interfaces.
>>
>> This patch attempts to fix that omission.
>
> Archie Cobbs has updated the pull request with a new target base due to a
> merge o
> This open source AWT Mouse Info related tests.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13573/files
- new: https://git.openjdk.
On Mon, 24 Apr 2023 15:36:34 GMT, lawrence.andrews wrote:
>> @lawrence-andrew, BTW, why `transient`? Should it be `volatile` instead?
>
> Oh, yes, sorry I was meant to say volatile but I typed transient. Sorry for
> the confusion.
Looks good to me.
-
PR Review Comment: https://git
On Mon, 24 Apr 2023 14:58:06 GMT, Nikita Provotorov wrote:
>> It is allowed please use transient keyword for xPos & yPos
>
> @lawrence-andrew, BTW, why `transient`? Should it be `volatile` instead?
Oh, yes, sorry I was meant to say volatile but I typed transient. Sorry for the
confusion.
-
On Mon, 24 Apr 2023 14:11:00 GMT, lawrence.andrews wrote:
>> Yeah, getting the values within EDT and used for `Robot` operations outside.
>> Isn't it allowed ?
>
> It is allowed please use transient keyword for xPos & yPos
@lawrence-andrew, BTW, why `transient`? Should it be `volatile` instead?
> This open source AWT Mouse Info related tests.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13573/files
- new: https://git.openjdk.
On Mon, 24 Apr 2023 14:11:00 GMT, lawrence.andrews wrote:
>> Yeah, getting the values within EDT and used for `Robot` operations outside.
>> Isn't it allowed ?
>
> It is allowed please use transient keyword for xPos & yPos
Sure.
-
PR Review Comment: https://git.openjdk.org/jdk/pul
On Mon, 24 Apr 2023 14:08:24 GMT, Tejesh R wrote:
>> test/jdk/java/awt/MouseInfo/ContainerMousePositionTest.java line 88:
>>
>>> 86: EventQueue.invokeAndWait(() -> {
>>> 87: Point p = button.getLocationOnScreen();
>>> 88: xPos = p.x + button.getWidth()
On Mon, 24 Apr 2023 13:35:20 GMT, lawrence.andrews wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated
>
> test/jdk/java/awt/MouseInfo/ContainerMousePositionTest.java line 88:
>
>> 86: EventQueue.invok
On Mon, 24 Apr 2023 10:04:49 GMT, Tejesh R wrote:
>> This open source AWT Mouse Info related tests.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated
test/jdk/java/awt/MouseInfo/ContainerMousePositionTest.java line 88:
On Mon, 17 Apr 2023 08:14:13 GMT, Dmitry Cherepanov
wrote:
>> This PR suggests to move generalPrimitives array to a new static nested
>> GeneralPrimitives class to eliminate the possible deadlock. The Blit class
>> (and other classes that register as general primitives) calls to
>> GeneralPri
On Fri, 21 Apr 2023 23:13:51 GMT, Alexander Zvegintsev
wrote:
> Open sourcing few AWT clipboard tests.
>
> Testing looks good.
This pull request has now been integrated.
Changeset: 136dad71
Author:Alexander Zvegintsev
URL:
https://git.openjdk.org/jdk/commit/136dad7197a1969b2b1fc32
> This open source AWT Mouse Info related tests.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13573/files
- new: https://git.openjdk.org/jdk/pull/13573/files/
This opensources few Swing event and AbstractAction tests
-
Commit messages:
- 8306714: Open source few Swing event and AbstractAction tests
- 8306714: Open source few Swing event and AbstractAction tests
Changes: https://git.openjdk.org/jdk/pull/13608/files
Webrev: https://webrev
On Fri, 21 Apr 2023 20:26:12 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Fri, 21 Apr 2023 04:59:10 GMT, Prasanta Sadhukhan
wrote:
> This opensources few AWT tests
This pull request has now been integrated.
Changeset: f7d45b85
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/commit/f7d45b85a5c664a87c94e0baccd8b9eddce27e2c
Stats: 169 line
61 matches
Mail list logo
