On Fri, 28 Apr 2023 05:21:56 GMT, Sergey Bylokhov wrote:
> Looks fine, please confirm that mach5 is green.
Mach5 is green.
-
PR Comment: https://git.openjdk.org/jdk/pull/13710#issuecomment-1527011667
On Thu, 27 Apr 2023 22:46:41 GMT, Phil Race wrote:
> Small update to a test
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13705#pullrequestreview-1405245552
On Fri, 28 Apr 2023 05:12:50 GMT, Alexander Zuev wrote:
> Cleaned up and ready to opensource:
> java/awt/Focus/FocusForRemovedComponentTest
> java/awt/Focus/FocusTraversalPolicyIAE
> java/awt/Focus/InitialFocusTest
> java/awt/Focus/LabelScrollbar
> java/awt/Focus/ModalDialogInFocusEventTest
Look
Cleaned up and ready to opensource:
java/awt/Focus/FocusForRemovedComponentTest
java/awt/Focus/FocusTraversalPolicyIAE
java/awt/Focus/InitialFocusTest
java/awt/Focus/LabelScrollbar
java/awt/Focus/ModalDialogInFocusEventTest
-
Commit messages:
- 8307078: Opensource and clean up five m
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for t
On Wed, 26 Apr 2023 14:23:27 GMT, Tejesh R wrote:
> Open source few AWT TextArea related tests.
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13670#pullrequestreview-1405220644
Initial implementation for supporting building a fully statically linked (with
a desired set of JDK native libraries and libjvm) Java launcher executable,
which is named as 'javastatic'.
In this PR, the support is only added for the linux platform. Both gcc and
clang can be supported. For curre
On Thu, 27 Apr 2023 22:46:41 GMT, Phil Race wrote:
> Small update to a test
Marked as reviewed by azvegint (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13705#pullrequestreview-1405069181
Cleaning up tests:
AsyncUpFocusCycleTest.java
ClearMostRecentFocusOwnerTest.java
ConsumedTabKeyTest.java,
EventRetargetTest.java
ExtraPropChangeNotifVetoingTest.java
-
Commit messages:
- 8306954: Open source five Focus related tests
Changes: https://git.openjdk.org/jdk/pull/13707/f
On Thu, 23 Mar 2023 19:55:39 GMT, Damon Nguyen wrote:
>> Before the fix, a JComboBox in Nimbus L&F would have normal black text even
>> when the JComboBox was disabled if SynthComboBoxRenderer was replaced with a
>> DefaultListCellRenderer. This text should be greyed out like in other L&F's.
>
Small update to a test
-
Commit messages:
- 8307079
Changes: https://git.openjdk.org/jdk/pull/13705/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13705&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8307079
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Pa
On Thu, 27 Apr 2023 16:50:17 GMT, Tejesh R wrote:
> Open source few AWT Text Component related tests.
Marked as reviewed by prr (Reviewer).
test/jdk/java/awt/TextComponent/DeselectionDuringDoSelectionNonVisibleTest.java
line 30:
> 28: @key headful
> 29: @requires (os.family == "mac") | (o
On Wed, 26 Apr 2023 14:23:27 GMT, Tejesh R wrote:
> Open source few AWT TextArea related tests.
Marked as reviewed by prr (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13670#pullrequestreview-1404948060
Problem:
Check boxes and radio buttons in Windows Look-and-Feel have rendering issues
when window is moved from display with one scale to display with a different
scale on a multi-monitor setup:
- Scrawly ticks in checkboxes;
- Wrong circle relations in selected radio buttons.
Root-cause:
We o
On Thu, 27 Apr 2023 13:18:24 GMT, Martin Desruisseaux wrote:
>> `BufferedImage` implements the `WritableRenderedImage` interface. But the
>> Javadoc is copied from `WritableRenderedImage`, while `BufferedImage` does
>> something quite different. In particular, `TileObserver` are ignored. This
Open source few AWT Text Component related tests.
-
Commit messages:
- Updated
- Updated
- Open sourced TextComponent tests
Changes: https://git.openjdk.org/jdk/pull/13695/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13695&range=00
Issue: https://bugs.openjdk.org/brow
On Wed, 26 Apr 2023 19:48:00 GMT, Abhishek Kumar wrote:
> This PR is to open source Modal related AWT tests.
This pull request has now been integrated.
Changeset: 41ba05e4
Author:Abhishek Kumar
URL:
https://git.openjdk.org/jdk/commit/41ba05e450ed4467535bcee81946099e38665c3f
Stats:
On Thu, 27 Apr 2023 00:12:58 GMT, Jiangli Zhou wrote:
> Resolve misc symbol issues observed when statically linking JDK/VM natives
> with the standard Java launcher executable. Use the same approaches adopted
> by earlier fixes for static linking related symbol problems (e.g.
> JDK-8306033):
>
On Thu, 27 Apr 2023 00:12:58 GMT, Jiangli Zhou wrote:
> Resolve misc symbol issues observed when statically linking JDK/VM natives
> with the standard Java launcher executable. Use the same approaches adopted
> by earlier fixes for static linking related symbol problems (e.g.
> JDK-8306033):
>
On Thu, 27 Apr 2023 00:12:58 GMT, Jiangli Zhou wrote:
> Resolve misc symbol issues observed when statically linking JDK/VM natives
> with the standard Java launcher executable. Use the same approaches adopted
> by earlier fixes for static linking related symbol problems (e.g.
> JDK-8306033):
>
On Wed, 26 Apr 2023 19:48:00 GMT, Abhishek Kumar wrote:
> This PR is to open source Modal related AWT tests.
Marked as reviewed by azvegint (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13676#pullrequestreview-1404036518
On Tue, 25 Apr 2023 22:46:57 GMT, Phil Race wrote:
>> Martin Desruisseaux has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update documentation for adressing comment on pull requests, with two
>> changes to be discussed:
>>
>> - The
> `BufferedImage` implements the `WritableRenderedImage` interface. But the
> Javadoc is copied from `WritableRenderedImage`, while `BufferedImage` does
> something quite different. In particular, `TileObserver` are ignored. This
> pull request add `@implSlec` for explaining the default behaviou
On Wed, 26 Apr 2023 16:45:57 GMT, Tejesh R wrote:
>> test/jdk/java/awt/ScrollPane/ScrollPaneRemoveAdd.java line 121:
>>
>>> 119: volatile boolean state = false;
>>> 120: Object lock = new Object();
>>> 121: volatile int waiting = 0;
>>
>> Why are both `state` and `waitin
On Thu, 27 Apr 2023 06:28:23 GMT, Tejesh R wrote:
>> Open source few AWT ScrollPane related tests.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
test/jdk/java/awt/ScrollPane/ComponentScrollTe
On Thu, 27 Apr 2023 06:28:23 GMT, Tejesh R wrote:
>> Open source few AWT ScrollPane related tests.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
test/jdk/java/awt/ScrollPane/ScrollPaneWindows
On Tue, 25 Apr 2023 23:16:33 GMT, Damon Nguyen wrote:
>> This PR open sources a few more AWT DnD related tests
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove extra folders
test/jdk/java/awt/dnd/SkipDropCompleteTest
On Tue, 25 Apr 2023 13:48:16 GMT, Jayathirth D V wrote:
> This PR open sources some tests related to AWT datatransfer and Toolkit.
test/jdk/java/awt/datatransfer/CRLFTest/CRLFTest.java line 192:
> 190: // the variable finished is set to true.
> 191: pres.
On Thu, 27 Apr 2023 07:28:37 GMT, Tejesh R wrote:
>> I suggest checking and deleting this if the tests will work fine.
>
> Ok, will check that.
The is is failing for both linux and macos. Maybe because of `\r\n` direct
check, so better to leave the test for windows alone.
-
PR Rev
On Wed, 26 Apr 2023 22:09:30 GMT, Sergey Bylokhov wrote:
> Is it possible to set insets in the device constructor
I would very much like to delay getting the insets until they are actually
needed. The device construction is already happening at the time when lots of
info is being fetched from
On Thu, 27 Apr 2023 06:15:53 GMT, Tejesh R wrote:
>> test/jdk/java/awt/TextArea/ReplaceRangeTest.java line 26:
>>
>>> 24: @test
>>> 25: @bug 5025532
>>> 26: @requires (os.family == "windows")
>>
>> Is this test can pass on windows only or we can run it on all platform?
>
> The bug was rai
On Thu, 27 Apr 2023 07:20:22 GMT, Sergey Bylokhov wrote:
>> The bug was raised for windows alone, I think the test can be run on all
>> platforms, haven't checked though.
>
> I suggest checking and deleting this if the tests will work fine.
Ok, will check that.
-
PR Review Comment
On Wed, 26 Apr 2023 17:57:47 GMT, Phil Race wrote:
>> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 114:
>>
>>> 112: }
>>> 113:
>>> 114: if (incorrectActionDetected) {
>>
>> incorrectActionDetected is set on one thread an used on another, same for
>> "frame" in othe
On Thu, 27 Apr 2023 00:12:58 GMT, Jiangli Zhou wrote:
> Resolve misc symbol issues observed when statically linking JDK/VM natives
> with the standard Java launcher executable. Use the same approaches adopted
> by earlier fixes for static linking related symbol problems (e.g.
> JDK-8306033):
>
On Thu, 13 Apr 2023 13:03:37 GMT, Dmitry Cherepanov
wrote:
> This PR suggests to move generalPrimitives array to a new static nested
> GeneralPrimitives class to eliminate the possible deadlock. The Blit class
> (and other classes that register as general primitives) calls to
> GeneralPrimiti
On Tue, 25 Apr 2023 16:19:15 GMT, Damon Nguyen wrote:
>> it is fine to call dispose here on the main, but the frame possibly can be
>> null here.
>
> I have updated the tests to all dispose on the EDT just in case.
The problem is not in the "dispose" but in the next check "frame != null" the
f
On Mon, 17 Apr 2023 08:14:13 GMT, Dmitry Cherepanov
wrote:
>> This PR suggests to move generalPrimitives array to a new static nested
>> GeneralPrimitives class to eliminate the possible deadlock. The Blit class
>> (and other classes that register as general primitives) calls to
>> GeneralPri
37 matches
Mail list logo
