On Fri, 5 May 2023 20:57:33 GMT, Damon Nguyen wrote:
>> When converting this test to be applicable to be open sourced, changes were
>> made. I reverted some of these changes to get the test stable again. Now it
>> passes when run on various OS's 100x.
>
> Damon Nguyen has updated the pull reque
On Thu, 4 May 2023 16:26:47 GMT, Alexander Zvegintsev
wrote:
> We need to relax the java.awt.Robot specification according to the latest
> operating system trends.
> This should at least cover the case of Wayland, which has changed many
> familiar concepts in Linux.
>
> https://bugs.openjdk.
On Tue, 9 May 2023 22:14:04 GMT, Erik Joelsson wrote:
> I think you also need to make a change to `GraalBuilderImage.gmk` and the
> target in `Main.gmk` that calls it.
Good catch! Fixed `GraalBuilderImage.gmk`, thanks!
For the `graal-builder-image` target that uses `GraalBuilderImage.gmk`, it'
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Introduce new make target(s) for creating image/bundle containing hotspot
> libjvm.a and JDK static libraries
>
>
On Tue, 9 May 2023 21:46:42 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle c
On Tue, 9 May 2023 20:43:13 GMT, Phil Race wrote:
> I want to work through the scenarios and how much of it is specific to the
> behaviours of the API you are using and so forth. Since you use the
> Preferences API for saving the token, if you keyed it off the Robot class
> rather than the int
On Mon, 8 May 2023 19:45:18 GMT, Jiangli Zhou wrote:
> > > All of that said, I think we can get away with a smaller subset of
> > > targets and deliverables. AFAIK, graal needs the combined
> > > `graal-builder-image` as input to their build anyway, so they should not
> > > have any dependency
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Introduce new make target(s) for creating image/bundle containing hotspot
> libjvm.a and JDK static libraries
>
>
On Tue, 25 Apr 2023 18:52:16 GMT, Archie Cobbs wrote:
>> The `Introspector` class was never updated to include `default` methods
>> inherited from interfaces.
>>
>> This patch attempts to fix that omission.
>
> Archie Cobbs has updated the pull request with a new target base due to a
> merge o
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Introduce new make target(s) for creating image/bundle containing hotspot
> libjvm.a and JDK static libraries
>
>
On Fri, 5 May 2023 14:35:46 GMT, Alexander Zvegintsev
wrote:
>> Modern Linux systems often come with
>> [Wayland](https://wayland.freedesktop.org/) by default.
>> This comes with some difficulties, and one of them is the inability to get
>> screenshots from the system.
>> This is because we no
On Tue, 9 May 2023 16:05:15 GMT, Alexander Zvegintsev
wrote:
>> src/java.desktop/share/classes/java/awt/Robot.java line 640:
>>
>>> 638: * a new permission from the user on applicable platforms.
>>> 639: */
>>> 640: public void revokeScreenCapturePermission() {
>>
>> I do not und
On Fri, 5 May 2023 06:22:31 GMT, Maxim Kartashev wrote:
>> We need to relax the java.awt.Robot specification according to the latest
>> operating system trends.
>> This should at least cover the case of Wayland, which has changed many
>> familiar concepts in Linux.
>>
>> https://bugs.openjdk.
On Mon, 8 May 2023 20:45:42 GMT, Phil Race wrote:
> Is black guaranteed today if we fail to grab it ?
Currently we are passing a java `pixelArray` it to native to fill it up with
screen capture data.
If we do not change this array(or part related to denied screen) it remains
black.
But I'll
On Thu, 4 May 2023 16:26:47 GMT, Alexander Zvegintsev
wrote:
> We need to relax the java.awt.Robot specification according to the latest
> operating system trends.
> This should at least cover the case of Wayland, which has changed many
> familiar concepts in Linux.
>
> https://bugs.openjdk.
On Thu, 4 May 2023 16:26:47 GMT, Alexander Zvegintsev
wrote:
> We need to relax the java.awt.Robot specification according to the latest
> operating system trends.
> This should at least cover the case of Wayland, which has changed many
> familiar concepts in Linux.
>
> https://bugs.openjdk.
We need to relax the java.awt.Robot specification according to the latest
operating system trends.
This should at least cover the case of Wayland, which has changed many familiar
concepts in Linux.
https://bugs.openjdk.org/browse/JDK-8280982 [Wayland] [XWayland] java.awt.Robot
taking screensho
> Adding some DnD tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
update tests
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13756/files
- new: https://git.openjdk.org/jdk/pull/13756/files/7d514e47..e1e0bc
On Fri, 5 May 2023 18:28:38 GMT, Alisen Chung wrote:
> update freetype version to 2.13, all tests passed
This pull request has now been integrated.
Changeset: 723582c5
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/723582c524c62ee73f7984a53b046f8832b23a7f
Stats: 360
On Sat, 6 May 2023 03:14:32 GMT, Alisen Chung wrote:
>> update freetype version to 2.13, all tests passed
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> readd spaces to comments
Marked as reviewed by dnguyen (Committer).
On Mon, 8 May 2023 19:53:18 GMT, Damon Nguyen wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> readd spaces to comments
>
> src/java.desktop/share/native/libfreetype/include/freetype/internal/ftmmtypes.h
> line 18:
On Sat, 6 May 2023 03:14:32 GMT, Alisen Chung wrote:
>> update freetype version to 2.13, all tests passed
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> readd spaces to comments
"I built jdk with option --with-freetype=bu
On Sat, 6 May 2023 03:14:32 GMT, Alisen Chung wrote:
>> update freetype version to 2.13, all tests passed
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> readd spaces to comments
I built jdk with option --with-freetype=bun
On Tue, 2 May 2023 22:09:18 GMT, Alisen Chung wrote:
> added DnD tests
This pull request has now been integrated.
Changeset: 98294242
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/98294242a94c611e2a713c2d520e59dd873ae4a0
Stats: 1680 lines in 5 files changed: 1680 i
On Mon, 8 May 2023 23:22:52 GMT, Sergey Bylokhov wrote:
>> No, Region.clipRound does something little different than what I intend to
>> do in
>> this code .
>> It works same as my code for 0.25 and 0.75 case. But not for 0.5 case.
>> For example in case of destwidth and destHeight = 19.5,
>>
> This enhancement covers basic API and shared code that should be implemented
> for the Accessibility Announcement feature.
>
> CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499
> "bugs.openjdk.org")
>
> @mrserb @prrace @azuev-java please review
Artem Semenov has updated the pull
> added DnD tests
Alisen Chung has updated the pull request incrementally with two additional
commits since the last revision:
- space
- fix spacing, move check onto EDT
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13765/files
- new: https://git.openjdk.org/jdk/pull/137
> moving tests to open
Alisen Chung has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch 'JTREG_TEST_SPRINT3' of github.com:alisenchung/jdk into
JTREG_TEST_SPRINT3
- moved check onto EDT
-
Changes:
- all: https://git.op
> On Linux systems, we rely on XGrabPointer (X11 API) to capture mouse input
> and dismiss popup menus on mouse clicks outside the popup menu.
> Unfortunately, on Linux systems using the
> [Wayland](https://wayland.freedesktop.org/) session this only works inside
> [XWayland(Wayland's X11 server
On Tue, 9 May 2023 17:42:21 GMT, Sergey Bylokhov wrote:
>> It should, and this is another point about not changing the documentation.
>
> Then let's not update it.
Backed out doc changes.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/13830#discussion_r1188950338
> Added DnD tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fix space, add method on EDT
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13759/files
- new: https://git.openjdk.org/jdk/pull/13759/files/09ceaf
On Mon, 8 May 2023 18:05:59 GMT, Tejesh R wrote:
>> Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
test/jdk/java/a
On Tue, 9 May 2023 14:34:08 GMT, Alexander Zvegintsev
wrote:
>> src/java.desktop/share/classes/java/awt/PopupMenu.java line 46:
>>
>>> 44: * call {@code show} on that {@code PopupMenu}.
>>> 45: *
>>> 46: * @implNote On Linux systems using Wayland, the popup menu may not be
>>> dismissed
>>
On Mon, 8 May 2023 18:31:26 GMT, Sergey Bylokhov wrote:
>> added DnD tests
>
> test/jdk/java/awt/dnd/MozillaDnDTest.java line 177:
>
>> 175: public void start() {
>> 176: // Solaris/Linux-only test
>> 177: if (System.getProperty("os.name").startsWith("Windows")) {
>
> Can we
On Fri, 21 Apr 2023 12:58:58 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> Noticed this test case not verifying all the cases which is intended.
> Modified it for improving the coverage for 3 type of popups (menu, context
> menu and combobox).
>
> Evaluating conditions:
> 1. Not e
On Wed, 8 Mar 2023 18:20:47 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812
On Mon, 8 May 2023 18:41:56 GMT, Sergey Bylokhov wrote:
> > It seems that the current robot API is not suitable for this.
>
> Can we just reset the token when we create a new instance of Robot?
This will be a big problem for automated testing, as each test with the robot
will require user conf
On Mon, 8 May 2023 23:35:19 GMT, Sergey Bylokhov wrote:
>> On Linux systems, we rely on XGrabPointer (X11 API) to capture mouse input
>> and dismiss popup menus on mouse clicks outside the popup menu.
>> Unfortunately, on Linux systems using the
>> [Wayland](https://wayland.freedesktop.org/) se
This looks a useful fix.
Will it be backported to JDK-17 ?
smime.p7s
Description: S/MIME cryptographic signature
39 matches
Mail list logo
