Re: RFR: JDK-8303950: [macos]Translucent Windows Flicker on Repaint [v3]

2023-06-16 Thread Jeremy
> # Problem Summary > > For non-opaque windows, Window#paint calls `gg.fillRect(0, 0, getWidth(), > getHeight())` before `super.paint(g)`. > > This can cause flickering on Mac, and the flickering seems to have gotten > much worse in recent JVMs. (See movie attachments to original ticket.) > >

Integrated: 8309756: Occasional crashes with pipewire screen capture on Wayland

2023-06-16 Thread Phil Race
On Fri, 16 Jun 2023 20:33:32 GMT, Phil Race wrote: > I'd like to backport the fix for this crash to the JDK 21 stabilisation repo. > The fix is in code that is only used by AWT Robot on Wayland desktops so is > quite isolated and unlikely to affect anything else. This pull request has now been

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

2023-06-16 Thread Jiangli Zhou
On Fri, 16 Jun 2023 22:08:19 GMT, Daniel D. Daugherty wrote: > GHA is failing on windows; is this related to this PR or something else? The windows build failures occur with other PRs as well, e.g. https://github.com/openjdk/jdk21/pull/24/checks?check_run_id=14317258603. They should be unrela

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

2023-06-16 Thread Daniel D . Daugherty
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote: > 8307858: [REDO] JDK-8307194 Add make target for optionally building a > complete set of all JDK and hotspot libjvm static libraries GHA is failing on windows; is this related to this PR or something else? @erikj - You did a round of Mach5

Integrated: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-16 Thread Justin Lu
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote: > Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

2023-06-16 Thread Jiangli Zhou
On Fri, 16 Jun 2023 20:52:13 GMT, Kevin Rushforth wrote: > As a P4 enhancement, this doesn't meet the criteria for integration into JDK > 21 during [Rampdown Phase > 1](https://mail.openjdk.org/pipermail/jdk-dev/2023-June/007911.html). You > could request late approval to get this enhancement

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-16 Thread Naoto Sato
On Fri, 16 Jun 2023 04:39:42 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

2023-06-16 Thread Kevin Rushforth
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote: > 8307858: [REDO] JDK-8307194 Add make target for optionally building a > complete set of all JDK and hotspot libjvm static libraries As a P4 enhancement, this doesn't meet the criteria for integration into JDK 21 during [Rampdown Phase 1]

Re: RFR: 8309756: Occasional crashes with pipewire screen capture on Wayland

2023-06-16 Thread Alexander Zvegintsev
On Fri, 16 Jun 2023 20:33:32 GMT, Phil Race wrote: > I'd like to backport the fix for this crash to the JDK 21 stabilisation repo. > The fix is in code that is only used by AWT Robot on Wayland desktops so is > quite isolated and unlikely to affect anything else. Marked as reviewed by azvegint

RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries

2023-06-16 Thread Jiangli Zhou
8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries - Commit messages: - Backport 45414fc2dfa41cbbfc6de7fec15eb47f41cf8986 Changes: https://git.openjdk.org/jdk21/pull/26/files Webrev: https://webrevs.ope

RFR: 8309756: Occasional crashes with pipewire screen capture on Wayland

2023-06-16 Thread Phil Race
I'd like to backport the fix for this crash to the JDK 21 stabilisation repo. The fix is in code that is only used by AWT Robot on Wayland desktops so is quite isolated and unlikely to affect anything else. - Commit messages: - Backport d3d0dbc36369da0c17a66f8b633e73a150ab8c4f Chan

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox

2023-06-16 Thread Nikita Provotorov
On Thu, 15 Jun 2023 15:58:18 GMT, Abhishek Kumar wrote: > The issue exist only for non-editable combobox and the root cause is > accessible object is not created due to incorrect index returned from > component class which results in no a11y API invoked. > > Proposed solution is to return the

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-16 Thread Daniel D . Daugherty
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas wrote: >> The current implementation for testing generational ZGC with jtreg is >> implemented with a filter on the mode flag `ZGenerational`. Because of this >> only environments which set this flag explicitly will run most of the tests.

Re: Why does Java resize a Window to 1x1 pixel when HDMI is unplugged (and does not resize back when HDMI is plugged)

2023-06-16 Thread Philip Race
I'd like to re-iterate that Wayland is not a supported platform for ANY version of JDK. It is known "not to work" - I suggest you use X.org, not Wayland. And when we do get to support Wayland it will be on a VERY recent Linux platform. As a minimum it will probably require Gnome 45  - which isn'

Re: RFR: JDK-8303950: [macos]Translucent Windows Flicker on Repaint [v2]

2023-06-16 Thread Andrey Turbanov
On Wed, 7 Jun 2023 19:19:59 GMT, Jeremy wrote: >> # Problem Summary >> >> For non-opaque windows, Window#paint calls `gg.fillRect(0, 0, getWidth(), >> getHeight())` before `super.paint(g)`. >> >> This can cause flickering on Mac, and the flickering seems to have gotten >> much worse in recent

RFR: 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails

2023-06-16 Thread Phil Race
This test fails *every* time when run as part of full set of jtreg tests and that is because it is sensitive to the initial mouse location, and the previous test always sets it to within the location of this test's window. The only reason it isn't problem listed is because on re-run - without tha

Integrated: 8310054: ScrollPane insets are incorrect

2023-06-16 Thread Alexey Ivanov
On Wed, 14 Jun 2023 20:17:32 GMT, Alexey Ivanov wrote: > After the size of `ScrollPane` child component changes, it recalculates the > size of the scroll bars and hides or shows them as necessary. This situation > is handled in `WScrollPanePeer.childResized`: > > https://github.com/openjdk/jdk

Re: RFR: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen [v7]

2023-06-16 Thread Tejesh R
> When a frame is dragged from one screen to another screen, the > `GraphicsConfigurations` may vary depending on screen/monitor. However, > transparency has to be maintained since it is expected as it is set. So the > fix addresses in maintaining the translucency capability when frame is moved

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-16 Thread Naoto Sato
On Fri, 16 Jun 2023 15:06:30 GMT, Jonathan Gibbons wrote: >> Left some comments on the translations mainly in Japanese. It is now very >> easy to look at the l10n changes in the generated HTML. One small comment to >> the tool is that it would be nice if the order in HTML (alphabetically >> so

Re: RFR: 8310054: ScrollPane insets are incorrect

2023-06-16 Thread Alexey Ivanov
On Thu, 15 Jun 2023 23:29:37 GMT, Phil Race wrote: > So I think I see with the benefit of your recent comments. > It seemed that reverting _SetSpans to synchronous would fix this and somehow > I read that was what you were doing. > But you didn't want to do that and you were forced into making _

Re: RFR: 8310054: ScrollPane insets are incorrect

2023-06-16 Thread Harshitha Onkar
On Wed, 14 Jun 2023 20:17:32 GMT, Alexey Ivanov wrote: > After the size of `ScrollPane` child component changes, it recalculates the > size of the scroll bars and hides or shows them as necessary. This situation > is handled in `WScrollPanePeer.childResized`: > > https://github.com/openjdk/jdk

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-16 Thread Jonathan Gibbons
On Tue, 13 Jun 2023 18:38:28 GMT, Naoto Sato wrote: > Left some comments on the translations mainly in Japanese. It is now very > easy to look at the l10n changes in the generated HTML. One small comment to > the tool is that it would be nice if the order in HTML (alphabetically sorted > curre

Re: RFR: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen [v6]

2023-06-16 Thread Alexander Zvegintsev
On Fri, 16 Jun 2023 08:15:17 GMT, Tejesh R wrote: >> When a frame is dragged from one screen to another screen, the >> `GraphicsConfigurations` may vary depending on screen/monitor. However, >> transparency has to be maintained since it is expected as it is set. So the >> fix addresses in main

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-16 Thread Erik Österlund
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas wrote: >> The current implementation for testing generational ZGC with jtreg is >> implemented with a filter on the mode flag `ZGenerational`. Because of this >> only environments which set this flag explicitly will run most of the tests.

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-16 Thread Stefan Karlsson
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas wrote: >> The current implementation for testing generational ZGC with jtreg is >> implemented with a filter on the mode flag `ZGenerational`. Because of this >> only environments which set this flag explicitly will run most of the tests.

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-16 Thread Axel Boldt-Christmas
> The current implementation for testing generational ZGC with jtreg is > implemented with a filter on the mode flag `ZGenerational`. Because of this > only environments which set this flag explicitly will run most of the tests. > So they get missed in Github Actions and for developers running j

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox

2023-06-16 Thread Artem Semenov
On Thu, 15 Jun 2023 15:58:18 GMT, Abhishek Kumar wrote: > The issue exist only for non-editable combobox and the root cause is > accessible object is not created due to incorrect index returned from > component class which results in no a11y API invoked. > > Proposed solution is to return the

RFR: 8310187: Improve Generational ZGC jtreg testing

2023-06-16 Thread Axel Boldt-Christmas
The current implementation for testing generational ZGC with jtreg is implemented with a filter on the mode flag `ZGenerational`. Because of this only environments which set this flag explicitly will run most of the tests. So they get missed in Github Actions and for developers running jtreg loc

Re: RFR: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen [v6]

2023-06-16 Thread Tejesh R
On Fri, 16 Jun 2023 00:20:08 GMT, Alexander Zvegintsev wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > src/java.desktop/share/classes/java/awt/Window.java line 3223: > >> 3221:

Re: RFR: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen [v5]

2023-06-16 Thread Tejesh R
On Thu, 15 Jun 2023 21:37:09 GMT, Alexander Zvegintsev wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > src/java.desktop/macosx/classes/sun/lwawt/macosx/CFileDialog.java line 205: >

Re: RFR: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen [v6]

2023-06-16 Thread Tejesh R
> When a frame is dragged from one screen to another screen, the > `GraphicsConfigurations` may vary depending on screen/monitor. However, > transparency has to be maintained since it is expected as it is set. So the > fix addresses in maintaining the translucency capability when frame is moved