On Mon, 3 Jul 2023 20:17:23 GMT, Alexey Ivanov wrote:
>> Please review this patch that configures C++ arguments on build jobs that
>> involve compiling CPP files. As a result of this change, CPP files are
>> compiled with `-std:c++14` command line argument instead of `-std:c11`,
>> which is us
On Mon, 3 Jul 2023 21:26:13 GMT, Harshitha Onkar wrote:
>> I disagree: the common style throughout this file is to put the opening
>> brace on the following line. A few lines above, `GetCGKeyCode` follows the
>> same style.
>
> @aivanov-jdk Yeah, I wasn't sure of open brace placement in native
On Mon, 3 Jul 2023 20:28:35 GMT, Alexey Ivanov wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/CRobot.m line 426:
>>
>>> 424: }
>>> 425:
>>> 426: static inline int GetCGKeyMask(int cgKeyCode)
>>
>> Suggestion:
>>
>> static inline int GetCGKeyMask(int cgKeyCode) {
>
> I disagree: the
On Mon, 3 Jul 2023 18:28:40 GMT, Harshitha Onkar wrote:
> Comparison typo fix. Should be monitor2 (mi2) instead of monitor1 (mi1).
This pull request has now been integrated.
Changeset: d8a01216
Author:Harshitha Onkar
URL:
https://git.openjdk.org/jdk/commit/d8a012161ad68d08467a6632c2
On Mon, 3 Jul 2023 04:45:38 GMT, Abhishek Kumar wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> kCGEventFlagMaskSecondaryFn added
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/CRobot.m line 426:
>
>> 424:
On Sat, 1 Jul 2023 00:29:11 GMT, Harshitha Onkar wrote:
>> **Problem:**
>>
>> Robot erroneously produces lowercase letter when mouse is moved (manually)
>> in unison with Robot's keyEvents on MacOS. This issue was originally logged
>> by a developer of an on-screen accessibility keyboard - To
On Mon, 3 Jul 2023 17:15:17 GMT, Daniel Jeliński wrote:
> Please review this patch that configures C++ arguments on build jobs that
> involve compiling CPP files. As a result of this change, CPP files are
> compiled with `-std:c++14` command line argument instead of `-std:c11`, which
> is used
On Mon, 3 Jul 2023 18:28:40 GMT, Harshitha Onkar wrote:
> Comparison typo fix. Should be monitor2 (mi2) instead of monitor1 (mi1).
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14760#pullrequestreview-1511652869
Please review this patch that configures C++ arguments on build jobs that
involve compiling CPP files. As a result of this change, CPP files are compiled
with `-std:c++14` command line argument instead of `-std:c11`, which is used
when C++ arguments are not configured.
While at it, I simplified
Comparison typo fix. Should be monitor2 (mi2) instead of monitor1 (mi1).
-
Commit messages:
- changed to mi2
Changes: https://git.openjdk.org/jdk/pull/14760/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14760&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8311109
> **Problem:**
>
> Robot erroneously produces lowercase letter when mouse is moved (manually) in
> unison with Robot's keyEvents on MacOS. This issue was originally logged by a
> developer of an on-screen accessibility keyboard - TouchBoard. Originally
> reported at https://github.com/adoptium
On Mon, 3 Jul 2023 11:11:47 GMT, Alexey Ivanov wrote:
>>> What if `JComboBox` uses a non-standard renderer which takes a property
>>> from an object? Let's assume, `JComboBox` is populated with `Rectangle`
>>> objects, a custom renderer is set which displays the value of the `bottom`
>>> field
On Mon, 3 Jul 2023 09:14:23 GMT, Abhishek Kumar wrote:
> > What if `JComboBox` uses a non-standard renderer which takes a property
> > from an object? Let's assume, `JComboBox` is populated with `Rectangle`
> > objects, a custom renderer is set which displays the value of the `bottom`
> > fiel
On Wed, 7 Jun 2023 12:54:54 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have updated the JRobot.java file for enabling EDT support, along with I
> have removed warning BUTTON1_MASK with 'BUTTON1_DOWN_MASK'.
>
> Regards,
> Renjith
This pull request has now been integrated.
C
On Fri, 30 Jun 2023 19:36:43 GMT, Alexey Ivanov wrote:
>> I need to check with custom renderer.
>>
>> If I understand correctly, with current fix the `getSelectedItem` method
>> will return the `rectangle` object and then calling `toString` method will
>> return rectangle's dimension instead
On Thu, 20 Apr 2023 05:47:35 GMT, Ichiroh Takiguchi
wrote:
> "character set of font" (font charset) table was created by "Rich Text Format
> Specification 1.9.1"
> https://interoperability.blob.core.windows.net/files/Archive_References/[MSFT-RTF].pdf
> It refers windgi.h
> https://learn.microso
16 matches
Mail list logo
