On Wed, 5 Jul 2023 08:25:20 GMT, Tejesh R wrote:
>> The header border uses `g.drawLine` whereas the JTable data grid lines uses
>> `SwingUtilities2.drawVLine` and `SwingUtilities2.drawHLine` to draw
>> horizontal and vertical lines. The SwingUtilities2 uses `Graphics.fillRect`
>> which contrib
On Wed, 5 Jul 2023 12:46:26 GMT, Alexey Ivanov wrote:
>>> > > That gap is caused because of alignment miss-match between vertical
>>> > > lines of header border and data grid lines. To be specific the header
>>> > > vertical line is slightly left (around a pixel) than data grid line.
>>> >
>>>
On Fri, 23 Jun 2023 03:14:21 GMT, Prasanta Sadhukhan
wrote:
>> If a JTable is wrapped in JLayer and first row is selected and VK_PAGE_DOWN
>> is pressed, the last row of the table is selected instead of the next row
>> after current viewport.
>> This is because table.getParent.getSize() return
> **Problem:**
>
> On macOS, Robot erroneously produces lowercase letter when mouse is moved
> (manually) in unison with Robot's keyEvents. This issue was originally logged
> by a developer of an on-screen accessibility keyboard - TouchBoard.
> Originally reported at https://github.com/adoptiu
On Mon, 3 Jul 2023 17:43:34 GMT, Harshitha Onkar wrote:
>> **Problem:**
>>
>> On macOS, Robot erroneously produces lowercase letter when mouse is moved
>> (manually) in unison with Robot's keyEvents. This issue was originally
>> logged by a developer of an on-screen accessibility keyboard - T
On Wed, 5 Jul 2023 23:19:39 GMT, Liam Miller-Cushon wrote:
> Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to
> use the reported length of the segment instead of assuming it's always
> exactly 14 bytes.
Thanks, I have removed the test
-
PR Comment: http
> Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to
> use the reported length of the segment instead of assuming it's always
> exactly 14 bytes.
Liam Miller-Cushon has updated the pull request with a new target base due to a
merge or a rebase. The pull request now cont
> **Problem:**
>
> On macOS, Robot erroneously produces lowercase letter when mouse is moved
> (manually) in unison with Robot's keyEvents. This issue was originally logged
> by a developer of an on-screen accessibility keyboard - TouchBoard.
> Originally reported at https://github.com/adoptiu
On Mon, 3 Jul 2023 21:28:36 GMT, Alexey Ivanov wrote:
>> @aivanov-jdk Yeah, I wasn't sure of open brace placement in native - some
>> methods follow Java-style of having the open brace on the same line and few
>> others have it on the next line. Will revert it in the next commit.
>
> Follow the
On Mon, 3 Jul 2023 20:38:34 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> kCGEventFlagMaskSecondaryFn added
>
> test/jdk/java/awt/Robot/RobotModifierMaskTest.java line 67:
>
>> 65:
On Wed, 5 Jul 2023 23:19:39 GMT, Liam Miller-Cushon wrote:
> Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to
> use the reported length of the segment instead of assuming it's always
> exactly 14 bytes.
The provided image for the test looks to me like a down-sized ve
Please review this fix for JDK-6355567, which updates AdobeMarkerSegment to use
the reported length of the segment instead of assuming it's always exactly 14
bytes.
-
Commit messages:
- 6355567: AdobeMarkerSegment causes failure to read valid JPEG
Changes: https://git.openjdk.org/
> The issue exist only for non-editable combobox and the root cause is
> accessible object is not created due to incorrect index returned from
> component class which results in no a11y API invoked.
>
> Proposed solution is to return the correct accessible child from
> getAccessibleChild method
On Fri, 30 Jun 2023 11:37:10 GMT, Matthias Baesken wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last rev
On Wed, 5 Jul 2023 15:01:52 GMT, Matthias Baesken wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revi
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
Adjust comments
-
Changes:
- all: https:/
On Mon, 3 Jul 2023 17:15:17 GMT, Daniel Jeliński wrote:
> Please review this patch that configures C++ arguments on build jobs that
> involve compiling CPP files. As a result of this change, CPP files are
> compiled with `-std:c++14` command line argument instead of `-std:c11`, which
> is used
On Wed, 5 Jul 2023 11:56:05 GMT, Alexey Ivanov wrote:
>> How will counting the number of pixels of a particular color help in
>> validating the fix? I was planning to take a portion of image which includes
>> header and 1st row and then check the column of vertical line from header to
>> data,
On Fri, 30 Jun 2023 11:37:10 GMT, Matthias Baesken wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last rev
On Thu, 22 Jun 2023 09:21:29 GMT, Matthias Baesken wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java
>> line 196:
>>
>>> 194:
>>> 195: /**
>>> 196: * Set whether or not to use ct.sym as an alternate
>>
>> As an alternate to what? This needs somet
On Wed, 5 Jul 2023 13:06:05 GMT, Abhishek Kumar wrote:
> > This is weird. I expect the accessibility API is called on the JComboBox in
> > both cases where it's editable or not. Could this be a bug? Should we fix
> > it in a different way?
>
> AFAIK, I don't think that it is a bug because the
On Wed, 5 Jul 2023 12:37:23 GMT, Alexey Ivanov wrote:
> This is weird. I expect the accessibility API is called on the JComboBox in
> both cases where it's editable or not. Could this be a bug? Should we fix it
> in a different way?
AFAIK, I don't think that it is a bug because the arrow butto
On Wed, 5 Jul 2023 08:39:27 GMT, Tejesh R wrote:
> I'm not sure if it is a bug, the gap is because of white lines drawn for each
> header cell (bottom-left till top-left and then to to-right for each header
> cell). Kind of shade effect.
I admit I am confused to which part it refers.
I re-che
On Wed, 5 Jul 2023 09:43:12 GMT, Abhishek Kumar wrote:
>>> And this seems to be the problem. The getAccessibleName method should be on
>>> JComboBox, or its editor, which should return the result of
>>> getAccessibleName of the renderer component.
>>
>> Since the a11y APIs are called upon the
On Wed, 5 Jul 2023 04:35:18 GMT, Tejesh R wrote:
>> I strongly believe it should be an automated test. It may even be headless,
>> if possible. There are a couple of examples which compare border rendering.
>>
>> You don't need to store images, just count the number of pixels of a
>> particula
On Wed, 5 Jul 2023 04:58:12 GMT, Abhishek Kumar wrote:
>>> But in case of JComboBox, a11y API invokes the `getAccessibleName` method
>>> for `AccessibleJButton` and that returns an empty string.
>>
>> And this seems to be the problem. The `getAccessibleName` method should be
>> on JComboBox, o
> The issue exist only for non-editable combobox and the root cause is
> accessible object is not created due to incorrect index returned from
> component class which results in no a11y API invoked.
>
> Proposed solution is to return the correct accessible child from
> getAccessibleChild method
On Tue, 4 Jul 2023 12:55:40 GMT, Alexey Ivanov wrote:
> > > That gap is caused because of alignment miss-match between vertical lines
> > > of header border and data grid lines. To be specific the header vertical
> > > line is slightly left (around a pixel) than data grid line.
> >
> >
> > Is
> The header border uses `g.drawLine` whereas the JTable data grid lines uses
> `SwingUtilities2.drawVLine` and `SwingUtilities2.drawHLine` to draw
> horizontal and vertical lines. The SwingUtilities2 uses `Graphics.fillRect`
> which contributes to the difference between the position of these tw
29 matches
Mail list logo
