Re: RFR: 8280482: Window transparency bug on Linux [v2]

2023-07-19 Thread Tejesh R
On Thu, 20 Jul 2023 00:43:54 GMT, Alexander Zvegintsev wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review fix > > src/java.desktop/unix/classes/sun/awt/X11/XWindowPeer.java line 807: > >> 805: insLog.

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v2]

2023-07-19 Thread Renjith Kannath Pariyangad
On Wed, 19 Jul 2023 00:07:05 GMT, Sergey Bylokhov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Updated copyright year > > src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cp

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-07-19 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > > Observations : > 1. Without com initialize if we access Mixer for recording, library loaded > invalid GUID and clipped description in windows(ID not found in registry). > With com initialization library load proper GUID (same as registry). > 2. For Play back device always loa

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v6]

2023-07-19 Thread David Holmes
On Wed, 19 Jul 2023 10:58:58 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal the `-Xdebug` option and `-debug` option of the `java` command? >> This addresses https://bugs.openjdk.org/browse/JDK-8227229. >> >> As noted in the JBS

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v5]

2023-07-19 Thread Sergey Bylokhov
On Thu, 29 Jun 2023 13:35:20 GMT, Alexey Ivanov wrote: >> I think it is not needed to return 1 from `getAccessibleChildrenCount(...)`. >> `getAccessibleChildrenCount(...)` is used to get the exact number of >> accessible child for a component and afterwards `getAccessibleChild(..., >> index)`

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v5]

2023-07-19 Thread Sergey Bylokhov
On Wed, 5 Jul 2023 17:45:35 GMT, Abhishek Kumar wrote: >> The issue exist only for non-editable combobox and the root cause is >> accessible object is not created due to incorrect index returned from >> component class which results in no a11y API invoked. >> >> Proposed solution is to return

Re: RFR: 8311033: [macos] PrinterJob does not take into account Sides attribute [v3]

2023-07-19 Thread Sergey Bylokhov
On Fri, 14 Jul 2023 14:44:57 GMT, Alexander Scherbatiy wrote: >> To reproduce the issue run the >> [JavaSidesAttributePrinting](https://bugs.openjdk.org/secure/attachment/104448/JavaSidesAttributePrinting.java) >> java sample with ONE_SIDED and DUPLEX arguments on macOS: >> >> java JavaSidesA

Re: RFR: 8280482: Window transparency bug on Linux [v2]

2023-07-19 Thread Alexander Zvegintsev
On Wed, 12 Jul 2023 04:59:30 GMT, Tejesh R wrote: >> The bug mentions about transparency issue on Linux which actually got >> resolved with [JDK-8006421](https://bugs.openjdk.org/browse/JDK-8006421) >> fix. Now there is another problem related to the bug, which is screen >> selection going wro

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v6]

2023-07-19 Thread Chris Plummer
On Wed, 19 Jul 2023 10:58:58 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal the `-Xdebug` option and `-debug` option of the `java` command? >> This addresses https://bugs.openjdk.org/browse/JDK-8227229. >> >> As noted in the JBS

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v6]

2023-07-19 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to deprecate for > removal the `-Xdebug` option and `-debug` option of the `java` command? This > addresses https://bugs.openjdk.org/browse/JDK-8227229. > > As noted in the JBS issue this option is currently a no-op and has been there >

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v4]

2023-07-19 Thread Alan Bateman
On Wed, 19 Jul 2023 07:05:45 GMT, Jaikiran Pai wrote: > I had initially considered that but had noticed that there's a small > difference between the generic warning message "Warning: %s option is > deprecated and may be removed in a future release." printed by the launcher > and the one print

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v5]

2023-07-19 Thread Alan Bateman
On Wed, 19 Jul 2023 07:05:51 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal the `-Xdebug` option and `-debug` option of the `java` command? >> This addresses https://bugs.openjdk.org/browse/JDK-8227229. >> >> As noted in the JBS

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v5]

2023-07-19 Thread Alan Bateman
On Wed, 19 Jul 2023 07:07:40 GMT, Jaikiran Pai wrote: > I would like inputs on the > test/hotspot/jtreg/runtime/6294277/SourceDebugExtension.java test. That test > launches java passing it the -Xdebug option and was introduced as part of > https://bugs.openjdk.org/browse/JDK-6294277. -Xdebug h

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v5]

2023-07-19 Thread Jaikiran Pai
On Wed, 19 Jul 2023 07:05:51 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal the `-Xdebug` option and `-debug` option of the `java` command? >> This addresses https://bugs.openjdk.org/browse/JDK-8227229. >> >> As noted in the JBS

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v4]

2023-07-19 Thread Jaikiran Pai
On Tue, 18 Jul 2023 12:41:32 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to deprecate for >> removal the `-Xdebug` option and `-debug` option of the `java` command? >> This addresses https://bugs.openjdk.org/browse/JDK-8227229. >> >> As noted in the JBS

Re: RFR: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6 [v5]

2023-07-19 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to deprecate for > removal the `-Xdebug` option and `-debug` option of the `java` command? This > addresses https://bugs.openjdk.org/browse/JDK-8227229. > > As noted in the JBS issue this option is currently a no-op and has been there >