On Tue, 25 Jul 2023 11:17:52 GMT, Alexey Ivanov wrote:
> The bug report mentions using `setDocument()` to change the value of the
> formatted text field. Also, it's possible to call `getDocument().setText()`,
> which may still have the original bug.
Fixed setDocument but I couldn't find Docume
> When a JFormattedTextField field value is set by setText, then when the field
> initially gains focus it seems to not use the edit formatter, but rather use
> display formatter, which is wrong.
> Native "Date and Time setting" in windows changes the date field to edit mode
> in initial focus
> Please review the simple fix that changes start|stop_timer to static.
Jiangli Zhou has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains two additional comm
On Mon, 24 Jul 2023 10:21:52 GMT, Aleksey Shipilev wrote:
> There is a simple build failure after
> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs:
>
>
> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o:
> In file included from
> /home/bui
On Tue, 25 Jul 2023 04:27:47 GMT, Sergey Bylokhov wrote:
> I was thinking of asking you to see if there are any other variables or
> functions in this file that could be made static, but it looks like xx_timer
> are the only one left. Can you please confirm?
@mrserb, thanks for looking into it
On Tue, 18 Jul 2023 04:36:50 GMT, Tejesh R wrote:
>> The header border uses `g.drawLine` whereas the JTable data grid lines uses
>> `SwingUtilities2.drawVLine` and `SwingUtilities2.drawHLine` to draw
>> horizontal and vertical lines. The SwingUtilities2 uses `Graphics.fillRect`
>> which contri
On Fri, 14 Jul 2023 07:43:00 GMT, Tejesh R wrote:
>> "size" label which is _RIGHT_ aligned is cut off on header cell. The issue
>> is not only w.r.t to `JFileChooser` rather it is part of `JTable`. The root
>> caused is found to be that in metal L&F the border insets is set to
>> `(2,2,2,0)` m
On Mon, 24 Jul 2023 19:18:10 GMT, Alexey Ivanov wrote:
> That's exactly my concern: in other L&Fs `AccessibleJComboBox` handles the
> scenario yet in Aqua L&F it is handled by a different component which is not
> a problem okay per se. What is a problem is that retrieving the accessible
> name
On Mon, 24 Jul 2023 19:11:00 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> bugid removed in comments
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java line 34:
>
>> 3
On Thu, 20 Jul 2023 01:43:18 GMT, Sergey Bylokhov wrote:
> please double-check how it will work in Windows, it might be possible that
> jaws expects 1.
@mrserb I observed the difference in announcement with JAWS with the fix.
Since the magnifier is used only for macos, proposed fix is now hand
On Fri, 21 Jul 2023 19:51:26 GMT, Abhishek Kumar wrote:
> > @mrserb please double-check how it will work in Windows, it might be
> > possible that jaws expects 1.
>
> I will check this and update if there is any change in announcement with JAWS
> with this fix.
@mrserb I observed the differe
On Fri, 21 Jul 2023 19:42:00 GMT, Abhishek Kumar wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return
> The issue exist only for non-editable combobox and the root cause is
> accessible object is not created due to incorrect index returned from
> component class which results in no a11y API invoked.
>
> Proposed solution is to return the correct accessible child from
> getAccessibleChild method
On Tue, 25 Jul 2023 09:10:10 GMT, Alexey Ivanov wrote:
> > @aivanov-jdk, Thank you for your time and reviews, `CoInitializeEx(NULL,
> > 0)` also resolving this problem because as per document **The default is
> > COINIT_MULTITHREADED**.
>
> This is what I expected, however, the documentation fo
The function WideCharToMultiByte is used at a number of places of the JDK
codebase for conversion purposes.
Unfortunately, the function might fail because of various reasons, so the
return value must be checked to avoid undefined behavior or even crashes.
see
https://learn.microsoft.com/en-us/win
On Mon, 24 Jul 2023 09:20:44 GMT, Prasanta Sadhukhan
wrote:
> When a JFormattedTextField field value is set by setText, then when the field
> initially gains focus it seems to not use the edit formatter, but rather use
> display formatter, which is wrong.
> Native "Date and Time setting" in w
On Mon, 24 Jul 2023 09:58:09 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Disabled OLE1 from CoInit
>
> src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.c
On Thu, 20 Jul 2023 03:39:03 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded
>> invalid GUID and clipped description in windows(ID not found in registry).
>> With com initialization libr
On Mon, 24 Jul 2023 09:20:44 GMT, Prasanta Sadhukhan
wrote:
> When a JFormattedTextField field value is set by setText, then when the field
> initially gains focus it seems to not use the edit formatter, but rather use
> display formatter, which is wrong.
> Native "Date and Time setting" in w
On Mon, 24 Jul 2023 10:37:43 GMT, Aleksey Shipilev wrote:
> At least GCC 6 fail the build with warnings-as-errors here:
>
>
> ../src/java.desktop/share/native/libharfbuzz/hb-subset-plan.cc: In function
> 'void _collect_layout_variation_indices(hb_subset_plan_t*)':
> ../src/java.desktop/share/n
On Mon, 24 Jul 2023 10:37:43 GMT, Aleksey Shipilev wrote:
> At least GCC 6 fail the build with warnings-as-errors here:
>
>
> ../src/java.desktop/share/native/libharfbuzz/hb-subset-plan.cc: In function
> 'void _collect_layout_variation_indices(hb_subset_plan_t*)':
> ../src/java.desktop/share/n
On Mon, 24 Jul 2023 20:11:26 GMT, Alexey Ivanov wrote:
> > I think this patch would also address
> > https://bugs.openjdk.org/browse/JDK-7116070
>
> It didn't, the test case still produces truncated names.
>
> Although, the mixer name used for recording in the stand-alone test attached
> to [
22 matches
Mail list logo
