On Thu, 27 Jul 2023 00:16:34 GMT, Damon Nguyen wrote:
>> Please review this PR which contains the translations for updates to
>> localized resources in the JDK since RDP1.
>>
>> Included in this change are improved translations for certain values, which
>> also includes global updates for tran
On Thu, 27 Jul 2023 04:56:35 GMT, 极速蜗牛 wrote:
> Any updates?
Waiting for anyone to integrate...
-
PR Comment: https://git.openjdk.org/jdk/pull/13055#issuecomment-1652920990
On Thu, 16 Mar 2023 08:33:35 GMT, 柳鲲鹏 wrote:
>> Candidat box can moving with caret on windows version. Someone must wrote
>> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes.
>> Why it doesn't work, is the key problem.
>>
>> 1, I wrote a example for linux:
>> https:/
> The header border uses `g.drawLine` whereas the JTable data grid lines uses
> `SwingUtilities2.drawVLine` and `SwingUtilities2.drawHLine` to draw
> horizontal and vertical lines. The SwingUtilities2 uses `Graphics.fillRect`
> which contributes to the difference between the position of these tw
On Wed, 26 Jul 2023 07:15:56 GMT, Prasanta Sadhukhan
wrote:
> The issue here is a Reader(stream) is requested to handle a drop, via
> DataFlavor.getReaderForText(), and then the reader is completely read, but it
> isn't closed. It should be closed as soon as possible to release some native
>
> "size" label which is _RIGHT_ aligned is cut off on header cell. The issue is
> not only w.r.t to `JFileChooser` rather it is part of `JTable`. The root
> caused is found to be that in metal L&F the border insets is set to
> `(2,2,2,0)` meaning the right most inset value is 0. Hence when UISca
On Wed, 26 Jul 2023 17:28:23 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> test/jdk/javax/swing/JTableHeader/JTableHeaderLabelRightAlignTest.java line
> 96:
>
>> 94:
On Thu, 16 Mar 2023 08:33:35 GMT, 柳鲲鹏 wrote:
>> Candidat box can moving with caret on windows version. Someone must wrote
>> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes.
>> Why it doesn't work, is the key problem.
>>
>> 1, I wrote a example for linux:
>> https:/
> Hi Reviewers,
>
> Observations :
> 1. Without com initialize if we access Mixer for recording, library loaded
> invalid GUID and clipped description in windows(ID not found in registry).
> With com initialization library load proper GUID (same as registry).
> 2. For Play back device always loa
> Hi Reviewers,
>
> Observations :
> 1. Without com initialize if we access Mixer for recording, library loaded
> invalid GUID and clipped description in windows(ID not found in registry).
> With com initialization library load proper GUID (same as registry).
> 2. For Play back device always loa
> Please review the simple fix that changes start|stop_timer to static.
Jiangli Zhou has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains three additional co
On Tue, 25 Jul 2023 18:09:17 GMT, Jiangli Zhou wrote:
>> Please review the simple fix that changes start|stop_timer to static.
>
> Jiangli Zhou has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by
On Tue, 25 Jul 2023 18:09:17 GMT, Jiangli Zhou wrote:
>> Please review the simple fix that changes start|stop_timer to static.
>
> Jiangli Zhou has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by
On Wed, 26 Jul 2023 20:41:36 GMT, Justin Lu wrote:
> Please review this PR which contains the translations for updates to
> localized resources in the JDK since RDP1.
>
> Included in this change are improved translations for certain values, which
> also includes global updates for translations
On Wed, 26 Jul 2023 23:29:41 GMT, Sergey Bylokhov wrote:
>>> > > 3. Do another CoInitialize before call :- not a good approach
>>> >
>>> > Yet it does not break the rules: you can initialise COM, call an API and
>>> > then call
>>> > [`CoUninitialize`](https://learn.microsoft.com/en-us/window
On Wed, 26 Jul 2023 21:16:11 GMT, Alexey Ivanov wrote:
>>> > Probably… But it is still incorrect. Initialising COM on a thread doesn't
>>> > mean you can call COM object methods from any thread in your application.
>>>
>>> Note that "Objects created on a COM thread in a multithread apartment (M
On Mon, 24 Jul 2023 10:21:52 GMT, Aleksey Shipilev wrote:
> There is a simple build failure after
> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs:
>
>
> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o:
> In file included from
> /home/bui
On Wed, 26 Jul 2023 07:15:56 GMT, Prasanta Sadhukhan
wrote:
> The issue here is a Reader(stream) is requested to handle a drop, via
> DataFlavor.getReaderForText(), and then the reader is completely read, but it
> isn't closed. It should be closed as soon as possible to release some native
>
On Wed, 26 Jul 2023 21:14:07 GMT, Alexey Ivanov wrote:
>>> Probably… But it is still incorrect. Initialising COM on a thread doesn't
>>> mean you can call COM object methods from any thread in your application.
>>
>> Note that "Objects created on a COM thread in a multithread apartment (MTA)
>
On Wed, 26 Jul 2023 20:56:15 GMT, Sergey Bylokhov wrote:
> > Probably… But it is still incorrect. Initialising COM on a thread doesn't
> > mean you can call COM object methods from any thread in your application.
>
> Note that "Objects created on a COM thread in a multithread apartment (MTA)
>
On Tue, 25 Jul 2023 11:34:03 GMT, Renjith Kannath Pariyangad
wrote:
>>> @aivanov-jdk, Thank you for your time and reviews, `CoInitializeEx(NULL,
>>> 0)` also resolving this problem because as per document **The default is
>>> COINIT_MULTITHREADED**.
>>
>> This is what I expected, however, the
Please review this PR which contains the IPS translations for updates to
localized resources in the JDK since RDP1.
Included in this change are improved translations for certain values, which
also includes global updates for translations of the words 'annotation' and
'file' for zh_CN.
The foll
On Tue, 25 Jul 2023 04:27:47 GMT, Sergey Bylokhov wrote:
>> Please review the simple fix that changes start|stop_timer to static.
>
> I was thinking of asking you to see if there are any other variables or
> functions in this file that could be made static, but it looks like xx_timer
> are the
On Wed, 26 Jul 2023 11:29:22 GMT, Tejesh R wrote:
>> "size" label which is _RIGHT_ aligned is cut off on header cell. The issue
>> is not only w.r.t to `JFileChooser` rather it is part of `JTable`. The root
>> caused is found to be that in metal L&F the border insets is set to
>> `(2,2,2,0)` m
On Mon, 24 Jul 2023 10:21:52 GMT, Aleksey Shipilev wrote:
> There is a simple build failure after
> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs:
>
>
> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o:
> In file included from
> /home/bui
On Wed, 26 Jul 2023 12:05:13 GMT, Alexander Zvegintsev
wrote:
>> src/java.desktop/unix/native/libpipewire/include/spa/utils/defs.h line 62:
>>
>>> 60: # define SPA_FALLTHROUGH [[clang::fallthrough]];
>>> 61: #elif defined(__GNUC__) && __GNUC__ >= 7
>>> 62: # define SPA_FALLTHROUGH __attribute
On Wed, 26 Jul 2023 11:59:06 GMT, Matthias Baesken wrote:
>> In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels
>> we release some resources at the end of the function by calling
>> DeleteObject/DeleteDC. This is recommended by the MS API docs.
>> However this should b
On Mon, 24 Jul 2023 20:24:23 GMT, Phil Race wrote:
>> There is a simple build failure after
>> [JDK-8280982](https://bugs.openjdk.org/browse/JDK-8280982) with older GCCs:
>>
>>
>> * For target support_native_java.desktop_libawt_xawt_screencast_pipewire.o:
>> In file included from
>> /home/bui
> In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels
> we release some resources at the end of the function by calling
> DeleteObject/DeleteDC. This is recommended by the MS API docs.
> However this should be done as well in some early leaving with throw that can
> occu
On Wed, 26 Jul 2023 10:43:20 GMT, Matthias Baesken wrote:
> In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels
> we release some resources at the end of the function by calling
> DeleteObject/DeleteDC. This is recommended by the MS API docs.
> However this should be do
> The header border uses `g.drawLine` whereas the JTable data grid lines uses
> `SwingUtilities2.drawVLine` and `SwingUtilities2.drawHLine` to draw
> horizontal and vertical lines. The SwingUtilities2 uses `Graphics.fillRect`
> which contributes to the difference between the position of these tw
> "size" label which is _RIGHT_ aligned is cut off on header cell. The issue is
> not only w.r.t to `JFileChooser` rather it is part of `JTable`. The root
> caused is found to be that in metal L&F the border insets is set to
> `(2,2,2,0)` meaning the right most inset value is 0. Hence when UISca
On Wed, 26 Jul 2023 10:43:20 GMT, Matthias Baesken wrote:
> In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels
> we release some resources at the end of the function by calling
> DeleteObject/DeleteDC. This is recommended by the MS API docs.
> However this should be do
On Wed, 26 Jul 2023 08:13:25 GMT, Tejesh R wrote:
>> "size" label which is _RIGHT_ aligned is cut off on header cell. The issue
>> is not only w.r.t to `JFileChooser` rather it is part of `JTable`. The root
>> caused is found to be that in metal L&F the border insets is set to
>> `(2,2,2,0)` m
In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels we
release some resources at the end of the function by calling
DeleteObject/DeleteDC. This is recommended by the MS API docs.
However this should be done as well in some early leaving with throw that can
occur in this
> The header border uses `g.drawLine` whereas the JTable data grid lines uses
> `SwingUtilities2.drawVLine` and `SwingUtilities2.drawHLine` to draw
> horizontal and vertical lines. The SwingUtilities2 uses `Graphics.fillRect`
> which contributes to the difference between the position of these tw
On Wed, 26 Jul 2023 08:08:03 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JTableHeader/JTableHeaderLabelRightAlignTest.java line
>> 108:
>>
>>> 106: for (int i = 1; i < imgHeader.getHeight()-3; i++) {
>>> 107: for (int j = verticalLineCol; j < verticalLineCol + 1;
>>> j++)
On Tue, 25 Jul 2023 13:13:34 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Spacing fix
>
> test/jdk/javax/swing/JTableHeader/JTableHeaderLabelRightAlignTest.java line
> 76:
>
>> 74: };
>>
On Tue, 25 Jul 2023 12:50:35 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Spacing fix
>
> test/jdk/javax/swing/JTableHeader/JTableHeaderLabelRightAlignTest.java line
> 85:
>
>> 83: final
> "size" label which is _RIGHT_ aligned is cut off on header cell. The issue is
> not only w.r.t to `JFileChooser` rather it is part of `JTable`. The root
> caused is found to be that in metal L&F the border insets is set to
> `(2,2,2,0)` meaning the right most inset value is 0. Hence when UISca
The issue here is a Reader(stream) is requested to handle a drop, via
DataFlavor.getReaderForText(), and then the reader is completely read, but it
isn't closed. It should be closed as soon as possible to release some native
resources.
Fix is made to close the stream after it is being used
---
On Wed, 19 Jul 2023 10:58:58 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to deprecate for
>> removal the `-Xdebug` option and `-debug` option of the `java` command?
>> This addresses https://bugs.openjdk.org/browse/JDK-8227229.
>>
>> As noted in the JBS
42 matches
Mail list logo
