On Tue, 8 Aug 2023 19:52:08 GMT, Thomas Stuefe wrote:
>> I just checked and the value of the sentinel is ultimately the prvalue 88. I
>> don't know if we'd want to replace all the weird char usages here with
>> explicit values of 0 (and 88 for the sentinel). Maybe future reviews can
>> help wi
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
On Wed, 9 Aug 2023 04:00:03 GMT, Julian Waters wrote:
>> src/hotspot/os/windows/os_windows.cpp line 2888:
>>
>>> 2886: LONG WINAPI topLevelUnhandledExceptionFilter(struct
>>> _EXCEPTION_POINTERS* exceptionInfo) {
>>> 2887: if (!InterceptOSException) {
>>> 2888: DWORD exception_code =
>>>
On Wed, 9 Aug 2023 06:01:47 GMT, Tejesh R wrote:
>> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`.
>> Converting the `String `to `locale` before adding as command key fix the
>> issue.
>> I have verified the test in all other platforms and Look and Feel which has
>>
> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`.
> Converting the `String `to `locale` before adding as command key fix the
> issue.
> I have verified the test in all other platforms and Look and Feel which has
> option to create New Folder, results were fine. No regre
On Wed, 9 Aug 2023 05:11:45 GMT, Tejesh R wrote:
>>> Yeah @prrace , you are right. According to the bug, they want to change the
>>> locale mid-application. Meaning switching between locale mid-application,
>>> which seems to be wrong/not something to be done with existing flow. I
>>> understo
On Wed, 9 Aug 2023 04:41:23 GMT, Sergey Bylokhov wrote:
> Can we inject some code into the AquaComboBoxButton so it will know what name
> should be used if that button is used "inside" combobox?
I didn't get you.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussi
On Tue, 8 Aug 2023 11:31:33 GMT, Alexey Ivanov wrote:
>> Changing locale mid-application isn't something that seems like a good idea.
>> Is that really what they want - not sure the test is exactly about that.
>> Really I'm quite unclear as to whether the complaint is that some custom
>> resourc
On Tue, 25 Jul 2023 12:04:44 GMT, Abhishek Kumar wrote:
>> That's exactly my concern: in other L&Fs `AccessibleJComboBox` handles the
>> scenario yet in Aqua L&F it is handled by a different component which is not
>> a problem okay per se. What is a problem is that retrieving the accessible
>>
On Tue, 8 Aug 2023 20:53:19 GMT, Thomas Stuefe wrote:
> I think I see now that the added scopes were to prevent variable life scopes
> from intersecting goto's?
Yes, that's why
-
PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-1670618830
On Tue, 8 Aug 2023 19:56:24 GMT, Thomas Stuefe wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 22 additional
>> commits
Hello Aleksei, thank you for looking into this issue.
On 08/08/2023 22:04, Aleksei Ivanov wrote:
You may want to update your test case so that it generates icons on the
fly and uses numbers to easily distinguish one from another. You can get
code from WindowIconUpdateOnDPIChangingTest.java [1].
> 1) Used builder pattern
> 2) Tested AWT tests and it passed
lawrence.andrews has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 10 commits:
- Revert changes to PrintLatinCJKTest.java
- Refactor screen capture
Move creating sc
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
Hello Andrei,
You may want to update your test case so that it generates icons on the
fly and uses numbers to easily distinguish one from another. You can get
code from WindowIconUpdateOnDPIChangingTest.java [1].
You can read the commends in PR #6180 [2] where the test was added.
During the
On Mon, 7 Aug 2023 08:14:41 GMT, Julian Waters wrote:
>> There are currently only 2 possible types of HMODULE and char/uint8_t for T
>> at the moment. Weirdly enough only line 126 errors out without the cast
>> while line 114, despite having the same problem, doesn't, but I added the
>> cast t
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
Hello,
I've reported https://bugs.openjdk.org/browse/JDK-8313698 and, unfortunately,
there's some confusion in the ticket due to my poor choice of words for
describing the _default_ icon of the JFrame. The default icon depends on the
vendor of the JDK, and it isn't the Duke icon for all of them.
On Mon, 3 Jul 2023 17:15:17 GMT, Daniel Jeliński wrote:
> Please review this patch that configures C++ arguments on build jobs that
> involve compiling CPP files. As a result of this change, CPP files are
> compiled with `-std:c++14` command line argument instead of `-std:c11`, which
> is used
On Fri, 4 Aug 2023 18:34:31 GMT, Phil Race wrote:
>> I can see French resource files:
>> [`windows_fr.properties`](https://github.com/openjdk/jdk/blob/e8a37b90db8dca4dc3653970b2d66d2faf8ef452/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties);
>> t
On Fri, 28 Jul 2023 10:56:47 GMT, Tejesh R wrote:
> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`.
> Converting the `String `to `locale` before adding as command key fix the
> issue.
> I have verified the test in all other platforms and Look and Feel which has
> opti
On Fri, 28 Jul 2023 10:56:47 GMT, Tejesh R wrote:
> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`.
> Converting the `String `to `locale` before adding as command key fix the
> issue.
> I have verified the test in all other platforms and Look and Feel which has
> opti
23 matches
Mail list logo
