On Thu, 17 Aug 2023 05:22:54 GMT, Tejesh R wrote:
> Same observation holds for JTextField and hope other remaining two
> (SPINNER_TEXT_FIELD and FORMATTED_TEXT_FIELD) also, consolidating and finding
> a fix which applies to all four (TEXT_FIELD, PASSWORD_FIELD,
> SPINNER_TEXT_FIELD and FORMATT
On Wed, 2 Aug 2023 21:46:32 GMT, Harshitha Onkar wrote:
>> **Problem:**
>>
>> On macOS, Robot erroneously produces lowercase letter when mouse is moved
>> (manually) in unison with Robot's keyEvents. This issue was originally
>> logged by a developer of an on-screen accessibility keyboard - T
> This is referenced in Java Bug Database as
> - [JDK-8292276 : Add named colors from CSS Color Module Level
> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>
> This is tracked in JBS as
> - [JDK-8292276 : Add named colors from CSS Color Module Level
> 4](https://bugs.openjdk.ja
On Thu, 17 Aug 2023 18:59:40 GMT, Phil Race wrote:
>> As mentioned earlier in this review, you need to absorb the changes in
>> https://github.com/openjdk/jdk/pull/10317/
>> into THIS PR and withdraw 10317.
>
>> @prrace
>>
>> Do I absorb the changes in #15262 too ?
>
> I hadn't even seen that
On Mon, 14 Aug 2023 14:12:59 GMT, Alexander Zvegintsev
wrote:
>> Right now, each call to getPixelColor/createScreenCapture opens and closes a
>> ScreenCast session.
>> When there are many such calls in a row, it becomes a rather time-consuming
>> operation.
>>
>> For example,
>>
>>
>> for
On Thu, 17 Aug 2023 18:59:40 GMT, Phil Race wrote:
>> As mentioned earlier in this review, you need to absorb the changes in
>> https://github.com/openjdk/jdk/pull/10317/
>> into THIS PR and withdraw 10317.
>
>> @prrace
>>
>> Do I absorb the changes in #15262 too ?
>
> I hadn't even seen that
On Thu, 17 Aug 2023 21:50:02 GMT, Phil Race wrote:
>> * The doPrivileged block is added to fix SecurityException
>> * The usage of the property moved to static, now the "change" of the
>> property at runtime will not affect the code
>
> Marked as reviewed by prr (Reviewer).
@prrace thank you!
On Sat, 22 Jul 2023 21:45:36 GMT, Sergey Bylokhov wrote:
> * The doPrivileged block is added to fix SecurityException
> * The usage of the property moved to static, now the "change" of the
> property at runtime will not affect the code
Marked as reviewed by prr (Reviewer).
-
PR R
On Thu, 17 Aug 2023 21:42:04 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/font/FontScaling/StretchedFontTest.java line 107:
>>
>>> 105: final Dimension size = getTextSize(font);
>>> 106: final BufferedImage image =
>>> 107: new BufferedImage(size.width, size.hei
On Thu, 17 Aug 2023 21:10:36 GMT, Sergey Bylokhov wrote:
>> **Problem**
>>
>> Glyphs aren't stretched by applying an affine transform `scale(2, 1)` to a
>> font. Instead, the space between glyphs increases.
>>
>> **Root Cause**
>>
>> Bitmaps embedded in the font are used to render the glyphs;
On Mon, 31 Jul 2023 10:26:44 GMT, Alexey Ivanov wrote:
> The private field `mask` is never used in `JFormattedTextField`.
>
> I couldn't find any usages of the field, including JNI. Therefore, it is safe
> to remove.
Marked as reviewed by prr (Reviewer).
-
PR Review: https://git.
On Thu, 20 Apr 2023 05:47:35 GMT, Ichiroh Takiguchi
wrote:
> "character set of font" (font charset) table was created by "Rich Text Format
> Specification 1.9.1"
> https://interoperability.blob.core.windows.net/files/Archive_References/[MSFT-RTF].pdf
> It refers windgi.h
> https://learn.microso
On Sat, 5 Aug 2023 19:13:20 GMT, Alexey Ivanov wrote:
> Replace the GIF image of `BoxLayout` example with an SVG one which renders
> crisp on all the displays, including High DPI ones.
>
> Compare the images:
>
> *
> [`BoxLayout`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desk
On Mon, 7 Aug 2023 19:43:38 GMT, Alexey Ivanov wrote:
> A clean-up of documentation for
> [`BoxLayout`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/BoxLayout.html#class-description):
>
> 1. Use the `` element instead of `` to list layout options or
> axes.
> 2.
On Thu, 17 Aug 2023 21:19:17 GMT, Phil Race wrote:
>> test/jdk/java/awt/font/FontScaling/StretchedFontTest.java line 50:
>>
>>> 48: /*
>>> 49: * @test
>>> 50: * @key headful
>>
>> I don't see anything in this test that requires headful.
>
> Ah, I see you wrote
> "The test could be headless, b
On Thu, 17 Aug 2023 20:55:29 GMT, Phil Race wrote:
>> **Problem**
>>
>> Glyphs aren't stretched by applying an affine transform `scale(2, 1)` to a
>> font. Instead, the space between glyphs increases.
>>
>> **Root Cause**
>>
>> Bitmaps embedded in the font are used to render the glyphs; the b
On Thu, 17 Aug 2023 20:43:59 GMT, Alexey Ivanov wrote:
> **Problem**
>
> Glyphs aren't stretched by applying an affine transform `scale(2, 1)` to a
> font. Instead, the space between glyphs increases.
>
> **Root Cause**
>
> Bitmaps embedded in the font are used to render the glyphs; the bitma
On Thu, 20 Apr 2023 05:47:35 GMT, Ichiroh Takiguchi
wrote:
> "character set of font" (font charset) table was created by "Rich Text Format
> Specification 1.9.1"
> https://interoperability.blob.core.windows.net/files/Archive_References/[MSFT-RTF].pdf
> It refers windgi.h
> https://learn.microso
On Thu, 17 Aug 2023 20:43:59 GMT, Alexey Ivanov wrote:
> **Problem**
>
> Glyphs aren't stretched by applying an affine transform `scale(2, 1)` to a
> font. Instead, the space between glyphs increases.
>
> **Root Cause**
>
> Bitmaps embedded in the font are used to render the glyphs; the bitma
**Problem**
Glyphs aren't stretched by applying an affine transform `scale(2, 1)` to a
font. Instead, the space between glyphs increases.
**Root Cause**
Bitmaps embedded in the font are used to render the glyphs; the bitmaps aren't
transformed, so white-space is seen which fills the requested
On Wed, 16 Aug 2023 18:23:59 GMT, Harshitha Onkar wrote:
> JToolBar test - bug4529206.java was failing intermittently on Linux. It was
> due to timing issue. Added appropriate delay to fix the issue.
>
> CI Testing passes on all platforms.
This pull request has now been integrated.
Changeset:
On Thu, 17 Aug 2023 15:22:12 GMT, Alexey Ivanov wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However, JScrollBar over
On Thu, 17 Aug 2023 18:27:27 GMT, Phil Race wrote:
>> Hi, guys! I want to notice that JetBrains is working on the issue too and
>> we're going to propose our own fix.
>
> @NikitkoCent you wrote "Hi, guys! I want to notice that JetBrains is working
> on the issue too and we're going to propose o
On Thu, 16 Mar 2023 08:33:35 GMT, 柳鲲鹏 wrote:
>> Candidat box can moving with caret on windows version. Someone must wrote
>> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes.
>> Why it doesn't work, is the key problem.
>>
>> 1, I wrote a example for linux:
>> https:/
On Thu, 17 Aug 2023 08:42:13 GMT, Prasanta Sadhukhan
wrote:
> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>
> "Sets the minimum size of this component to a constant value. Subsequent
> calls to getMinimumSize will always return this value..."
>
> However, JScrollBar over
On Thu, 17 Aug 2023 18:09:26 GMT, Phil Race wrote:
>> ScientificWare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> StyleSheet.java : Adds missing space in some if statements
>
> As mentioned earlier in this review, you need to absorb t
On Thu, 17 Aug 2023 18:09:26 GMT, Phil Race wrote:
>> ScientificWare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> StyleSheet.java : Adds missing space in some if statements
>
> As mentioned earlier in this review, you need to absorb t
On Tue, 16 May 2023 17:56:04 GMT, Artem Semenov wrote:
>> This enhancement covers basic API and shared code that should be implemented
>> for the Accessibility Announcement feature.
>>
>> CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499
>> "bugs.openjdk.org")
>>
>> @mrserb @prrac
On Thu, 17 Aug 2023 18:02:01 GMT, Phil Race wrote:
>> ScientificWare has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 30 commits:
>>
>> - Merge branch 'openjdk:master' into
>> scientificware-patch-003-CSS-add_4_8_digits_hex_coded
On Thu, 17 Aug 2023 18:09:26 GMT, Phil Race wrote:
>> ScientificWare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> StyleSheet.java : Adds missing space in some if statements
>
> As mentioned earlier in this review, you need to absorb t
On Wed, 28 Jun 2023 21:46:30 GMT, Nikita Provotorov wrote:
>> 柳鲲鹏 has refreshed the contents of this pull request, and previous commits
>> have been removed. Incremental views are not available. The pull request now
>> contains one commit:
>>
>> 8264728: When use chinese IME, the candidate b
On Wed, 16 Aug 2023 09:06:53 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level
>> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>>
>> This is tracked in JBS as
>> - [JDK-8292276 : Add named
On Wed, 16 Aug 2023 09:55:40 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded
>> Color](https://bugs.java.com/bugdatabase/view_bug?bug_id=8293776)
>>
>> This is tracked in JBS as
>> - [JDK-8293776 : Adds CSS 4 and 8
On Thu, 17 Aug 2023 08:42:13 GMT, Prasanta Sadhukhan
wrote:
> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>
> "Sets the minimum size of this component to a constant value. Subsequent
> calls to getMinimumSize will always return this value..."
>
> However, JScrollBar over
javadoc contract for JComponent.setMinimumSize(Dimension) states:
"Sets the minimum size of this component to a constant value. Subsequent calls
to getMinimumSize will always return this value..."
However, JScrollBar overrides getMinimumSize() and breaks this contract - it
always returns a mini
On Thu, 17 Aug 2023 08:38:01 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less acceptin
> We should set the -permissive- flag for the Microsoft Visual C compiler, as
> was requested by the now backed out
> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
> the Visual C compiler much less accepting of ill formed code, which will
> improve code quality on W
37 matches
Mail list logo
