On Tue, 12 Sep 2023 05:46:23 GMT, Tejesh R wrote:
> Open source these Swing JSpinner related tests:
>
> javax/swing/JSpinner/4522737/bug4522737.java
> javax/swing/JSpinner/4656590/bug4656590.java
> javax/swing/JSpinner/4680204/bug4680204.java
> javax/swing/JSpinner/4862257/bug4862257.java
> java
On Tue, 12 Sep 2023 00:48:18 GMT, Harshitha Onkar wrote:
>> This PR open sources few Swing Text/HTML related tests.
>
> Harshitha Onkar has updated the pull request incrementally with one
> additional commit since the last revision:
>
> minor changes
Marked as reviewed by psadhukhan (Reviewe
On Tue, 12 Sep 2023 21:32:58 GMT, Harshitha Onkar wrote:
> Open sourcing the following tests -
>
> 1. javax/swing/text/CompositeView/4398059/bug4398059.java
> 2. javax/swing/text/DefaultCaret/4197894/bug4197894.java
> 3. javax/swing/text/DefaultCaret/4203175/bug4203175.java
> 4. javax/swing/text
On Fri, 8 Sep 2023 11:29:36 GMT, Prasanta Sadhukhan
wrote:
> Some closed awt tests are opensourced
This pull request has now been integrated.
Changeset: a36f5a54
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/commit/a36f5a54ab4871739f2ccbabb684942fc3cadf20
Stats: 26
On Mon, 11 Sep 2023 05:44:27 GMT, Prasanta Sadhukhan
wrote:
>> Some closed awt tests are opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Test resource
Marked as reviewed by jdv (Reviewer).
-
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote:
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of files changed
> are local
On Mon, 11 Sep 2023 15:36:56 GMT, Alexey Ivanov wrote:
> This enhances the `Builder` pattern added in
> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method
> `testUI` which allows passing a lambda expression or a method reference to
> create *the test UI window*.
>
>
JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
would improve readability to see the native characters instead of escape
sequences (especially for the L10n process). The majority of files changed are
localized resource files.
This change converts the Unicode escape
> Some closed AWT test are open sourced.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
fix path
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15671/files
- new: https://git.openjdk.org/jdk/pull/15671/f
On Tue, 12 Sep 2023 20:26:42 GMT, Alexey Ivanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> spacing
>
> test/jdk/java/awt/Choice/ChoiceSelectTest.java line 39:
>
>> 37:
>> 38: public class ChoiceSelec
> Some closed AWT test are open sourced.
Alexander Zvegintsev has updated the pull request incrementally with two
additional commits since the last revision:
- review comments
- combine PathHitTest and PathHitTestManual into one test.
-
Changes:
- all: https://git.openjdk.org/j
Open sourcing the following tests -
1. javax/swing/text/CompositeView/4398059/bug4398059.java
2. javax/swing/text/DefaultCaret/4197894/bug4197894.java
3. javax/swing/text/DefaultCaret/4203175/bug4203175.java
4. javax/swing/text/DefaultEditorKit/4265242/bug4265242.java
5. javax/swing/text/DefaultSt
On Tue, 12 Sep 2023 12:26:38 GMT, Alexander Zvegintsev
wrote:
>> Some closed AWT test are open sourced.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> spacing
Changes requested by aivanov (Reviewer).
test/jdk/ja
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Fri, 1 Sep 2023 20:32:42 GMT, Andrey Turbanov wrote:
>> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8312165: Fix typos in java.desktop Sw
On Tue, 12 Sep 2023 18:41:23 GMT, Alexander Zvegintsev
wrote:
>>> Sometimes we may need to create more than one window(e.g. some DnD test
>>> with two windows). Perhaps we should consider that here by adding
>>> `List createTestUI()`.
>>
>> I thought about it. Yet I couldn't find a simple sce
On Tue, 12 Sep 2023 13:37:09 GMT, Alexey Ivanov wrote:
> However, to test this case I'll need a (simple) scenario where multiple
> windows are created.
For example
`test/jdk/java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_2.java`
is not converted to use PassFailJFrame, but shows
Following tests are being open sourced as part of this PR.
javax/swing/text/html/HTMLDocument/4251593/bug4251593.java
javax/swing/text/html/HTMLDocument/4687405/bug4687405.java
javax/swing/text/html/HTMLDocument/4226914/bug4226914.java
javax/swing/text/html/HTMLEditorKit/4213373/bug4213373.java
-
> To demonstrate the functionality of HTML formatting in `PassFailJFrame`, I
> updated the instructions for the
> `test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java` test. The
> commands to create the symbolic links are marked up with monospace font,
> which makes them stand out. Th
On Tue, 12 Sep 2023 12:34:12 GMT, Christopher Sahnwaldt
wrote:
>> In
>> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
>> the weak reference was accidentally changed from a field to a local
>> variable, which means that the PropertyChangeListener keeps a strong
On Sun, 30 Jul 2023 12:50:58 GMT, Christopher Sahnwaldt
wrote:
> In
> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
> the weak reference was accidentally changed from a field to a local
> variable, which means that the PropertyChangeListener keeps a strong
>
On Tue, 12 Sep 2023 13:49:41 GMT, Alexander Zvegintsev
wrote:
>>> Probably `trim()` and `toLowerCase()` could be useful here.
>>
>> Could be… On the other hand, in post XHTML era, the elements are usually in
>> lower-case. Thus we should stick with it and use lowercase HTML elements
>> anyway
On Tue, 12 Sep 2023 11:28:36 GMT, Abhishek Kumar wrote:
>> Few closed JFileChooser and other swing tests are open sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment update
Marked as reviewed by tr (C
On Tue, 12 Sep 2023 13:15:26 GMT, Alexey Ivanov wrote:
> Could be… On the other hand, in post XHTML era, the elements are usually in
> lower-case. Thus we should stick with it and use lowercase HTML elements
> anyway.
https://www.w3schools.com/html/html_elements.asp
> HTML is Not Case Sensiti
On Mon, 11 Sep 2023 13:11:10 GMT, Alexey Ivanov wrote:
> This enhancement provides HTML formatting for instructions in the manual test
> framework, `PassFailJFrame`.
>
> Some tests could benefit from rich-formatted instructions, especially when
> the instructions are long.
>
> See a sample us
On Tue, 12 Sep 2023 13:06:02 GMT, Alexander Zvegintsev
wrote:
> Shouldn't we mention here a window added by `testUI` via builder?
I don't think it's necessary: the builder uses `addTestWindow` under the hood.
It's the builder that requires documentation.
In fact, the entire class requires a b
On Tue, 12 Sep 2023 13:04:09 GMT, Alexander Zvegintsev
wrote:
> Sometimes we may need to create more than one window(e.g. some DnD test with
> two windows). Perhaps we should consider that here by adding `List
> createTestUI()`.
I thought about it. Yet I couldn't find a simple scenario where
On Tue, 12 Sep 2023 12:44:34 GMT, Alexander Zvegintsev
wrote:
> Probably `trim()` and `toLowerCase()` could be useful here.
Could be… On the other hand, in post XHTML era, the elements are usually in
lower-case. Thus we should stick with it and use lowercase HTML elements anyway.
I think `sta
On Mon, 11 Sep 2023 15:36:56 GMT, Alexey Ivanov wrote:
> This enhances the `Builder` pattern added in
> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method
> `testUI` which allows passing a lambda expression or a method reference to
> create *the test UI window*.
>
>
On Mon, 11 Sep 2023 13:11:10 GMT, Alexey Ivanov wrote:
> This enhancement provides HTML formatting for instructions in the manual test
> framework, `PassFailJFrame`.
>
> Some tests could benefit from rich-formatted instructions, especially when
> the instructions are long.
>
> See a sample us
On Tue, 12 Sep 2023 12:34:12 GMT, Christopher Sahnwaldt
wrote:
>> In
>> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
>> the weak reference was accidentally changed from a field to a local
>> variable, which means that the PropertyChangeListener keeps a strong
> In
> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
> the weak reference was accidentally changed from a field to a local
> variable, which means that the PropertyChangeListener keeps a strong
> reference to executorService, which is a resource leak
Christophe
On Tue, 12 Sep 2023 08:44:35 GMT, Andrey Turbanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> spacing
>
> test/jdk/java/awt/Focus/TestWindowsLFFocus.java line 103:
>
>> 101: SwingUtilities.
> Some closed AWT test are open sourced.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
spacing
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15671/files
- new: https://git.openjdk.org/jdk/pull/15671/fi
On Mon, 11 Sep 2023 09:42:36 GMT, Prasanta Sadhukhan
wrote:
> Few awt problem listed tests are placed in swing category which should be
> amended
This pull request has now been integrated.
Changeset: 8b4f9a88
Author:Prasanta Sadhukhan
URL:
https://git.openjdk.org/jdk/commit/8b4f9a
On Tue, 12 Sep 2023 08:26:59 GMT, Matthias Baesken wrote:
> So could we remove the existing PrivilegedAction in getCompilerName ?
Wouldn't that break ManagementFactory.getCompilationMXBean?
-
PR Comment: https://git.openjdk.org/jdk/pull/15629#issuecomment-1715570499
On Tue, 12 Sep 2023 05:04:56 GMT, Tejesh R wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment update
>
> test/jdk/javax/swing/JFileChooser/bug4624353.java line 59:
>
>> 57: passAround
> Few closed JFileChooser and other swing tests are open sourced.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Review comment update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15626/files
- new: https://
> In
> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
> the weak reference was accidentally changed from a field to a local
> variable, which means that the PropertyChangeListener keeps a strong
> reference to executorService, which is a resource leak
Christophe
On Tue, 12 Sep 2023 05:03:36 GMT, Tejesh R wrote:
>> Few closed JFileChooser and other swing tests are open sourced.
>
> test/jdk/javax/swing/JFileChooser/bug4624353.java line 55:
>
>> 53: fr.getContentPane().add(fc);
>> 54: fr.pack();
>> 55: fr.se
> In
> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
> the weak reference was accidentally changed from a field to a local
> variable, which means that the PropertyChangeListener keeps a strong
> reference to executorService, which is a resource leak
Christophe
On Sun, 30 Jul 2023 12:50:58 GMT, Christopher Sahnwaldt
wrote:
> In
> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
> the weak reference was accidentally changed from a field to a local
> variable, which means that the PropertyChangeListener keeps a strong
>
On Sun, 30 Jul 2023 12:50:58 GMT, Christopher Sahnwaldt
wrote:
> In
> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
> the weak reference was accidentally changed from a field to a local
> variable, which means that the PropertyChangeListener keeps a strong
>
On Tue, 12 Sep 2023 03:37:07 GMT, Prasanta Sadhukhan
wrote:
>> Few awt problem listed tests are placed in swing category which should be
>> amended
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> PL amend
Marked as
On Tue, 12 Sep 2023 03:32:04 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/ProblemList.txt line 471:
>>
>>> 469: java/awt/Mixing/AWT_Mixing/OpaqueOverlapping.java 8294264 windows-x64
>>> 470:
>>> 471: java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java
>>> 8288839 windows-x64
>>
On Mon, 11 Sep 2023 22:18:51 GMT, Alexander Zvegintsev
wrote:
> Some closed AWT test are open sourced.
test/jdk/java/awt/Focus/TestWindowsLFFocus.java line 103:
> 101: SwingUtilities.invokeAndWait(() -> {
> 102: Point location = new Point(frameLoc);
> 103:
On Mon, 11 Sep 2023 22:18:51 GMT, Alexander Zvegintsev
wrote:
> Some closed AWT test are open sourced.
Marked as reviewed by psadhukhan (Reviewer).
test/jdk/java/awt/Component/Displayable.java line 98:
> 96: f.add("North", test);
> 97: f.pack();
> 98: f.dis
On Fri, 8 Sep 2023 13:02:07 GMT, Alan Bateman wrote:
> > So probably we could avoid changing VMManagementImpl.java because it is not
> > needed any more at least in jdk-head .
>
> It's a JDK internal class so should never have been used directly. I can't
> imagine what might be using a JDK int
On Fri, 8 Sep 2023 14:01:24 GMT, Alexey Ivanov wrote:
> > So what about FontConfiguration? Is that something using the class directly
> > too?
>
> I think this is not needed either. As far as I can see, the instance of
> `FontConfiguration` is created from `doPrivileged`, therefore these two
50 matches
Mail list logo
