On Wed, 20 Sep 2023 05:58:11 GMT, Abhishek Kumar wrote:
>> Few closed JButton swing manual test converted to automated and open sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed unused robot instance
Chang
On Mon, 18 Sep 2023 21:20:29 GMT, Alexander Zvegintsev
wrote:
>> Open sourcing few tests:
>>
>> java/awt/Frame/FrameRepackTest.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
>> java/awt/Frame/WindowMoveTest.java
>
> Alexand
> Few closed JButton swing manual test converted to automated and open sourced.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Removed unused robot instance
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15835/f
On Wed, 20 Sep 2023 00:57:57 GMT, Alisen Chung wrote:
> Opening some swing tests:
> 1 javax/swing/LayoutComparator/4907772/bug4907772.java
> 2 javax/swing/LayoutComparator/4979794/bug4979794.java
> 3 javax/swing/LegacyGlueFocusTraversalPolicy/4765272/bug4765272.java
> 4 javax/swing/RootPaneChecki
On Wed, 20 Sep 2023 05:29:30 GMT, Abhishek Kumar wrote:
> Few closed JButton swing manual test converted to automated and open sourced.
test/jdk/javax/swing/JButton/bug4234034.java line 41:
> 39: static JFrame frame;
> 40: static JButton button;
> 41: static Robot robot;
Can remove
Few closed JButton swing manual test converted to automated and open sourced.
-
Commit messages:
- Opensource JButton manual tests
Changes: https://git.openjdk.org/jdk/pull/15835/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15835&range=00
Issue: https://bugs.openjdk.org
On Mon, 18 Sep 2023 21:35:01 GMT, Alexander Zvegintsev
wrote:
> Open sourcing several MenuBar manual tests
>
> java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_1.java
> java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_2.java
> java/awt/MenuBar/AddRemoveMenuBarTests/AddRemo
On Tue, 19 Sep 2023 16:58:10 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JTree/4696499/bug4696499.java
>> javax/swing/JTree/5039542/bug5039542.java
>> javax/swing/JViewport/4546474/bug4546474.java
>> javax/swing/JViewport/4677611/bug4677611.java
>> javax/sw
On Wed, 20 Sep 2023 03:25:25 GMT, Abhishek Kumar wrote:
> Few closed JButton swing manual test converted to automated and open sourced.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/15831
On Wed, 20 Sep 2023 03:25:25 GMT, Abhishek Kumar wrote:
> Few closed JButton swing manual test converted to automated and open sourced.
test/jdk/javax/swing/JPopupMenu/bug4197019.java line 47:
> 45: public class bug4197019 {
> 46: static volatile JMenuItem mi1;
> 47: static volatile JMe
On Wed, 20 Sep 2023 03:25:25 GMT, Abhishek Kumar wrote:
> Few closed JButton swing manual test converted to automated and open sourced.
test/jdk/javax/swing/JButton/bug4234034.java line 41:
> 39: static JFrame frame;
> 40: static JButton button;
> 41: static Robot robot;
static `ro
On Tue, 19 Sep 2023 16:58:10 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JTree/4696499/bug4696499.java
>> javax/swing/JTree/5039542/bug5039542.java
>> javax/swing/JViewport/4546474/bug4546474.java
>> javax/swing/JViewport/4677611/bug4677611.java
>> javax/sw
Few closed JButton swing manual test converted to automated and open sourced.
-
Commit messages:
- Opensource JButton manual tests
- Open source few swing JFormattedTextField and JPopupMenu tests
Changes: https://git.openjdk.org/jdk/pull/15831/files
Webrev: https://webrevs.openjdk
> Open sourcing few applet tests:
>
> java/awt/ScrollPane/ScrollPaneTest.java
> java/awt/TextArea/Length.java
> java/awt/Window/WindowOwner.java
> java/awt/font/Rotate/RotateTest3.java
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revis
> Open sourcing several manual applet tests
>
>
> test/jdk/java/awt/Frame/DefaultSizeTest.java
> test/jdk/java/awt/LightweightComponent/LightweightCliprect.java
> test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java
> test/jdk/javax/swing/JFrame/DefaultCloseOperation.java
Alexander Zvegintsev h
On Tue, 19 Sep 2023 22:07:59 GMT, Harshitha Onkar wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> FunctionKeyTest converted to automated
>
> test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java line 50:
>
Opening some swing tests:
1 javax/swing/LayoutComparator/4907772/bug4907772.java
2 javax/swing/LayoutComparator/4979794/bug4979794.java
3 javax/swing/LegacyGlueFocusTraversalPolicy/4765272/bug4765272.java
4 javax/swing/RootPaneChecking/RootPaneChecking.java
-
Commit messages:
- movin
On Thu, 14 Sep 2023 20:18:26 GMT, Alexander Zvegintsev
wrote:
> Open sourcing few applet tests:
>
> java/awt/ScrollPane/ScrollPaneTest.java
> java/awt/TextArea/Length.java
> java/awt/Window/WindowOwner.java
> java/awt/font/Rotate/RotateTest3.java
LGTM
test/jdk/java/awt/font/Rotate/RotateTest3
On Tue, 19 Sep 2023 21:36:14 GMT, Harshitha Onkar wrote:
>> Open sourcing few applet tests:
>>
>> java/awt/ScrollPane/ScrollPaneTest.java
>> java/awt/TextArea/Length.java
>> java/awt/Window/WindowOwner.java
>> java/awt/font/Rotate/RotateTest3.java
>
> test/jdk/java/awt/TextArea/Length.java line
On Tue, 19 Sep 2023 20:52:41 GMT, Alexander Zvegintsev
wrote:
> Open sourcing several manual applet tests
>
>
> test/jdk/java/awt/Frame/DefaultSizeTest.java
> test/jdk/java/awt/LightweightComponent/LightweightCliprect.java
> test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java
> test/jdk/java
On Wed, 6 Sep 2023 19:16:22 GMT, Alexey Ivanov wrote:
>> lawrence.andrews has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed the unused import statement and comma
>
> test/jdk/java/awt/print/Dialog/DialogType.java line 54:
>
>> 52:
On Wed, 6 Sep 2023 01:00:17 GMT, lawrence.andrews wrote:
>> Test was failing with "test result: Error. Parse Exception: Arguments to
>> `manual' option not supported: yesno"
>> Following are fixed
>> 1) Removed yesno
>> 2) Used PassFailJFrame manual test framework to show the test instruction
On Thu, 14 Sep 2023 20:18:26 GMT, Alexander Zvegintsev
wrote:
> Open sourcing few applet tests:
>
> java/awt/ScrollPane/ScrollPaneTest.java
> java/awt/TextArea/Length.java
> java/awt/Window/WindowOwner.java
> java/awt/font/Rotate/RotateTest3.java
test/jdk/java/awt/TextArea/Length.java line 30:
On Wed, 23 Aug 2023 00:42:47 GMT, Sergey Bylokhov wrote:
> This patch addresses two issues:
> * For Windows: The snprintf is available with Visual Studio 2015 and above,
> so we do not need to use the windows speciific "_snprintf". We also do not
> need to set a zero at the end of the string s
On Tue, 19 Sep 2023 13:41:27 GMT, Alexey Ivanov wrote:
> **Root cause**
>
> The _Baekmuk Headline_ font maps `\u6f22` (漢) to glyph id 16950 which has
> zero length.
>
> The test fails if the right half of the image with the rendered glyph
> contains only pixels of background colour. In this c
On Tue, 12 Sep 2023 08:21:35 GMT, Matthias Baesken wrote:
> > > So what about FontConfiguration? Is that something using the class
> > > directly too?
> >
> >
> > I think this is not needed either. As far as I can see, the instance of
> > `FontConfiguration` is created from `doPrivileged`, th
Open sourcing several manual applet tests
test/jdk/java/awt/Frame/DefaultSizeTest.java
test/jdk/java/awt/LightweightComponent/LightweightCliprect.java
test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java
test/jdk/javax/swing/JFrame/DefaultCloseOperation.java
-
Commit messages:
- i
On Tue, 19 Sep 2023 13:41:27 GMT, Alexey Ivanov wrote:
> **Root cause**
>
> The _Baekmuk Headline_ font maps `\u6f22` (漢) to glyph id 16950 which has
> zero length.
>
> The test fails if the right half of the image with the rendered glyph
> contains only pixels of background colour. In this c
On Fri, 15 Sep 2023 19:35:15 GMT, Harshitha Onkar wrote:
> Following tests are open sourced as part of this PR.
>
> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
> 4. test/jdk/
On Sat, 16 Sep 2023 16:22:40 GMT, Andrey Turbanov wrote:
> PR with non-swing changes extracted from initial #14847
Marked as reviewed by prr (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15773#pullrequestreview-1634160520
> Following tests are open sourced as part of this PR.
>
> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
> 4. test/jdk/javax/swing/text/html/CSS/bug4764897.java
> 5. test/jdk/jav
PR with non-swing changes extracted from initial #14847
-
Commit messages:
- [PATCH] Fix typos in java.desktop
- [PATCH] Fix typos in java.desktop
Changes: https://git.openjdk.org/jdk/pull/15773/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15773&range=00
Issue: https:/
On Mon, 18 Sep 2023 06:19:05 GMT, Arno Zeller wrote:
> The test fails on newer SLES versions that have RobotoSlab-Regular.ttf as
> default font. I suggest to try getting a DejaVu font as default on Linux
> because it is known to work without issues.
Sounds like (1) we don't have any reasonable
On Tue, 19 Sep 2023 19:54:01 GMT, Damon Nguyen wrote:
>> test/jdk/javax/swing/JTree/bug4696499.java line 49:
>>
>>> 47: try {
>>> 48: SwingUtilities.invokeAndWait(() -> {
>>> 49: fr = new JFrame("bug4696499");
>>
>> I guess frame is not needed and can be made
On Tue, 19 Sep 2023 07:33:11 GMT, Prasanta Sadhukhan
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments changes
>
> test/jdk/javax/swing/JTree/bug4696499.java line 49:
>
>> 47: try {
>> 48:
On Tue, 19 Sep 2023 18:35:12 GMT, Phil Race wrote:
>> Refactored timeout handling in PassFailJFrame:
>>
>> 1. Managing the timer and formatting the time left is inside
>> `TimeoutHandler` class.
>> 2. The class handles timer events and updates the label accordingly.
>>
>> This is implemented o
On Thu, 14 Sep 2023 18:45:34 GMT, Harshitha Onkar wrote:
> Following tests are open sourced as part of this PR.
>
> 1. java/awt/event/PaintEvent/RepaintTest/RepaintTest.java
> 2. javax/swing/text/html/HTMLEditorKit/4214848/bug4214848.java
> 3. javax/swing/text/html/HTMLEditorKit/4230197/bug42301
On Tue, 12 Sep 2023 15:27:18 GMT, Alexey Ivanov wrote:
>> To demonstrate the functionality of HTML formatting in `PassFailJFrame`, I
>> updated the instructions for the
>> `test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java` test. The
>> commands to create the symbolic links are mar
On Mon, 11 Sep 2023 18:18:28 GMT, Alexey Ivanov wrote:
> Refactored timeout handling in PassFailJFrame:
>
> 1. Managing the timer and formatting the time left is inside `TimeoutHandler`
> class.
> 2. The class handles timer events and updates the label accordingly.
>
> This is implemented on t
On Thu, 14 Sep 2023 16:43:29 GMT, Damon Nguyen wrote:
> These are the tests being converted:
>
> javax/swing/JToolBar/4138694/bug4138694.java
> javax/swing/JToolBar/4140421/bug4140421.java
> javax/swing/JToolBar/4196662/bug4196662.java
> javax/swing/JToolBar/4243930/bug4243930.java
This pull re
On Tue, 19 Sep 2023 17:04:59 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4138694/bug4138694.java
>> javax/swing/JToolBar/4140421/bug4140421.java
>> javax/swing/JToolBar/4196662/bug4196662.java
>> javax/swing/JToolBar/4243930/bug4243930.java
>
> Dam
On Tue, 19 Sep 2023 10:18:32 GMT, Alexey Ivanov wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update constant name
>
> test/jdk/javax/swing/JToolBar/bug4243930.java line 47:
>
>> 45:
>> 46: public static vo
On Thu, 14 Sep 2023 18:52:09 GMT, Alexey Ivanov wrote:
>> The image in the [documentation for
>> `Document.remove`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/text/Document.html#remove(int,int))
>> looks as if the portion between the offsets 6 and 10 is removed.
On Tue, 19 Sep 2023 17:49:19 GMT, Damon Nguyen wrote:
>> This is to convert and open source test:
>> javax/swing/JToolBar/4203039/bug4203039.java
>>
>> This manual test now uses PassFailJFrame to handle the display for the
>> instructions text as well as the pass/fail buttons.
>
> Damon Nguye
On Tue, 19 Sep 2023 00:27:28 GMT, Harshitha Onkar wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments changes
>
> test/jdk/javax/swing/JToolBar/bug4203039.java line 47:
>
>> 45: "installed
> This is to convert and open source test:
> javax/swing/JToolBar/4203039/bug4203039.java
>
> This manual test now uses PassFailJFrame to handle the display for the
> instructions text as well as the pass/fail buttons.
Damon Nguyen has updated the pull request incrementally with one additional
On Tue, 19 Sep 2023 17:02:54 GMT, Harshitha Onkar wrote:
>> Following tests are open sourced as part of this PR.
>>
>> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
>> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
>> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
>> 4. tes
On Mon, 14 Aug 2023 18:03:21 GMT, Harshitha Onkar wrote:
> In awt_MenuItem.cpp (712,22): ` mii.dwTypeData = (LPTSTR)(*sb)` produces
> invalid pointer cast warning when complied on clang and moreover this is a
> no-op.
>
> `mii.dwTypeData` is used only when **MIIM_STRING** flag is set in the
On Tue, 19 Sep 2023 16:55:02 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/text/html/HTMLDocument/bug4209280.java line 36:
>>
>>> 34: public static void main(String[] args) throws Exception {
>>> 35: String html = "Foo";
>>> 36: new JLabel(html);
>>
>> Suggestion:
>>
On Tue, 19 Sep 2023 16:51:31 GMT, Harshitha Onkar wrote:
>> Following tests are open sourced as part of this PR.
>>
>> 1. java/awt/event/PaintEvent/RepaintTest/RepaintTest.java
>> 2. javax/swing/text/html/HTMLEditorKit/4214848/bug4214848.java
>> 3. javax/swing/text/html/HTMLEditorKit/4230197/bug
On Thu, 14 Sep 2023 21:34:56 GMT, Damon Nguyen wrote:
> These are the tests being converted:
>
> javax/swing/JToolBar/4368050/bug4368050.java
> javax/swing/JToolBar/4465534/bug4465534.java
> javax/swing/JToolBar/4700351/bug4700351.java
> javax/swing/JToolTip/4107843/bug4107843.java
> javax/swing
On Tue, 19 Sep 2023 07:44:39 GMT, Prasanta Sadhukhan
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments changes
>
> test/jdk/javax/swing/KeyboardManager/bug4345798.java line 82:
>
>> 80:
On Tue, 19 Sep 2023 10:17:33 GMT, Alexey Ivanov wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update constant name
>
> test/jdk/javax/swing/JToolBar/bug4243930.java line 44:
>
>> 42: private static class Nul
> These are the tests being converted:
>
> javax/swing/JToolBar/4138694/bug4138694.java
> javax/swing/JToolBar/4140421/bug4140421.java
> javax/swing/JToolBar/4196662/bug4196662.java
> javax/swing/JToolBar/4243930/bug4243930.java
Damon Nguyen has updated the pull request incrementally with one add
> Following tests are open sourced as part of this PR.
>
> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
> 4. test/jdk/javax/swing/text/html/CSS/bug4764897.java
> 5. test/jdk/jav
On Tue, 19 Sep 2023 10:29:02 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review updates
>
> test/jdk/javax/swing/text/html/HTMLDocument/bug4209280.java line 36:
>
>> 34: public static
On Thu, 14 Sep 2023 21:40:55 GMT, Damon Nguyen wrote:
> These are the tests being converted:
>
> javax/swing/JTree/4210432/bug4210432.java
> javax/swing/JTree/4213868/bug4213868.java
> javax/swing/JTree/4224491/bug4224491.java
> javax/swing/JTree/4237370/bug4237370.java
> javax/swing/JTree/46625
> These are the tests being converted:
>
> javax/swing/JTree/4696499/bug4696499.java
> javax/swing/JTree/5039542/bug5039542.java
> javax/swing/JViewport/4546474/bug4546474.java
> javax/swing/JViewport/4677611/bug4677611.java
> javax/swing/KeyboardManager/4345798/bug4345798.java
Damon Nguyen has u
> Following tests are open sourced as part of this PR.
>
> 1. java/awt/event/PaintEvent/RepaintTest/RepaintTest.java
> 2. javax/swing/text/html/HTMLEditorKit/4214848/bug4214848.java
> 3. javax/swing/text/html/HTMLEditorKit/4230197/bug4230197.java
> 4. javax/swing/text/html/HTMLEditorKit/4238223/bu
On Tue, 19 Sep 2023 09:08:16 GMT, Tejesh R wrote:
>> These are the tests being converted:
>>
>> javax/swing/JTree/4696499/bug4696499.java
>> javax/swing/JTree/5039542/bug5039542.java
>> javax/swing/JViewport/4546474/bug4546474.java
>> javax/swing/JViewport/4677611/bug4677611.java
>> javax/swing/
On Tue, 19 Sep 2023 07:46:20 GMT, Prasanta Sadhukhan
wrote:
>> These are the tests being converted:
>>
>> javax/swing/JTree/4696499/bug4696499.java
>> javax/swing/JTree/5039542/bug5039542.java
>> javax/swing/JViewport/4546474/bug4546474.java
>> javax/swing/JViewport/4677611/bug4677611.java
>> j
On Mon, 18 Sep 2023 21:35:01 GMT, Alexander Zvegintsev
wrote:
> Open sourcing several MenuBar manual tests
>
> java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_1.java
> java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_2.java
> java/awt/MenuBar/AddRemoveMenuBarTests/AddRemo
On Tue, 19 Sep 2023 09:15:41 GMT, Arno Zeller wrote:
> > The bug report has "Angle: 15, width diff: -4" Over the length of the
> > string "The quick brown fox jumps over the lazy dog" that could be the
> > occasional rounding difference and there is a comment in the bug report
> > claiming (su
On Tue, 19 Sep 2023 16:10:38 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JToolBar/bug4368050.java line 48:
>>
>>> 46: ObjectInputStream ois = new ObjectInputStream(bais)) {
>>> 47: ois.readObject();
>>> 48: }
>>
>> Better to close the stream ob
On Tue, 19 Sep 2023 16:30:07 GMT, Harshitha Onkar wrote:
>>> Better to close the stream objects in finally block in case of Exception.
>>>
>>> ```
>>> finally {
>>> if (oos != null) {
>>> oos.close();
>>> }
>>> if (ois != null) {
>>> ois.close();
>>> }
>>>
On Mon, 18 Sep 2023 19:30:46 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4368050/bug4368050.java
>> javax/swing/JToolBar/4465534/bug4465534.java
>> javax/swing/JToolBar/4700351/bug4700351.java
>> javax/swing/JToolTip/4107843/bug4107843.java
>> java
On Tue, 19 Sep 2023 16:02:21 GMT, Harshitha Onkar wrote:
> Better to close the stream objects in finally block in case of Exception.
>
> ```
> finally {
> if (oos != null) {
> oos.close();
> }
> if (ois != null) {
> ois.close();
> }
> }
> ```
No, *it's
On Mon, 18 Sep 2023 19:30:46 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4368050/bug4368050.java
>> javax/swing/JToolBar/4465534/bug4465534.java
>> javax/swing/JToolBar/4700351/bug4700351.java
>> javax/swing/JToolTip/4107843/bug4107843.java
>> java
**Root cause**
The _Baekmuk Headline_ font maps `\u6f22` (漢) to glyph id 16950 which has zero
length.
The test fails if the right half of the image with the rendered glyph contains
only pixels of background colour. In this case, the left half of the image is
also blank. It's somewhat false pos
On Wed, 13 Sep 2023 09:19:27 GMT, Tejesh R wrote:
> Open source these Swing PopupMenu related tests:
>
> javax/swing/JPopupMenu/4236750/bug4236750.java
> javax/swing/JPopupMenu/4321273/bug4321273.java
> javax/swing/JPopupMenu/4711693/bug4711693.java
> javax/swing/JPopupMenu/4962731/bug4962731.ja
On Tue, 19 Sep 2023 00:00:45 GMT, Harshitha Onkar wrote:
> Looks like a valid explanation as to why `x + width` is used.
This is why `cellWidth` is a bad name: it doesn't convey the meaning. Consider
*renaming the variable* or adding a comment to clarify the meaning.
-
PR Review C
On Tue, 19 Sep 2023 00:22:35 GMT, Harshitha Onkar wrote:
>> Following tests are open sourced as part of this PR.
>>
>> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
>> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
>> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
>> 4. tes
On Tue, 19 Sep 2023 00:03:34 GMT, Harshitha Onkar wrote:
>> With volatile, it makes the test slightly slower. Other than that, there's
>> not much harm.
>>
>> In most of these tests, there's no need for the `passed` field at all: you
>> can throw the exception from the code where you set the v
On Mon, 18 Sep 2023 23:30:26 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4138694/bug4138694.java
>> javax/swing/JToolBar/4140421/bug4140421.java
>> javax/swing/JToolBar/4196662/bug4196662.java
>> javax/swing/JToolBar/4243930/bug4243930.java
>
> Dam
On Mon, 18 Sep 2023 21:53:36 GMT, Harshitha Onkar wrote:
>> Following tests are open sourced as part of this PR.
>>
>> 1. java/awt/event/PaintEvent/RepaintTest/RepaintTest.java
>> 2. javax/swing/text/html/HTMLEditorKit/4214848/bug4214848.java
>> 3. javax/swing/text/html/HTMLEditorKit/4230197/bug
On Mon, 18 Sep 2023 23:34:12 GMT, Phil Race wrote:
> The bug report has "Angle: 15, width diff: -4" Over the length of the string
> "The quick brown fox jumps over the lazy dog" that could be the occasional
> rounding difference and there is a comment in the bug report claiming
> (suggesting?)
On Mon, 18 Sep 2023 22:10:54 GMT, Damon Nguyen wrote:
> These are the tests being converted:
>
> javax/swing/JTree/4696499/bug4696499.java
> javax/swing/JTree/5039542/bug5039542.java
> javax/swing/JViewport/4546474/bug4546474.java
> javax/swing/JViewport/4677611/bug4677611.java
> javax/swing/Key
On Mon, 18 Sep 2023 22:10:54 GMT, Damon Nguyen wrote:
> These are the tests being converted:
>
> javax/swing/JTree/4696499/bug4696499.java
> javax/swing/JTree/5039542/bug5039542.java
> javax/swing/JViewport/4546474/bug4546474.java
> javax/swing/JViewport/4677611/bug4677611.java
> javax/swing/Key
> Open source these Swing PopupMenu related tests:
>
> javax/swing/JPopupMenu/4236750/bug4236750.java
> javax/swing/JPopupMenu/4321273/bug4321273.java
> javax/swing/JPopupMenu/4711693/bug4711693.java
> javax/swing/JPopupMenu/4962731/bug4962731.java
> javax/swing/JPopupMenu/4966109/bug4966109.java
On Tue, 19 Sep 2023 06:00:55 GMT, Tejesh R wrote:
>> Open source these Swing PopupMenu related tests:
>>
>> javax/swing/JPopupMenu/4236750/bug4236750.java
>> javax/swing/JPopupMenu/4321273/bug4321273.java
>> javax/swing/JPopupMenu/4711693/bug4711693.java
>> javax/swing/JPopupMenu/4962731/bug4962
80 matches
Mail list logo
