Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]

2023-09-27 Thread ScientificWare
On Wed, 30 Aug 2023 14:20:41 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8314731 : Adds support for the alt attribute in the image type input >> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) >> >> This is tracked in JBS as >> - [JDK

Withdrawn: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler

2023-09-27 Thread Julian Waters
On Tue, 1 Aug 2023 01:52:24 GMT, Julian Waters wrote: > We should set the -permissive- flag for the Microsoft Visual C compiler, as > was requested by the now backed out > [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes > the Visual C compiler much less accepting of

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v6]

2023-09-27 Thread Julian Waters
On Thu, 28 Sep 2023 03:12:03 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less acceptin

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v6]

2023-09-27 Thread Julian Waters
> We should set the -permissive- flag for the Microsoft Visual C compiler, as > was requested by the now backed out > [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes > the Visual C compiler much less accepting of ill formed code, which will > improve code quality on W

Integrated: 8316371: Open some swing tests 6

2023-09-27 Thread Alisen Chung
On Thu, 21 Sep 2023 21:45:49 GMT, Alisen Chung wrote: > Opening some closed tests: > 20 javax/swing/plaf/windows/4736093/bug4736093.java > 21 javax/swing/table/DefaultTableCellRenderer/4240870/bug4240870.java > 22 javax/swing/table/JTableHeader/4243927/bug4243927.java > 23 javax/swing/text/Abstra

Re: RFR: 8294156: Demo positioning of multiple test windows [v2]

2023-09-27 Thread Alexey Ivanov
On Thu, 14 Sep 2023 14:53:08 GMT, Alexey Ivanov wrote: >> test/jdk/java/awt/Window/8294156/manyWindows/TwoWindowColumnsH.java line 96: >> >>> 94: private static final int COLUMNS = 3; >>> 95: >>> 96: public static void positionTestUI(List windows, >> >> When I thought about adding more

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v2]

2023-09-27 Thread Alexey Ivanov
On Wed, 13 Sep 2023 14:25:19 GMT, Alexey Ivanov wrote: >> This enhances the `Builder` pattern added in >> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method >> `testUI` which allows passing a lambda expression or a method reference to >> create *the test UI window*. >

Re: RFR: 8294156: Allow PassFailJFrame.Builder to create test UI [v2]

2023-09-27 Thread Alexey Ivanov
On Wed, 20 Sep 2023 18:12:25 GMT, Phil Race wrote: >>> Shouldn't we mention here a window added by `testUI` via builder? >> >> I don't think it's necessary: the builder uses `addTestWindow` under the >> hood. It's the builder that requires documentation. >> >> In fact, the entire class require

Re: RFR: 8294158: HTML formatting for PassFailJFrame instructions

2023-09-27 Thread Alexey Ivanov
On Wed, 20 Sep 2023 18:05:31 GMT, Phil Race wrote: > One thing about these and the other enhancements I see is that there's an > (increasing) need for a nice bit of documentation in PassFailJFrame itself > about all its features. > Easiest to do this as you are adding them, so a doc comment b

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-27 Thread Alexey Ivanov
On Mon, 25 Sep 2023 15:45:59 GMT, Alexey Ivanov wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > test/jdk/java/awt/Frame/DefaultSizeTest.java line 42: > >> 40: and should be

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-27 Thread Alexey Ivanov
On Tue, 26 Sep 2023 14:43:13 GMT, Alexey Ivanov wrote: >> I think it's fine the way it is now. Just in case the user sees some unusual >> failure. > > Well, yes… I haven't thought about it. Anyway I submitted [JDK-8317111](https://bugs.openjdk.org/browse/JDK-8317111): Provide access to Pass/Fa

Re: RFR: 8316211: Open source several manual applet tests [v3]

2023-09-27 Thread Alexey Ivanov
On Tue, 26 Sep 2023 14:46:39 GMT, Alexey Ivanov wrote: >> I have already tried this using keyboard shortcuts. >> >> Alt+F4 works fine on Window and Linux (many popular DEs close windows by >> Alt+F4 by default, e.g. Gnome shell, Plasma). >> >> For macos we don't have a system handler for Cmd +

Re: RFR: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java [v2]

2023-09-27 Thread Christoph Langer
On Wed, 27 Sep 2023 08:10:16 GMT, Christoph Langer wrote: >> Exclude java/awt/font/Rotate/RotatedTextTest.java until >> [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The >> error shows in several linux installations. > > Christoph Langer has updated the pull request with

Integrated: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java

2023-09-27 Thread Christoph Langer
On Fri, 22 Sep 2023 06:20:42 GMT, Christoph Langer wrote: > Exclude java/awt/font/Rotate/RotatedTextTest.java until > [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The > error shows in several linux installations. This pull request has now been integrated. Changeset: ad

Re: RFR: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java [v2]

2023-09-27 Thread Alexey Ivanov
On Wed, 27 Sep 2023 08:04:02 GMT, Christoph Langer wrote: >>> Yet keeping tests in the same area closer seems like a good idea to me. >>> Either line is fine with me. >> >> Let's go for the latter one, line 416. >> >>> I started an internal discussion in clientlibs to see whether there are any

Re: RFR: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java [v2]

2023-09-27 Thread Alexey Ivanov
On Wed, 27 Sep 2023 08:10:16 GMT, Christoph Langer wrote: >> Exclude java/awt/font/Rotate/RotatedTextTest.java until >> [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The >> error shows in several linux installations. > > Christoph Langer has updated the pull request with

Re: RFR: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java [v2]

2023-09-27 Thread Christoph Langer
On Tue, 26 Sep 2023 13:37:53 GMT, Alexey Ivanov wrote: >> I couldn't find any best practices for problem-listing. >> >> Yet keeping tests in the same area closer seems like a good idea to me. >> Either line is fine with me. Thanks. >> >> I started an internal discussion in clientlibs to see wh

Re: RFR: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java [v2]

2023-09-27 Thread Christoph Langer
> Exclude java/awt/font/Rotate/RotatedTextTest.java until > [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The > error shows in several linux installations. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental web