Re: RFR: 8314498: [macos] Transferring File objects to Finder fails [v2]

2023-09-29 Thread Sergey Bylokhov
On Fri, 29 Sep 2023 19:35:33 GMT, Arik Hadas wrote: >> Credit goes to JetBrain that fixed it in JetBrainsRuntime (commit 24819d9). >> This fix was also cherry-picked to muCommander and was verified on macOS >> 12.6.8 and macOs 13, on X86_64 and on M1. >> >> Reproducer/step-to-verify: >> 1. Com

Re: RFR: 8314498: [macos] Transferring File objects to Finder fails [v2]

2023-09-29 Thread Arik Hadas
> Credit goes to JetBrain that fixed it in JetBrainsRuntime (commit 24819d9). > This fix was also cherry-picked to muCommander and was verified on macOS > 12.6.8 and macOs 13, on X86_64 and on M1. > > Reproducer/step-to-verify: > 1. Compile the following class: > > import java.awt.Toolkit; > im

Re: RFR: 8316146: Open some swing tests 4 [v6]

2023-09-29 Thread Alexey Ivanov
On Fri, 29 Sep 2023 19:31:08 GMT, Alisen Chung wrote: >> Opening closed tests: >> 12 javax/swing/ToolTipManager/5078214/bug5078214.java >> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java >> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java >> 15 javax/swing/plaf/meta

Re: RFR: 8316146: Open some swing tests 4 [v6]

2023-09-29 Thread Alisen Chung
> Opening closed tests: > 12 javax/swing/ToolTipManager/5078214/bug5078214.java > 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java > 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java > 15 javax/swing/plaf/metal/4306431/bug4306431.java Alisen Chung has updated the pull

Re: RFR: 8315986: javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location [v2]

2023-09-29 Thread Damon Nguyen
On Fri, 29 Sep 2023 05:05:07 GMT, Prasanta Sadhukhan wrote: >> Test was run without waiting for UI to be made visible leading to >> IllegalComponentStateException. >> Used robot.delay consistent with other headful tests to made the test wait >> after UI is created and shown. >> >> Test passed

Re: RFR: JDK-8314731 : Add support for the alt attribute in the image type input HTML tag [v2]

2023-09-29 Thread Alexey Ivanov
On Wed, 30 Aug 2023 14:20:41 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8314731 : Adds support for the alt attribute in the image type input >> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731) >> >> This is tracked in JBS as >> - [JDK

Re: RFR: 8316146: Open some swing tests 4 [v5]

2023-09-29 Thread Alexey Ivanov
On Thu, 28 Sep 2023 20:39:44 GMT, Alisen Chung wrote: >> Opening closed tests: >> 12 javax/swing/ToolTipManager/5078214/bug5078214.java >> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java >> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java >> 15 javax/swing/plaf/meta

RFR: 8314498: [macos] Transferring File objects to Finder fails

2023-09-29 Thread Arik Hadas
Credit goes to JetBrain that fixed it in JetBrainsRuntime (commit 24819d9). This fix was also cherry-picked to muCommander and was verified on macOS 12.6.8 and macOs 13, on X86_64 and on M1. Reproducer/step-to-verify: 1. Compile the following class: import java.awt.Toolkit; import java.awt.data

Withdrawn: 8316412: javax/print tests fail without printer set up

2023-09-29 Thread Michal Sobierski
On Tue, 19 Sep 2023 14:45:47 GMT, Michal Sobierski wrote: > For NullClipARGB we are throwing SkippedException only if instance of caught > exception is PrinterException. All other exceptions are considered unrelated > to printer configuration. > > For CountPrintServices we want to throw Skippe

Re: RFR: 8316412: javax/print tests fail without printer set up

2023-09-29 Thread Michal Sobierski
On Thu, 28 Sep 2023 17:17:55 GMT, Aleksey Shipilev wrote: > > In other words none of these changes should be necessary and I'm fairly > > sure are actually undesirable in some cases. > > Notably skipping if lpstat isn't installed and you are trying to test > > printing is bad. > > Right! Argh,