On Thu, 28 Sep 2023 20:39:44 GMT, Alisen Chung <[email protected]> wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15 javax/swing/plaf/metal/4306431/bug4306431.java
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed nested loop and used default graphics configuration
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/BasicMenuUI/bug4244616.java line 72:
> 70: }
> 71: } finally {
> 72: // Restore streams, check results
Suggestion:
// Restore streams
You don't check the results here — you've already checked the results above.
test/jdk/javax/swing/ToolTipManager/bug5078214.java line 66:
> 64: throw new SkippedException("We need at least one screen "
> +
> 65: "with the taskbar at the bottom position.");
> 66: }
This code will never throw `SkippedException`.
First you have to test whether `getGraphicsConfig()` returned `null` and throw
the exception. Otherwise, `NullPointerException` will be thrown, which fails
the test instead of skipping it.
Alternatively, you may throw `SkippedException` from `getGraphicsConfig()`
instead of returning `null`.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15875#pullrequestreview-1650635609
PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1341278831
PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1341274950
