Re: RFR: 8316146: Open some swing tests 4 [v9]

2023-10-02 Thread Alisen Chung
> Opening closed tests: > 12 javax/swing/ToolTipManager/5078214/bug5078214.java > 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java > 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java > 15 javax/swing/plaf/metal/4306431/bug4306431.java Alisen Chung has updated the pull

Re: RFR: 8315986: javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location [v2]

2023-10-02 Thread Harshitha Onkar
On Fri, 29 Sep 2023 05:05:07 GMT, Prasanta Sadhukhan wrote: >> Test was run without waiting for UI to be made visible leading to >> IllegalComponentStateException. >> Used robot.delay consistent with other headful tests to made the test wait >> after UI is created and shown. >> >> Test passed

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v2]

2023-10-02 Thread Harshitha Onkar
On Mon, 2 Oct 2023 23:51:04 GMT, Damon Nguyen wrote: >> This test intermittently fails by timeout. Increasing the timeout alone >> doesn't solve the failure as it still fails in about 400 runs. Adding >> another delay and reducing the delay amount to 1000ms. Now, the test passes >> after 2 set

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v2]

2023-10-02 Thread Damon Nguyen
On Mon, 2 Oct 2023 23:33:44 GMT, Harshitha Onkar wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove pack for explicit size > > test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 84: > >> 82:

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v2]

2023-10-02 Thread Damon Nguyen
> This test intermittently fails by timeout. Increasing the timeout alone > doesn't solve the failure as it still fails in about 400 runs. Adding another > delay and reducing the delay amount to 1000ms. Now, the test passes after 2 > sets of 500 repeats on all OS's without a timeout. Damon Nguy

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out

2023-10-02 Thread Harshitha Onkar
On Mon, 2 Oct 2023 23:06:58 GMT, Damon Nguyen wrote: > This test intermittently fails by timeout. Increasing the timeout alone > doesn't solve the failure as it still fails in about 400 runs. Adding another > delay and reducing the delay amount to 1000ms. Now, the test passes after 2 > sets of

RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out

2023-10-02 Thread Damon Nguyen
This test intermittently fails by timeout. Increasing the timeout alone doesn't solve the failure as it still fails in about 400 runs. Adding another delay and reducing the delay amount to 1000ms. Now, the test passes after 2 sets of 500 repeats on all OS's without a timeout. - Com

Re: RFR: 8316146: Open some swing tests 4 [v7]

2023-10-02 Thread Harshitha Onkar
On Mon, 2 Oct 2023 22:21:23 GMT, Harshitha Onkar wrote: >> test/jdk/javax/swing/ToolTipManager/bug5078214.java line 30: >> >>> 28: * @library ../regtesthelpers /test/lib >>> 29: * @build JRobot >>> 30: * @build jtreg.SkippedException >> >> Suggestion: >> >> * @library /test/lib >> * @buil

Re: RFR: 8316146: Open some swing tests 4 [v8]

2023-10-02 Thread Alisen Chung
> Opening closed tests: > 12 javax/swing/ToolTipManager/5078214/bug5078214.java > 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java > 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java > 15 javax/swing/plaf/metal/4306431/bug4306431.java Alisen Chung has updated the pull

Re: RFR: 8316146: Open some swing tests 4 [v7]

2023-10-02 Thread Harshitha Onkar
On Mon, 2 Oct 2023 22:03:21 GMT, Harshitha Onkar wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove util > > test/jdk/javax/swing/ToolTipManager/bug5078214.java line 30: > >> 28: * @library ../regtesthelpers

Re: RFR: 8316146: Open some swing tests 4 [v7]

2023-10-02 Thread Damon Nguyen
On Mon, 2 Oct 2023 22:05:04 GMT, Harshitha Onkar wrote: > @alisenchung Looks like `Util.blockTillDisplayed(mainFrame)` has been removed > which was causing compilation issues earlier. Now the updated test works > correctly. Yep. This sounds correct. I did something similar here in [bug4703690

Re: RFR: 8316146: Open some swing tests 4 [v7]

2023-10-02 Thread Harshitha Onkar
On Mon, 2 Oct 2023 21:46:51 GMT, Alisen Chung wrote: >> Opening closed tests: >> 12 javax/swing/ToolTipManager/5078214/bug5078214.java >> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java >> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java >> 15 javax/swing/plaf/metal

Re: RFR: 8316146: Open some swing tests 4 [v7]

2023-10-02 Thread Alisen Chung
> Opening closed tests: > 12 javax/swing/ToolTipManager/5078214/bug5078214.java > 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java > 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java > 15 javax/swing/plaf/metal/4306431/bug4306431.java Alisen Chung has updated the pull

Re: RFR: 8314755: Resource leak: SwingWorker listener keeps strong reference to executor [v4]

2023-10-02 Thread Alexey Ivanov
On Tue, 12 Sep 2023 12:34:12 GMT, Christopher Sahnwaldt wrote: >> In >> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32 >> the weak reference was accidentally changed from a field to a local >> variable, which means that the PropertyChangeListener keeps a strong

Re: RFR: 6928542: Chinese characters in RTF are not decoded [v7]

2023-10-02 Thread Ichiroh Takiguchi
On Thu, 21 Sep 2023 16:21:05 GMT, Ichiroh Takiguchi wrote: >> "character set of font" (font charset) table was created by "Rich Text >> Format Specification 1.9.1" >> https://interoperability.blob.core.windows.net/files/Archive_References/[MSFT-RTF].pdf >> It refers windgi.h >> https://learn.mi