On Mon, 2 Oct 2023 21:46:51 GMT, Alisen Chung <[email protected]> wrote:

>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15 javax/swing/plaf/metal/4306431/bug4306431.java
>
> Alisen Chung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   remove util

Changes requested by honkar (Committer).

@alisenchung Looks like `Util.blockTillDisplayed(mainFrame)` has been removed 
which was causing compilation issues earlier. Now the updated test works 
correctly.

test/jdk/javax/swing/ToolTipManager/bug5078214.java line 30:

> 28:  * @library ../regtesthelpers /test/lib
> 29:  * @build JRobot
> 30:  * @build jtreg.SkippedException

Suggestion:

 * @library /test/lib
 * @build jtreg.SkippedException

JRobot is not required for this test, it can be replaced with normal Robot 
calls and jtreg header can be modified as above.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15875#pullrequestreview-1653583674
PR Comment: https://git.openjdk.org/jdk/pull/15875#issuecomment-1743835513
PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1343208553

Reply via email to