Re: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v7]

2023-10-12 Thread Julian Waters
On Tue, 10 Oct 2023 03:44:27 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less acceptin

Re: RFR: JDK-8294090 : Aligns the CSS and function behaviours [v3]

2023-10-12 Thread ScientificWare
On Wed, 20 Sep 2023 19:54:01 GMT, Phil Race wrote: >> ScientificWare has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 10 commits: >> >> - Merge branch >> 'scientificware-patch-004-CSS-aligns_rgb_and_rgba_function_behaviours' of

Integrated: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out

2023-10-12 Thread Damon Nguyen
On Mon, 2 Oct 2023 23:06:58 GMT, Damon Nguyen wrote: > This test intermittently fails by timeout. Increasing the timeout alone > doesn't solve the failure as it still fails in about 400 runs. Adding another > delay and reducing the delay amount to 1000ms. Now, the test passes after 2 > sets of

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v8]

2023-10-12 Thread Damon Nguyen
On Thu, 12 Oct 2023 16:27:45 GMT, Alexey Ivanov wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove excess > > test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 103: > >> 101: !p.equals(

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v9]

2023-10-12 Thread Alexey Ivanov
On Thu, 12 Oct 2023 20:07:18 GMT, Damon Nguyen wrote: >> This test intermittently fails by timeout. Increasing the timeout alone >> doesn't solve the failure as it still fails in about 400 runs. Adding >> another delay and reducing the delay amount to 1000ms. Now, the test passes >> after 2 se

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v9]

2023-10-12 Thread Damon Nguyen
> This test intermittently fails by timeout. Increasing the timeout alone > doesn't solve the failure as it still fails in about 400 runs. Adding another > delay and reducing the delay amount to 1000ms. Now, the test passes after 2 > sets of 500 repeats on all OS's without a timeout. Damon Nguy

Re: RFR: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM

2023-10-12 Thread Alexey Ivanov
On Thu, 12 Oct 2023 17:54:07 GMT, Alexander Zuev wrote: > As a workaround changing the method that filters out valid resolutions to not > allow resolutions unsupported by Apple m1/m2 chips to be reported back to > Java side. > > Also removing test from problem list as it should pass again now.

Integrated: 8317847: Typo in API documentation of class JPopupMenu

2023-10-12 Thread ANUPAM DEV
On Wed, 11 Oct 2023 04:54:54 GMT, ANUPAM DEV wrote: > Hello, > > I have fixed the typo in the comment for the method > JPopupMenu.setInvoker(Component invoker) > > before: Sets the invoker of this popup menu -- the component in which the > popup menu menu is to be displayed. > after: Sets the

Re: RFR: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM

2023-10-12 Thread Alexander Zvegintsev
On Thu, 12 Oct 2023 17:54:07 GMT, Alexander Zuev wrote: > As a workaround changing the method that filters out valid resolutions to not > allow resolutions unsupported by Apple m1/m2 chips to be reported back to > Java side. > > Also removing test from problem list as it should pass again now.

Re: RFR: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM

2023-10-12 Thread Phil Race
On Thu, 12 Oct 2023 17:54:07 GMT, Alexander Zuev wrote: > As a workaround changing the method that filters out valid resolutions to not > allow resolutions unsupported by Apple m1/m2 chips to be reported back to > Java side. > > Also removing test from problem list as it should pass again now.

RFR: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM

2023-10-12 Thread Alexander Zuev
As a workaround changing the method that filters out valid resolutions to not allow resolutions unsupported by Apple m1/m2 chips to be reported back to Java side. Also removing test from problem list as it should pass again now. - Commit messages: - Rolling back additional unneede

Re: RFR: 8318028: Remove unused class="centered" from FocusCycle.svg

2023-10-12 Thread Sergey Bylokhov
On Thu, 12 Oct 2023 17:12:05 GMT, Alexey Ivanov wrote: > **Cleanup** > > A trivial modification which removes `class="centered"` from one of the > `` elements. It's a remnant from a previous version of the image. > > Classes aren't used, all `` elements are centered. Marked as reviewed by ser

RFR: 8318028: Remove unused class="centered" from FocusCycle.svg

2023-10-12 Thread Alexey Ivanov
**Cleanup** A trivial modification which removes `class="centered"` from one of the `` elements. It's a remnant from a previous version of the image. Classes aren't used, all `` elements are centered. - Commit messages: - 8318028: Remove unused class="centered" from FocusCycle.svg

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-12 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8318023: Implement IPP output-bin attribute extension on macOS [v2]

2023-10-12 Thread Alexander Scherbatiy
> The fix adds new public `OutputBin` print attribute class which allow to set > a printer output bin in a `PrinterJob` class. The corresponding internal > `CustomOutputBin` class is added as well. > > - Constants used in `OutputBin` class are based on [Internet Printing > Protocol (IPP): “outp

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-12 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-12 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-12 Thread Prasanta Sadhukhan
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v3]

2023-10-12 Thread Alexey Ivanov
On Thu, 5 Oct 2023 17:43:21 GMT, Damon Nguyen wrote: > However, since the accumulation of the changes doesn't seem to cause any > failures anymore, should I just follow through with this PR? I can raise > another bug if needed for this intermittent failure. Can't identify what's > causing this

Re: RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v8]

2023-10-12 Thread Alexey Ivanov
On Thu, 5 Oct 2023 16:20:08 GMT, Damon Nguyen wrote: >> This test intermittently fails by timeout. Increasing the timeout alone >> doesn't solve the failure as it still fails in about 400 runs. Adding >> another delay and reducing the delay amount to 1000ms. Now, the test passes >> after 2 set

Re: RFR: 8154846: SwingNode does not resize when content size constraints are changed [v4]

2023-10-12 Thread Andy Goryachev
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan wrote: >> SwingNode does not update its internal cache of Swing pref/max/min height >> and widths when its JComponent content's corresponding size constraints are >> updated. As such, it isn't resized to honor those size constraints. >> >>

RFR: 7001133: OutOfMemoryError by CustomMediaSizeName implementation

2023-10-12 Thread Alexander Scherbatiy
Each time `CUPSPrinter.initMedia()` method is called it creates new `CustomMediaSizeName` objects which are all collected in static `CustomMediaSizeName.customEnumTable` field. A lot of created duplicated `CustomMediaSizeName` objects wastes java heap space and can lead to `PrintService.getAttr

RFR: 8318023: Implement IPP output-bin attribute extension on macOS

2023-10-12 Thread Alexander Scherbatiy
The fix adds new public `OutputBin` print attribute class which allow to set a printer output bin in a `PrinterJob` class. The corresponding internal `CustomOutputBin` class is added as well. - Constants used in `OutputBin` class are based on [Internet Printing Protocol (IPP): “output-bin” attr

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v8]

2023-10-12 Thread Alexander Zuev
On Tue, 26 Sep 2023 11:12:08 GMT, Abhishek Kumar wrote: >> The issue exist only for non-editable combobox and the root cause is >> accessible object is not created due to incorrect index returned from >> component class which results in no a11y API invoked. >> >> Proposed solution is to return

Re: RFR: 8317970: Bump target macosx-x64 version to 11.00.00 [v2]

2023-10-12 Thread Magnus Ihse Bursie
On Wed, 11 Oct 2023 21:10:21 GMT, Mikael Vidstedt wrote: >> macOS 10.x is no longer receiving updates - the most recent/last release was >> 10.15.7 back in July of 2022. It's time to bump the target macOS version >> (min/max) for macosx-x64. macOS 11.x is still receiving updates. >> >> This ch

Re: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v7]

2023-10-12 Thread Magnus Ihse Bursie
On Tue, 10 Oct 2023 03:44:27 GMT, Julian Waters wrote: >> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less acceptin

Re: RFR: 8305321: Remove unused exports in java.desktop [v3]

2023-10-12 Thread Alexey Ivanov
On Wed, 11 Oct 2023 17:48:28 GMT, Daniel Jeliński wrote: >> src/java.desktop/share/native/libawt/java2d/SurfaceData.h line 557: >> >>> 555: */ >>> 556: SurfaceDataOps * >>> 557: SurfaceData_GetOpsNoSetup(JNIEnv *env, jobject sData); >> >> ~~It seems to me none of the functions in `SurfaceData.

Re: RFR: 8305321: Remove unused exports in java.desktop [v3]

2023-10-12 Thread Alexey Ivanov
On Wed, 11 Oct 2023 17:54:31 GMT, Daniel Jeliński wrote: > `img_makePalette` is in libawt.so, `X11Color.c` is in libawt_xawt.so I see. I didn't check Linux builds, but I should've. - PR Comment: https://git.openjdk.org/jdk/pull/13261#issuecomment-1759299249

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v6]

2023-10-12 Thread Alexey Ivanov
On Tue, 1 Aug 2023 04:16:30 GMT, Renjith Kannath Pariyangad wrote: > Did further investigation on JDK-7116070 (name truncation issue) and found > its [MS > structure](https://learn.microsoft.com/en-us/windows-hardware/drivers/audio/extended-capabilities-from-a-wdm-audio-driver) > limitation,

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v3]

2023-10-12 Thread Alexey Ivanov
On Fri, 21 Jul 2023 03:35:57 GMT, Sergey Bylokhov wrote: >> Renjith Kannath Pariyangad has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Disabled OLE1 from CoInit > > Marked as reviewed by serb (Reviewer). @mrserb Could you take a look at

Re: RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v15]

2023-10-12 Thread Alexey Ivanov
On Thu, 12 Oct 2023 06:40:13 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> Observations : >> 1. Without com initialize if we access Mixer for recording, library loaded >> invalid GUID and clipped description in windows(ID not found in registry). >> With com initialization libr

Integrated: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly

2023-10-12 Thread Ravi Gupta
On Thu, 28 Sep 2023 11:18:16 GMT, Ravi Gupta wrote: > Write a test to check textArea triggers MouseEntered/MouseExited events > properly > > MouseEntered should be triggered only when the mouse enters the component and > MouseExited should be triggered when the mouse goes out of the component.

[NEW BUG]: Sending a SysexMessage starting with 0xF7 leads to JVM crash

2023-10-12 Thread Alec Su
Hi, I've encountered a bug when sending MIDI SysexMessage. SysexMessage allows splitting a sysex message into multiple SysexMessage. The first SysexMessage will start with 0xF0. Other continuing SysexMessage will start with 0xF7. A SysexMessage starting with 0xF0 can be send by javax.sound.midi.R

Re: RFR: JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-12 Thread Laurent Bourgès
On Tue, 10 Oct 2023 21:24:47 GMT, Phil Race wrote: >> For stroked shapes (no Renderer use), the min-join-error check is disabled. >> Added new jtreg test to verify join using pixel counts > > Let me submit a test task to verify. Thanks @prrace for approval. @kevinrushforth could you review this

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v8]

2023-10-12 Thread Abhishek Kumar
On Thu, 12 Oct 2023 08:30:10 GMT, Alexander Zuev wrote: > What about the initial value? Will the combobox initial value be displayed if > it was never changed? The initial value is set in `AquaComboBoxButton` constructor. Yes, initial value is displayed with screen magnifier even if it has nev

Re: RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v8]

2023-10-12 Thread Alexander Zuev
On Tue, 26 Sep 2023 11:12:08 GMT, Abhishek Kumar wrote: >> The issue exist only for non-editable combobox and the root cause is >> accessible object is not created due to incorrect index returned from >> component class which results in no a11y API invoked. >> >> Proposed solution is to return