On Thu, 5 Oct 2023 16:20:08 GMT, Damon Nguyen <[email protected]> wrote:
>> This test intermittently fails by timeout. Increasing the timeout alone
>> doesn't solve the failure as it still fails in about 400 runs. Adding
>> another delay and reducing the delay amount to 1000ms. Now, the test passes
>> after 2 sets of 500 repeats on all OS's without a timeout.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove excess
Marked as reviewed by aivanov (Reviewer).
test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 103:
> 101: !p.equals(endPoint) && !incorrectActionDetected;
> 102: p.translate(sign(endPoint.x - p.x),
> 103: sign(endPoint.y - p.y))) {
Suggestion:
p.translate(sign(endPoint.x - p.x),
sign(endPoint.y - p.y))) {
I'm probably the only one who prefers aligning wrapped lines… Doesn't it look
better?
-------------
PR Review: https://git.openjdk.org/jdk/pull/16018#pullrequestreview-1674614574
PR Review Comment: https://git.openjdk.org/jdk/pull/16018#discussion_r1357075634
