Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase [v2]

2023-10-17 Thread David Holmes
On Mon, 16 Oct 2023 15:04:51 GMT, Matthias Baesken wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> windows aarch64 build issues > > Hello, any comments about the idea of calling into 'os::dll_load' instead ? >

Re: RFR: 8318023: Implement IPP output-bin attribute extension on macOS [v2]

2023-10-17 Thread Phil Race
On Thu, 12 Oct 2023 16:48:11 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in `Out

Re: RFR: 8318023: Implement IPP output-bin attribute extension on macOS [v2]

2023-10-17 Thread Phil Race
On Thu, 12 Oct 2023 16:48:11 GMT, Alexander Scherbatiy wrote: >> The fix adds new public `OutputBin` print attribute class which allow to set >> a printer output bin in a `PrinterJob` class. The corresponding internal >> `CustomOutputBin` class is added as well. >> >> - Constants used in `Out

RFR: JDK-8316030: Update Libpng to 1.6.40

2023-10-17 Thread Harshitha Onkar
Libpng updated from 1.6.39 to 1.6.40 Build and CI Testing passes on all platforms. - Commit messages: - .md file changes - libpng source file changes Changes: https://git.openjdk.org/jdk/pull/16223/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16223&range=00 Issue: htt

Withdrawn: 8302687 Implement interfaces and shared code for announcement feature

2023-10-17 Thread duke
On Mon, 13 Mar 2023 16:46:10 GMT, Artem Semenov wrote: > This enhancement covers basic API and shared code that should be implemented > for the Accessibility Announcement feature. > > CSR [JDK-8304499](https://bugs.openjdk.org/browse/JDK-8304499 > "bugs.openjdk.org") > > @mrserb @prrace @azue

Re: RFR: 8315097: Rename createJavaProcessBuilder [v4]

2023-10-17 Thread Leo Korinth
> Rename createJavaProcessBuilder so that it is not used by mistake instead of > createTestJvm. > > I have used the following sed script: `find -name "*.java" | xargs -n 1 sed > -i -e > "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"` > > Then I have manually modifi

Re: RFR: 8318104: macOS 10.13 check in TabButtonAccessibility.m can be removed

2023-10-17 Thread Alexey Ivanov
On Tue, 17 Oct 2023 11:42:40 GMT, Abhishek Kumar wrote: > Since[ JDK-8317970](https://bugs.openjdk.org/browse/JDK-8317970) is > integrated to make macOS 11 the minimum version to build jdk, the 10.13 check > is not needed and can be removed from TabButtonAccessibility.m file. Marked as reviewe

RFR: 8318104: macOS 10.13 check in TabButtonAccessibility.m can be removed

2023-10-17 Thread Abhishek Kumar
Since[ JDK-8317970](https://bugs.openjdk.org/browse/JDK-8317970) is integrated to make macOS 11 the minimum version to build jdk, the 10.13 check is not needed and can be removed from TabButtonAccessibility.m file. - Commit messages: - macOS 10.13 check can be removed Changes: htt

Re: Metal renderer threading issues [macOS]

2023-10-17 Thread Alexey Ushakov
Not sure about this particular case but in general the change that we have in our fork allows to have a one CVD thread per display (not per MTLLayer as we have in OpenJDK mainstream). But even this optimization is not enough for my opinion. We are currently working on the change that performs up

Integrated: 8317696: Fix compilation with clang-16

2023-10-17 Thread Jan Kratochvil
On Sat, 7 Oct 2023 16:24:29 GMT, Jan Kratochvil wrote: > `--with-toolchain-type=clang` fails the compilation for me with > `clang-16.0.6-3.fc38.x86_64` > > While the warnings can be disabled I find better to just fix them. The GTK > prototypes in JDK reported by clang are either missing or wro