On Tue, 17 Oct 2023 11:42:40 GMT, Abhishek Kumar wrote:
> Since[ JDK-8317970](https://bugs.openjdk.org/browse/JDK-8317970) is
> integrated to make macOS 11 the minimum version to build jdk, the 10.13 check
> is not needed and can be removed from TabButtonAccessibility.m file.
This pull request
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
src/java.desktop/share/classes/sun/font/HBShaper.java line 110:
> 108:
> 109: private static VarHandle getVarHandle(StructLayout struct, String
> name) {
> 110:
On Wed, 18 Oct 2023 20:08:26 GMT, Phil Race wrote:
>> Requiring users to specify the size of the sequence layout was done in order
>> to dispel the illusion that there was any kind of special handling for a
>> sequence layout created without a size. e.g. if you try to allocate with it,
>> what
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
That's interesting. As soon as this went RFR, skara started to send all the
emails from several weeks of already resolved discussions but with a current
timestamp, like we
On Wed, 30 Aug 2023 14:20:41 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8314731 : Adds support for the alt attribute in the image type input
>> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731)
>>
>> This is tracked in JBS as
>> - [JDK
On Wed, 11 Oct 2023 02:40:20 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsDesktopManager.java
>> line 80:
>>
>>> 78: if (f.isMaximizable()) {
>>> 79: if (!f.isMaximum()) {
>>> 80:
On Tue, 10 Oct 2023 03:50:11 GMT, Prasanta Sadhukhan
wrote:
>> A JOptionPane message dialog owned by a JFrame which is not always on top
>> can be obscured behind an `"always on top" JFrame`. Since the option pane is
>> modal, one can't move the "always on top frame" to reveal it, so the
>> a
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote:
> For stroked shapes (no Renderer use), the min-join-error check is disabled.
> Added new jtreg test to verify join using pixel counts
I'm not seeing that github shows I approved this but I certainly intended to.
So hitting approve now.
Oh
On Fri, 13 Oct 2023 20:21:04 GMT, Alexey Ivanov wrote:
> Adds additional test cases to
> `javax/swing/text/html/CSS/CSSAttributeEqualityBug.java`.
>
> Currently, CSS parser in Java allows space between the number and the unit or
> percent. This is what the additional test cases verify.
>
> Th
On Tue, 17 Oct 2023 11:42:40 GMT, Abhishek Kumar wrote:
> Since[ JDK-8317970](https://bugs.openjdk.org/browse/JDK-8317970) is
> integrated to make macOS 11 the minimum version to build jdk, the 10.13 check
> is not needed and can be removed from TabButtonAccessibility.m file.
Marked as reviewe
On Tue, 17 Oct 2023 17:27:45 GMT, Harshitha Onkar wrote:
> Libpng updated from 1.6.39 to 1.6.40
>
> Build and CI Testing passes on all platforms.
A very small update
-
Marked as reviewed by prr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16223#pullrequestreview-168606
On Wed, 18 Oct 2023 13:21:17 GMT, Alexey Ivanov wrote:
> Update ProblemList entry for java/awt/PopupMenu/PopupMenuLocation.java to
> [JDK-8259913](https://bugs.openjdk.org/browse/JDK-8259913) which is a
> specific bug for AWT menus in High DPI environment.
Marked as reviewed by prr (Reviewer).
On Wed, 18 Oct 2023 06:16:15 GMT, Jorn Vernee wrote:
>>> > I'm unclear why it is "better". It seems more obscure to me.
>>>
>>> Ok. I think it's better because it doesn't require creating a maximum size
>>> sequence layout in order to then make a var handle out of, which is a bit
>>> of a hack
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
I've added a test, which although it does not check the rendering is correct,
it checks that the rendering would be identical in both the JNI and FFM cases.
So if it's wron
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
src/java.desktop/share/classes/sun/font/HBShaper.java line 425:
> 423: float startY = (float)startPt.getY();
> 424:
> 425: MemorySegment mat
On Tue, 17 Oct 2023 22:53:30 GMT, Phil Race wrote:
> I'm unclear why it is "better". It seems more obscure to me.
Ok. I think it's better because it doesn't require creating a maximum size
sequence layout in order to then make a var handle out of, which is a bit of a
hack IMO. One that was re
On Wed, 18 Oct 2023 04:44:30 GMT, Phil Race wrote:
>>> I'm unclear why it is "better". It seems more obscure to me.
>>
>> Ok. I think it's better because it doesn't require creating a maximum size
>> sequence layout in order to then make a var handle out of, which is a bit of
>> a hack IMO. O
On Wed, 18 Oct 2023 03:43:15 GMT, Jorn Vernee wrote:
> > I'm unclear why it is "better". It seems more obscure to me.
>
> Ok. I think it's better because it doesn't require creating a maximum size
> sequence layout in order to then make a var handle out of, which is a bit of
> a hack IMO. One
On Tue, 17 Oct 2023 11:50:20 GMT, Jorn Vernee wrote:
>> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
>
> src/java.desktop/share/classes/sun/font/HBShaper.java line 310:
>
>> 308: SequenceLayout glyphInfosLayout =
>> MemoryLayout.sequenceLayout(maxinfo, GlyphInfoL
8318364: Add an FFM-based implementation of harfbuzz OpenType layout
-
Commit messages:
- remove tailing white space
- use scaling
- Fix windows build, remove perf. logging
- Add test, fix bug
- use allocateFrom
- add offset param
- suppressed restricted warnings, now builds bu
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
src/java.desktop/share/classes/sun/font/HBShaper.java line 310:
> 308: SequenceLayout glyphInfosLayout =
> MemoryLayout.sequenceLayout(maxinfo, GlyphInfoLayout);
>
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
src/java.desktop/share/classes/sun/font/HBShaper.java line 55:
> 53: public class HBShaper {
> 54:
> 55: /*
Nice with the original C struct as a comment.
src/java.des
On Fri, 1 Sep 2023 03:45:24 GMT, Phil Race wrote:
> Probably I should not have posted this PR even as draft if it is going to get
> attention as it isn't really ready for that.
No! That is really interesting proposal and discussion!
BTW this PR is not in the draft state.
-
PR Com
On Wed, 30 Aug 2023 02:55:34 GMT, Sergey Bylokhov wrote:
> @prrace did you check how this change affects the performance, especially
> startup? I have experimented with Panama for littlecms:
> https://bugs.openjdk.org/browse/JDK-8313344 and found that the biggest issue
> is a cold start, 8 ms
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote:
> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
@prrace did you check how this change affects the performance, especially
startup? I have experimented with Panama for littlecms:
https://bugs.openjdk.org/browse/JDK-831334
> The fix adds new public `OutputBin` print attribute class which allow to set
> a printer output bin in a `PrinterJob` class. The corresponding internal
> `CustomOutputBin` class is added as well.
>
> - Constants used in `OutputBin` class are based on [Internet Printing
> Protocol (IPP): “outp
On Tue, 17 Oct 2023 20:28:20 GMT, Phil Race wrote:
> Why did you file a new RFE when you know about the existing one ? Close your
> new one as a dup. and redirect everything to the existing one. Also I don't
> see any UI work to enhance the dialog so it can be selected. And why restrict
> it t
Update ProblemList entry for java/awt/PopupMenu/PopupMenuLocation.java to
[JDK-8259913](https://bugs.openjdk.org/browse/JDK-8259913) which is a specific
bug for AWT menus in High DPI environment.
-
Commit messages:
- 8318448: Link PopupMenu/PopupMenuLocation.java failure to JDK-825
On Wed, 16 Aug 2023 23:46:09 GMT, Harshitha Onkar wrote:
> Oh, I didn't notice that `setAutoWaitForIdle()` was not used the first time.
> I have changed it. I think adding a small amount of delay after
> `makeToolbarFloat()` is good in addition to `setAutoWaitForIdle()` to
> stabilize the test
29 matches
Mail list logo
