On Thu, 7 Dec 2023 03:37:53 GMT, Alexander Zvegintsev
wrote:
>> The root of this issue is the incorrect calculation of window decoration
>> insets.
>>
>> Previously we got non-zero window insets in the first PropertyNotify with
>> [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm
On Mon, 4 Dec 2023 23:26:12 GMT, Alexander Zvegintsev
wrote:
> The root of this issue is the incorrect calculation of window decoration
> insets.
>
> Previously we got non-zero window insets in the first PropertyNotify with
> [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm-spec
> The root of this issue is the incorrect calculation of window decoration
> insets.
>
> Previously we got non-zero window insets in the first PropertyNotify with
> [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm-spec/wm-spec-latest.html#idm45771211302000)
> atom, save them and n
On Mon, 4 Dec 2023 23:26:12 GMT, Alexander Zvegintsev
wrote:
> The root of this issue is the incorrect calculation of window decoration
> insets.
>
> Previously we got non-zero window insets in the first PropertyNotify with
> [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm-spec
On Mon, 4 Dec 2023 23:26:12 GMT, Alexander Zvegintsev
wrote:
> The root of this issue is the incorrect calculation of window decoration
> insets.
>
> Previously we got non-zero window insets in the first PropertyNotify with
> [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm-spec
On Mon, 20 Nov 2023 23:58:30 GMT, Phil Race wrote:
> Whilst reviewing the fix for https://bugs.openjdk.org/browse/JDK-7001133 I
> realised that although the proposed
> changes there may help, the problem would be inconsequential except that if
> anything causes an app to
> call PrintService.get
> Whilst reviewing the fix for https://bugs.openjdk.org/browse/JDK-7001133 I
> realised that although the proposed
> changes there may help, the problem would be inconsequential except that if
> anything causes an app to
> call PrintService.getAttributes() we will continually be re-initialising
On Tue, 21 Nov 2023 21:23:12 GMT, Phil Race wrote:
> For as long as we've had the macOS port, it seems that queries on the
> GraphicsConfiguration associated with
> a printer would give you null for the defaultTransform.
> Clearly this API isn't a popular one to call in such a context else we'd
On Mon, 4 Dec 2023 23:26:12 GMT, Alexander Zvegintsev
wrote:
> The root of this issue is the incorrect calculation of window decoration
> insets.
>
> Previously we got non-zero window insets in the first PropertyNotify with
> [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm-spec
On Wed, 6 Dec 2023 19:20:22 GMT, Phil Race wrote:
>> Anton Bobrov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8321176: remove RuntimeException and address review comments
>
> src/java.desktop/unix/native/libawt_xawt/awt/screencast_pi
On Wed, 6 Dec 2023 19:05:31 GMT, Phil Race wrote:
>> Such change requires a [CSR](https://wiki.openjdk.org/display/csr) .
>> If we want to get this fix into JDK 22, we don't have time for CSR, since
>> JDK 22 will be forked this Thursday.
>
> It is beyond that. It is an incompatible change. It w
On Wed, 6 Dec 2023 09:08:55 GMT, Anton Bobrov wrote:
>> This patch adds re-try logic to libpipewire screencast error handling as
>> discussed in PR #16794 and also brings some additional error handling and
>> thread safety improvements. Specifically around cleanup order where
>> incorrect orde
On Wed, 6 Dec 2023 04:54:02 GMT, Alexander Zvegintsev
wrote:
>> @prrace have you read my description of this PR? If so, and based on that,
>> what can you propose to address the problem described?
>
> Such change requires a [CSR](https://wiki.openjdk.org/display/csr) .
> If we want to get this
On Wed, 6 Dec 2023 18:04:59 GMT, Alexander Zvegintsev
wrote:
>> Anton Bobrov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8321176: remove RuntimeException and address review comments
>
> Looks good to me.
>
>> can you please file a
On Wed, 6 Dec 2023 18:33:56 GMT, Alisen Chung wrote:
>> The root of this issue is the incorrect calculation of window decoration
>> insets.
>>
>> Previously we got non-zero window insets in the first PropertyNotify with
>> [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm-spec/wm-
On Mon, 4 Dec 2023 23:26:12 GMT, Alexander Zvegintsev
wrote:
> The root of this issue is the incorrect calculation of window decoration
> insets.
>
> Previously we got non-zero window insets in the first PropertyNotify with
> [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm-spec
On Wed, 6 Dec 2023 09:08:55 GMT, Anton Bobrov wrote:
>> This patch adds re-try logic to libpipewire screencast error handling as
>> discussed in PR #16794 and also brings some additional error handling and
>> thread safety improvements. Specifically around cleanup order where
>> incorrect orde
On Wed, 6 Dec 2023 17:24:20 GMT, Victor Dyakov wrote:
> @prsadhuk @honkar-jdk @prrace is it ongoing next 24 hours?
@victordyakov The test fix consists of macOS version specific fix - adding an
extra mouse event. But since we are trying find the root cause behind the issue
and it might end up b
On Wed, 22 Nov 2023 08:46:32 GMT, Prasanta Sadhukhan
wrote:
> Test failing on macos14 citing "ToolTip not found"...Investigation shows that
> the mouse is not moved when invoked 1st time to desired location on screen
> causing tooltip to not show...However, subsequent runs of the same test
>
On Mon, 4 Dec 2023 23:26:12 GMT, Alexander Zvegintsev
wrote:
> The root of this issue is the incorrect calculation of window decoration
> insets.
>
> Previously we got non-zero window insets in the first PropertyNotify with
> [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm-spec
On Mon, 4 Dec 2023 23:27:23 GMT, Alexander Zvegintsev
wrote:
>> The root of this issue is the incorrect calculation of window decoration
>> insets.
>>
>> Previously we got non-zero window insets in the first PropertyNotify with
>> [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm
On Wed, 15 Nov 2023 09:50:19 GMT, Abhishek Kumar wrote:
> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`. For
> `DIRECTORIES_ONLY `mode, there may not be any directories in home directory
> and due to that test failed. Added the code to create temporary directories
>
On Mon, 4 Dec 2023 23:26:12 GMT, Alexander Zvegintsev
wrote:
> The root of this issue is the incorrect calculation of window decoration
> insets.
>
> Previously we got non-zero window insets in the first PropertyNotify with
> [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm-spec
On Wed, 6 Dec 2023 13:18:53 GMT, Tejesh R wrote:
>>> Instead of passing the laf through all the methods, can't we create and use
>>> a class variable?
>>
>> Can be done but can't see any functional improvements. This seems ok to me.
>
> Yeah, those are to reduce redundancy in code, not function
On Wed, 6 Dec 2023 10:55:33 GMT, Abhishek Kumar wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java
>> line 206:
>>
>>> 204: }
>>> 205:
>>> 206: private static void checkResult(UIManager.LookAndFeelInfo laf)
>>> throws Exception {
>>
>> Instead
On Tue, 5 Dec 2023 19:35:50 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>> directori
On Tue, 5 Dec 2023 07:59:19 GMT, Prasanta Sadhukhan
wrote:
>> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
>> field isn't declared as volatile. Without the volatile modifier,
>> double-checked locking implementation is broken.
>
> Prasanta Sadhukhan has updated
> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
> field isn't declared as volatile. Without the volatile modifier,
> double-checked locking implementation is broken.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the
On Wed, 6 Dec 2023 05:17:34 GMT, Tejesh R wrote:
> Instead of passing the laf through all the methods, can't we create and use a
> class variable?
Can be done but can't see any functional improvements. This seems ok to me.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/1667
On Wed, 6 Dec 2023 09:08:55 GMT, Anton Bobrov wrote:
>> This patch adds re-try logic to libpipewire screencast error handling as
>> discussed in PR #16794 and also brings some additional error handling and
>> thread safety improvements. Specifically around cleanup order where
>> incorrect orde
> This patch adds re-try logic to libpipewire screencast error handling as
> discussed in PR #16794 and also brings some additional error handling and
> thread safety improvements. Specifically around cleanup order where incorrect
> ordering lead to native memory corruption issues, and lock/unlo
31 matches
Mail list logo
