Re: RFR: 8321176: [Screencast] make a second attempt on screencast failure [v2]

2023-12-08 Thread Phil Race
On Wed, 6 Dec 2023 09:08:55 GMT, Anton Bobrov wrote: >> This patch adds re-try logic to libpipewire screencast error handling as >> discussed in PR #16794 and also brings some additional error handling and >> thread safety improvements. Specifically around cleanup order where >> incorrect orde

Re: RFR: 8307246 : Update for sun.print.RasterPrinterJob in banded-raster printing loop

2023-12-08 Thread Phil Race
On Fri, 8 Dec 2023 05:52:46 GMT, vtstydev wrote: > More correct way to take in consideration nonzero PHYSICALOFFSETX, > PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows > platform under certain conditions real device prints shifted image on paper. This is going to req

Integrated: 8312307: Obsoleted code in hb-jdk-font.cc

2023-12-08 Thread Phil Race
On Thu, 7 Dec 2023 18:41:12 GMT, Phil Race wrote: > Clean up some un-used code in the 2D native font code that interfaces to > libharfbuzz This pull request has now been integrated. Changeset: 6c13a303 Author:Phil Race URL: https://git.openjdk.org/jdk/commit/6c13a3032f3e6f08216fa8d

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

2023-12-08 Thread Alexey Ivanov
On Fri, 8 Dec 2023 17:12:29 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v3]

2023-12-08 Thread Sergey Bylokhov
> The fix for a regression caused by the > https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account > RPC_E_CHANGED_MODE when COM was already initialized using > COINIT_MULTITHREADED mode. > > @aivanov-jdk please take a look. Sergey Bylokhov has updated the pull request incre

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Fri, 8 Dec 2023 15:36:40 GMT, Alexey Ivanov wrote: >> Sergey Bylokhov has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - 8270269: Desktop.browse method fails if earlier CoInitialize call as >> COINIT_MULTITHREADED >> - Revert "6508

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:53:25 GMT, Sergey Bylokhov wrote: >> src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp line 99: >> >>> 97: ::CoUninitialize(); >>> 98: } >>> 99: } >> >> I'm unsure this is the right thing to do. The documentation for >> [`ShellExecute`

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RFR: 8270269: Desktop.browse method fails if earlier CoInitialize call as COINIT_MULTITHREADED [v2]

2023-12-08 Thread Alexey Ivanov
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote: >> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please

Re: RenderPerf 23.11

2023-12-08 Thread Laurent Bourgès
Hi volker, I did work as a contractor for JetBrains on this changes so I do not see any IP issue as I am an OpenJDK contributor and the JetBrains company too. See https://github.com/JetBrains/JetBrainsRuntime/tree/lbourges/renderperf I can use my jetbrains.com email but it would requires me to cr

Re: RenderPerf 23.11

2023-12-08 Thread Volker Simonis
Hi Laurent, I don't think you can contribute somebody else's code to OpenJDK. All OpenJDK contributions are done under OCA, but under OCA you can only contribute code for which you own the copyright. So in this case, JetBrains would have to contribute the code. I understand that it is just a test

RenderPerf 23.11

2023-12-08 Thread Laurent Bourgès
Hi, I forked & improved RenderPerf test from jetbrains runtime ie openjdk/test/jdk/performance... See RenderPerf 23.11 release for new features: https://github.com/bourgesl/RenderPerf/releases/tag/v23_11 FYI I will fix minor things and will contribute it back to openjdk as PR for early 2024. Ch

Withdrawn: JDK-8302618: [macOS] Problem typing uppercase letters with java.awt.Robot when moving mouse

2023-12-08 Thread duke
On Fri, 30 Jun 2023 22:29:05 GMT, Harshitha Onkar wrote: > **Problem:** > > On macOS, Robot erroneously produces lowercase letter when mouse is moved > (manually) in unison with Robot's keyEvents. This issue was originally logged > by a developer of an on-screen accessibility keyboard - Touch

RFR: JDK-8307246 : Update for sun.print.RasterPrinterJob in banded-raster printing loop

2023-12-08 Thread vtstydev
More correct way to take in consideration nonzero PHYSICALOFFSETX, PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows platform under certain conditions real device prints shifted image on paper. - Commit messages: - More correct way to take in consideration