On Tue, 21 Nov 2023 03:33:21 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However, JScrollBa
> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>
> "Sets the minimum size of this component to a constant value. Subsequent
> calls to getMinimumSize will always return this value..."
>
> However, JScrollBar overrides getMinimumSize() and breaks this contract - it
> always
Updated the actions for "ctrl shift DOWN" to "`selectLastRowExtendSelection`"
and "ctrl shift UP", "`selectFirstRowExtendSelection`" in Basic and other Look
and feel. Tested in CI and no regressions found.
Test to be used -
[javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java](https:
On Tue, 2 Jan 2024 05:31:17 GMT, Sergey Bylokhov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Removed unnecessary try block
>
> test/jdk/java/awt/color/NonICCFilterTest.java line 109:
>
>> 107:
> Hi Reviewers,
> There was a typo for color conversion instead of dstColorSpace function
> srcColorSpace was used. Please review and let me know your suggestions if
> any.
>
> Renjith.
Renjith Kannath Pariyangad has updated the pull request incrementally with two
additional commits since th
On Tue, 2 Jan 2024 05:29:35 GMT, Sergey Bylokhov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Removed unnecessary try block
>
> test/jdk/java/awt/color/NonICCFilterTest.java line 47:
>
>> 45:
>>
On Tue, 2 Jan 2024 20:04:39 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp
>> line 194:
>>
>>> 192: if (hBM == NULL) {
>>> 193: J2dTraceLn(J2D_TRACE_WARNING,
>>> "AwtWin32GraphicsDevice::Initialize CreateCompatibleBitmap fail
On Tue, 21 Nov 2023 03:33:21 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However, JScrollBa
On Tue, 2 Jan 2024 19:37:53 GMT, Alexey Ivanov wrote:
> It seems that we cannot continue if `hBMDC` or `hBM` are null. Yet it seems
> unexpected.
Should we rather modify the code to back out and not to call APIs with NULL
handles?
-
PR Review Comment: https://git.openjdk.org/jdk/
On Thu, 28 Dec 2023 09:48:52 GMT, Matthias Baesken wrote:
> When running with fastdebug binaries we run intermittent into the issue below
> in
> jtreg test
> java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java .
> Seems we miss checking of successful HBITMAP creation befor
On Mon, 16 Jan 2023 14:19:52 GMT, Alexey Ivanov wrote:
> This is somewhat a continuation of #11104 where the issue was discussed and
> where I found [the root
> cause](https://github.com/openjdk/jdk/pull/11104#issuecomment-1382435784).
>
> **Root Cause**
>
> The icon extraction code compares
On Fri, 8 Dec 2023 03:23:22 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> Updated the test and it will generate required images on the fly so storing
> and loading image from repo could be avoided. Please review and let me know
> your suggestions.
>
> Regards,
> Renjith.
This p
On Wed, 27 Dec 2023 03:47:16 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated the test and it will generate required images on the fly so storing
>> and loading image from repo could be avoided. Please review and let me know
>> your suggestions.
>>
>> Regards,
>> Renjith
The new test java/awt/font/JNICheck/FreeTypeScalerJNICheck.java introduced with
https://bugs.openjdk.java.net/browse/JDK-8269223 adds -Xcheck:jni , and shows
on Windows server 2019 the following JNI warning , so the test fails on this
Windows version.
stdout: [WARNING in native method: JNI cal
On Mon, 16 Jan 2023 14:19:52 GMT, Alexey Ivanov wrote:
> This is somewhat a continuation of #11104 where the issue was discussed and
> where I found [the root
> cause](https://github.com/openjdk/jdk/pull/11104#issuecomment-1382435784).
>
> **Root Cause**
>
> The icon extraction code compares
On Sat, 11 Nov 2023 12:32:15 GMT, Jan Trukenmüller wrote:
>> The MIDI file parser misinterprets events without status byte when they
>> appear directly after a Meta of SysEx event.
>>
>> For my bugfix I had to decide between two possible solutions:
>> - Strict solution: Throw an InvalidMidiData
16 matches
Mail list logo
