On Wed, 3 Jan 2024 04:20:44 GMT, Tejesh R wrote:
> Updated the actions for "ctrl shift DOWN" to "`selectLastRowExtendSelection`"
> and "ctrl shift UP", "`selectFirstRowExtendSelection`" in Basic and other
> Look and feel. Tested in CI and no regressions found.
> Test to be used -
> [javax/sw
> The issue is that the doc area (in respect to the screen height which is
> 768px) which is at the bottom was causing the `JFileChooser `to be placed
> slightly above the set location. Was able to reproduce in local machine with
> reference to the failure image provided in the CI logs. The sugg
On Wed, 10 Jan 2024 19:50:45 GMT, Sergey Bylokhov wrote:
>> Can this patch be covered by the new test?
>
>>I'm not sure… We want the filter to take another path, there could be a list
>>of filters applied, if I understand @mrserb correctly. Sergey could be able
>>to provide a more detailed guid
On Thu, 11 Jan 2024 04:48:23 GMT, Tejesh R wrote:
> The issue is that the doc area (in respect to the screen height which is
> 768px) which is at the bottom was causing the `JFileChooser `to be placed
> slightly above the set location. Was able to reproduce in local machine with
> reference to
On Thu, 11 Jan 2024 06:14:48 GMT, Abhishek Kumar wrote:
> Does the test fails only on the system which is 768px in height or in any
> other screen size also?
Not only on 768, whichever size isn't enough for the FileChooser to show up
fully it'll fail. I was able to check till 720px in local ma
On Thu, 11 Jan 2024 04:48:23 GMT, Tejesh R wrote:
> The issue is that the doc area (in respect to the screen height which is
> 768px) which is at the bottom was causing the `JFileChooser `to be placed
> slightly above the set location. Was able to reproduce in local machine with
> reference to
On Thu, 11 Jan 2024 05:31:50 GMT, Abhishek Kumar wrote:
> > The issue is that the doc area (`in respect to the screen width which is
> > 768px`) which is at the bottom was causing the JFileChooser to be placed
> > slightly above the set location.
>
> Is it with respect to height ?
Yeah, corre
On Thu, 11 Jan 2024 04:48:23 GMT, Tejesh R wrote:
> The issue is that the doc area (`in respect to the screen width which is
> 768px`) which is at the bottom was causing the JFileChooser to be placed
> slightly above the set location.
Is it with respect to height ?
-
PR Comment:
On Wed, 10 Jan 2024 21:35:57 GMT, Harshitha Onkar wrote:
> A black screen is seen on newer versions of macOS (13.3 & above) when a
> window is set to full-screen using `setFullScreenWindow()`. The root cause
> was narrowed down to the shield level of the full-screen window vs the shield
> leve
On Wed, 10 Jan 2024 12:31:57 GMT, Prasanta Sadhukhan
wrote:
>> I tried with this approach first but images didn't render at all.
>
> I guess those might be null at class initialisation stage so it didn't
> render..you can try
>
> expandedIconWrapper = new IconWrapper(expandedIcon);
> collapse
> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component
> c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned from
> BasicTreeUI class which doesn't contain any icon image whereas the expanded
> icon is returned from SynthTreeUI class and expanded icon
The issue is that the doc area (in respect to the screen width which is 768px)
which is at the bottom was causing the `JFileChooser `to be placed slightly
above the set location. Was able to reproduce in local machine with reference
to the failure image provided in the CI logs. The suggested fix
On Wed, 10 Jan 2024 05:25:42 GMT, Tejesh R wrote:
>> Updated the actions for "ctrl shift DOWN" to
>> "`selectLastRowExtendSelection`" and "ctrl shift UP",
>> "`selectFirstRowExtendSelection`" in Basic and other Look and feel. Tested
>> in CI and no regressions found.
>> Test to be used -
>>
On Thu, 11 Jan 2024 01:01:46 GMT, Harshitha Onkar wrote:
>It works the same in both cases - the shield window becomes the topmost window
>and a black screen is seen.
That probably is not right, but we can fix that separately.
-
PR Comment: https://git.openjdk.org/jdk/pull/17358#is
On Wed, 10 Jan 2024 21:35:57 GMT, Harshitha Onkar wrote:
> A black screen is seen on newer versions of macOS (13.3 & above) when a
> window is set to full-screen using `setFullScreenWindow()`. The root cause
> was narrowed down to the shield level of the full-screen window vs the shield
> leve
On Thu, 16 Mar 2023 06:06:50 GMT, 柳鲲鹏 wrote:
> Candidat box can moving with caret on windows version. Someone must wrote
> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes.
> Why it doesn't work, is the key problem.
>
> 1, I wrote a example for linux:
> https://githu
On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote:
> Currently there is a number of functionality that would be interesting to
> have for shared lib load operations in the JDK C code.
> Some examples :
> Events::log_dll_message for hs-err files reporting
> JFR event NativeLibraryLoad
> Th
On Wed, 10 Jan 2024 23:45:57 GMT, Sergey Bylokhov wrote:
>> A black screen is seen on newer versions of macOS (13.3 & above) when a
>> window is set to full-screen using `setFullScreenWindow()`. The root cause
>> was narrowed down to the shield level of the full-screen window vs the
>> shield
The docs for the boolean methods are updated from this style:
@return if the event has been consumed
to this one
@return {@code true} if the event has been consumed, otherwise
{@code false}
plus small cleanups here and there.
-
Commit messages:
- one more
- one more typo
- 8323
On Wed, 10 Jan 2024 21:35:57 GMT, Harshitha Onkar wrote:
> A black screen is seen on newer versions of macOS (13.3 & above) when a
> window is set to full-screen using `setFullScreenWindow()`. The root cause
> was narrowed down to the shield level of the full-screen window vs the shield
> leve
A black screen is seen on newer versions of macOS (13.3 & above) when a window
is set to full-screen using `setFullScreenWindow()`. The root cause was
narrowed down to the shield level of the full-screen window vs the shield level
of the captured display.
Following solutions were explored -
1.
On Tue, 9 Jan 2024 21:06:50 GMT, Alisen Chung wrote:
> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
> the TrayIcon was already removed by the test, causing an error. The fix is to
> make SunToolkit skip posting the event if appContext is null. The test is
> also u
> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
> the TrayIcon was already removed by the test, causing an error. The fix is to
> make SunToolkit skip posting the event if appContext is null. The test is
> also updated to remove applet usage and use PassFailJFrame in
On Wed, 10 Jan 2024 09:18:53 GMT, Matthias Baesken wrote:
> There have been concerns raised about
> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) , so bring back
> the old behavior.
okay
-
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/j
On Thu, 30 Nov 2023 19:20:50 GMT, Sergey Bylokhov wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Can this patch be covered by the new te
On Wed, 10 Jan 2024 09:18:53 GMT, Matthias Baesken wrote:
> There have been concerns raised about
> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) , so bring back
> the old behavior.
Marked as reviewed by prr (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/1
On Wed, 27 Dec 2023 04:20:42 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have updated the test case. Now test has pass/fail option also test will
> execute two time for covering different cases which are part of the test.
>
> Please review and let me know your suggestions.
>
On Tue, 9 Jan 2024 11:11:38 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad h
On Thu, 4 Jan 2024 14:40:59 GMT, Matthias Baesken wrote:
> > It should be extended to include the possible failure in the preceding call
> > to ::GetDIBits.
>
> I handle now also a failure of the first GetDIBits call; and also added
> braces at the if's mentioned.
Sorry for my delayed reply.
On Tue, 9 Jan 2024 06:35:12 GMT, Philip Race wrote:
>reason for the exception which has NEVER been seen in our testing here and
>once understood
I checked the new output of the jtr with this change (where ExceptionDescribe
is called) but nothing is reported unfortunately.
So I really wonder -
On Wed, 10 Jan 2024 12:01:47 GMT, Julian Waters wrote:
> Not a review, just a quick tip: Such changes are by convention titled
> [BACKOUT]
>
> In this case that would be JDK-8323330: [BACKOUT] JDK-8276809:
> java/awt/font/JNICheck/FreeTypeScalerJNICheck.java shows JNI warning on
> Windows
T
On Wed, 10 Jan 2024 12:20:28 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTreeUI.java line
>> 82:
>>
>>> 80: private Icon expandedIconWrapper = new
>>> IconWrapper(IconType.EXPANDED);
>>> 81:
>>> 82: private Icon collapsedIconWrapper = new
On Wed, 10 Jan 2024 11:26:17 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ExpandedIconWrapper and CollapsedIconWrapper class merged together
>
> src/java.desktop/share/classes/javax/sw
On Wed, 10 Jan 2024 09:18:53 GMT, Matthias Baesken wrote:
> There have been concerns raised about
> [JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) , so bring back
> the old behavior.
Not a review, just a quick tip: Such changes are by convention titled [BACKOUT]
In this case tha
On Wed, 10 Jan 2024 10:52:44 GMT, Abhishek Kumar wrote:
>> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component
>> c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned
>> from BasicTreeUI class which doesn't contain any icon image whereas the
>> expan
On Wed, 10 Jan 2024 08:55:19 GMT, Prasanta Sadhukhan
wrote:
>> Should I merge the two classes into one class like instead of separate
>> `ExpandedIconWrapper` and `CollapsedIconWrapper`, only one `IconWrapper`
>> class?
>
> guess you could since they are all private..
Merged `ExpandedIconWrap
> The collapsed icon for JTree is not painted using `Icon.paintIcon(Component
> c, Graphics g, int x, int y)` in GTK LAF. The collapsed icon is returned from
> BasicTreeUI class which doesn't contain any icon image whereas the expanded
> icon is returned from SynthTreeUI class and expanded icon
There have been concerns raised about
[JDK-8276809](https://bugs.openjdk.org/browse/JDK-8276809) , so bring back the
old behavior.
-
Commit messages:
- JDK-8323330
Changes: https://git.openjdk.org/jdk/pull/17341/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17341&range=0
On Wed, 10 Jan 2024 08:25:52 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTreeUI.java line
>> 837:
>>
>>> 835: }
>>> 836: else {
>>> 837: SynthGraphicsUtils.paintIcon(collapsedIcon, context,
>>> g, x, y, w, h);
On Wed, 10 Jan 2024 05:56:37 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove whitespace error
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTreeUI.java line
> 837
40 matches
Mail list logo
