Re: RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v26]

2024-01-15 Thread Julian Waters
On Thu, 16 Nov 2023 03:44:53 GMT, Phil Race wrote: >> I happened to ask around on the build-dev mailing lists about whether we >> include msvcp.dll with the JDK, here is Erik's response: >> >>> Back in JDK 8 when we used Visual Studio 2010, we used to not ship >>> msvcp*.dll. This changed when

Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v3]

2024-01-15 Thread Tejesh R
On Sat, 13 Jan 2024 05:06:10 GMT, Sergey Bylokhov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review fix > > test/jdk/javax/swing/JFileChooser/JFileChooserSetLocationTest.java line 216: > >> 214: >> 215:

Re: RFR: 8295804: javax/swing/JFileChooser/JFileChooserSetLocationTest.java failed with "setLocation() is not working properly" [v4]

2024-01-15 Thread Tejesh R
> The issue is that the doc area (in respect to the screen height which is > 768px) which is at the bottom was causing the `JFileChooser `to be placed > slightly above the set location. Was able to reproduce in local machine with > reference to the failure image provided in the CI logs. The sugg

Re: RFR: 8259550: The content of the print out displayed incomplete with the NimbusLAF

2024-01-15 Thread Tejesh R
On Fri, 12 Jan 2024 21:13:33 GMT, Damon Nguyen wrote: > Is there anything else that needs changing other than in SynthTableUI.java? > Or any missing configuration on my end? Not any specific configuration is required, just can print it on a pdf for testing and see that few of the last column c

Re: RFR: 8316497 : ColorConvertOp - typo for non-ICC conversions needs one-line fix [v15]

2024-01-15 Thread Renjith Kannath Pariyangad
> Hi Reviewers, > There was a typo for color conversion instead of dstColorSpace function > srcColorSpace was used. Please review and let me know your suggestions if > any. > > Renjith. Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the

Re: RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v9]

2024-01-15 Thread Alexey Ivanov
On Tue, 19 Dec 2023 02:09:08 GMT, songpv-imt wrote: >> The root cause of the bug is because mousePress() method is invoked before >> mouseMove() event is completely processed causing the drag & drop behavior >> not being able to be recognized properly. This in turn makes the method >> dragSour

Re: RFR: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws and exception on Mac OS 14(x64, aarch64) [v4]

2024-01-15 Thread Alexey Ivanov
On Fri, 12 Jan 2024 22:18:04 GMT, Alisen Chung wrote: >> SunToolkit.java is trying to post an event on the TrayIcon appContext, but >> the TrayIcon was already removed by the test, causing an error. The fix is >> to make SunToolkit skip posting the event if appContext is null. The test is >> a

Re: RFR: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws and exception on Mac OS 14(x64, aarch64) [v3]

2024-01-15 Thread Alexey Ivanov
On Fri, 12 Jan 2024 22:04:37 GMT, Alisen Chung wrote: >> SunToolkit.java is trying to post an event on the TrayIcon appContext, but >> the TrayIcon was already removed by the test, causing an error. The fix is >> to make SunToolkit skip posting the event if appContext is null. The test is >> a

Re: RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v9]

2024-01-15 Thread Alexey Ivanov
On Tue, 19 Dec 2023 02:09:08 GMT, songpv-imt wrote: >> The root cause of the bug is because mousePress() method is invoked before >> mouseMove() event is completely processed causing the drag & drop behavior >> not being able to be recognized properly. This in turn makes the method >> dragSour

Re: RFR: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination [v9]

2024-01-15 Thread Alexey Ivanov
On Tue, 19 Dec 2023 02:09:08 GMT, songpv-imt wrote: >> The root cause of the bug is because mousePress() method is invoked before >> mouseMove() event is completely processed causing the drag & drop behavior >> not being able to be recognized properly. This in turn makes the method >> dragSour

Re: RFR: 8318590: JButton ignores margin when painting HTML text [v5]

2024-01-15 Thread Philip Race
There are 2 different tests involved with names that are similar so you need to look closely One was deleted in the initial commit and never restored : test/jdk/javax/swing/JButton/HtmlButtonImageTest/HtmlButtonImageTest.java That is what you see deleted in the integration. The 2nd test was del

Re: RFR: 4760025: sRGB conversions to and from CIE XYZ incorrect [v3]

2024-01-15 Thread Alexey Ivanov
On Fri, 12 Jan 2024 23:46:06 GMT, Sergey Bylokhov wrote: > for test execution it does not matter but when opened in ide it conflicts > with some other Error classes from the tests. I feel your pain! I suggest refactoring those tests and make their private `Error` class a static member of the

Re: RFR: 8221261: deadlock of CInputMethod.characterIndexForPoint and webkit.InputMethodClientImpl.getLocationOffset

2024-01-15 Thread Kevin Rushforth
On Fri, 22 Dec 2023 11:27:00 GMT, Johannes Bechberger wrote: > A dead-lock is caused by the interaction of MacOS, the AWTEventQueue and > JavaFX when the users pressed the Caps Lock key while the AWTEventQueue is > processing another event (more on this in the issue). The bug depends on the >

Re: RFR: 8318590: JButton ignores margin when painting HTML text [v5]

2024-01-15 Thread Goetz Lindenmaier
On Tue, 5 Dec 2023 19:07:07 GMT, Damon Nguyen wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Re-add test because still valid > > I also have updated the copyright year for BasicButtonUI. I believe that's > the on

Integrated: 8320328: Restore interrupted flag in ImageIcon.loadImage

2024-01-15 Thread Rajat Mahajan
On Fri, 12 Jan 2024 19:17:24 GMT, Rajat Mahajan wrote: > ImageIcon.loadImage used to handle InterruptedException only by printing a > message to the console. JDK-8236987 handled the interrupted state more > gracefully, but it didn't restore the interrupted flag. > This change restores the inter

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12)

2024-01-15 Thread Laurent Bourgès
On Fri, 12 Jan 2024 21:34:32 GMT, Laurent Bourgès wrote: > - new executor modes (buffer & volatile) > - support parallel rendering on several frames and / or screens > - added robot calibration + optionally use rounded duration to min frame > latency (120Hz) > - give more statistics in verbose (

Re: RFR: JDK-8323695 RenderPerf (2D) enhancements (23.12)

2024-01-15 Thread Alexey Ushakov
On Fri, 12 Jan 2024 21:34:32 GMT, Laurent Bourgès wrote: > - new executor modes (buffer & volatile) > - support parallel rendering on several frames and / or screens > - added robot calibration + optionally use rounded duration to min frame > latency (120Hz) > - give more statistics in verbose (

Re: RFR: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws and exception on Mac OS 14(x64, aarch64) [v4]

2024-01-15 Thread Sergey Bylokhov
On Mon, 15 Jan 2024 11:27:43 GMT, Sergey Bylokhov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> used jtreg.SkippedException, updated copyright years > > src/java.desktop/share/classes/sun/awt/SunToolkit.java line

Re: RFR: 8316931: [macos14] Test "java/awt/TrayIcon/ShowAfterDisposeTest/ShowAfterDisposeTest.html" throws and exception on Mac OS 14(x64, aarch64) [v4]

2024-01-15 Thread Sergey Bylokhov
On Fri, 12 Jan 2024 22:18:04 GMT, Alisen Chung wrote: >> SunToolkit.java is trying to post an event on the TrayIcon appContext, but >> the TrayIcon was already removed by the test, causing an error. The fix is >> to make SunToolkit skip posting the event if appContext is null. The test is >> a

Re: RFR: JDK-8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 [v2]

2024-01-15 Thread Laurent Bourgès
On Fri, 12 Jan 2024 20:21:52 GMT, Harshitha Onkar wrote: >> ShapeNotSetSometimes.java fails intermittently on macOS 14. Following is a >> test stabilization fix for macOS 14. With the added delays >> ShapeNotSetSometimes.java passes on older versions of macOS as well as on >> macOS 14.1, 14.2.

Re: RFR: JDK-8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14 [v2]

2024-01-15 Thread Andrey Turbanov
On Fri, 12 Jan 2024 20:21:52 GMT, Harshitha Onkar wrote: >> ShapeNotSetSometimes.java fails intermittently on macOS 14. Following is a >> test stabilization fix for macOS 14. With the added delays >> ShapeNotSetSometimes.java passes on older versions of macOS as well as on >> macOS 14.1, 14.2.