On Mon, 22 Jan 2024 07:27:50 GMT, Tejesh R wrote:
>> Vector.iterator and Vector.subList.iterator are still check for modification
>> on iteration (see usages of the method
>> `java.util.AbstractList.SubList#checkForComodification`). It means, if
>> vector was concurrently modified during itera
On Mon, 22 Jan 2024 07:11:08 GMT, Andrey Turbanov wrote:
>> Since concurrent modification exception is thrown, it is clear that the List
>> is being modified while comparing two list. Hence instead of copying the
>> list locally, I have used iterators and comparing element by element in a
>> `
On Mon, 22 Jan 2024 06:50:21 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java
>> line 417:
>>
>>> 415: }
>>> 416:
>>> 417: private synchronized boolean compareIterators(Iterator
>>> iterator1, Iterator iterator2) {
>>
>>
On Sat, 20 Jan 2024 15:05:09 GMT, Andrey Turbanov wrote:
>> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091)
>> also created concurrent exception intermittently (monthly once/quarterly
>> once) on CI system. The issue was not able to be reproduced yet, hence
>> proposin
On Fri, 19 Jan 2024 22:16:46 GMT, Phil Race wrote:
>> When using a TreeCellRenterer which creates new components in
>> getTreeCellRendererComponent() in a JTree that is not visible, changes to
>> the nodes cause a memory leak.
>> When a node is changed, the Method getNodeDimensions() is called
On Fri, 19 Jan 2024 18:03:37 GMT, Phil Race wrote:
>> src/java.desktop/share/classes/javax/swing/JScrollBar.java line 784:
>>
>>> 782: * rigid along the other axis.
>>> 783: */
>>> 784: public Dimension getMinimumSize() {
>>
>> Since we are here, you should fix this to add the @re
On Fri, 8 Dec 2023 21:55:31 GMT, Phil Race wrote:
>> More correct way to take in consideration nonzero PHYSICALOFFSETX,
>> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows
>> platform under certain conditions real device prints shifted image on paper.
>
> The PR title
On Thu, 18 Jan 2024 19:40:40 GMT, Alexander Zuev wrote:
>> Replaced asserts with NullPointerException calls because outside of testing
>> that would be more informative - i do not think many people running their
>> applications with assertions in system libraries enabled;
>> Added a code that w
On Thu, 4 May 2023 10:14:10 GMT, Martin Desruisseaux wrote:
> The `BufferedImage` Javadoc does not mention any constraint about the data
> type. In practice, `BufferedImage` with floating point values can be rendered
> by Java2D as well as integers, provided that a compatible `ColorModel` was
On Sun, 21 Jan 2024 07:55:16 GMT, Julian Waters wrote:
> Fixed the formatting (at least in the marked cases), but am unsure what you
> mean by set directly?
See my comment
"like in my recoded case above, we no longer need the "pData" var which was
there only because that name
is magically kno
On Sat, 20 Jan 2024 10:15:02 GMT, Sam James wrote:
> This fixes building with GCC 14:
> * Cherry-pick a fix from Harfbuzz upstream
> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources
>
> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses
> -Werror.
>
> The
On Sun, 21 Jan 2024 16:42:40 GMT, Sam James wrote:
> > No problem!
>
> Many thanks!
>
> > Just change your Pull Request title to 8324243 (The literal number) and
> > watch the magic happen :)
> > By the way, your name strikes me as familiar. Have I seen you before on the
> > gcc mailing lists
On Sat, 20 Jan 2024 10:15:02 GMT, Sam James wrote:
> This fixes building with GCC 14:
> * Cherry-pick a fix from Harfbuzz upstream
> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources
>
> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses
> -Werror.
>
> The
On Sun, 21 Jan 2024 07:09:54 GMT, Julian Waters wrote:
> No problem!
>
Many thanks!
> Just change your Pull Request title to 8324243 (The literal number) and watch
> the magic happen :)
>
> By the way, your name strikes me as familiar. Have I seen you before on the
> gcc mailing lists?
You
On Sun, 21 Jan 2024 04:57:26 GMT, Julian Waters wrote:
> @thesamesam Unfortunately we can't fix the harfbuzz sources, since they are
> third party code. Your changes to harfbuzz code wouldn't be accepted by the
> client team :(
Bleh. I don't suppose any exception can be made given it's a cherr
On Sat, 20 Jan 2024 10:15:02 GMT, Sam James wrote:
> This fixes building with GCC 14:
> * Cherry-pick a fix from Harfbuzz upstream
> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources
>
> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses
> -Werror.
>
> The
On Sat, 20 Jan 2024 10:15:02 GMT, Sam James wrote:
> This fixes building with GCC 14:
> * Cherry-pick a fix from Harfbuzz upstream
> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources
>
> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses
> -Werror.
>
> The
This fixes building with GCC 14:
* Cherry-pick a fix from Harfbuzz upstream
* Apply other `-Wcalloc-transposed-args` fixes to the JDK sources
-Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses
-Werror.
The calloc prototype is:
void *calloc(size_t nmemb, size_t size);
So,
> The `BufferedImage` Javadoc does not mention any constraint about the data
> type. In practice, `BufferedImage` with floating point values can be rendered
> by Java2D as well as integers, provided that a compatible `ColorModel` was
> supplied at construction time. However calls to `setData(Ras
On Thu, 18 Jan 2024 21:35:37 GMT, Phil Race wrote:
>> Of course, I will make constant Font instances (no new Font() in benchmark
>> code!) and use family name (Dialog or SansSerif), what do you prefer?
>
> either dialog or sansserif. Dialog is the default font so perhaps that.
Dialog by default
20 matches
Mail list logo
