> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
Hi Philip,
Thanks for a quick response. I will reply inline.
On 2024-02-23 06:11, Philip Race wrote:
> First, thank you for raising it this way rather than submitting a PR !
>
> In general things that compatibly and safely improve the user experience
> are welcome.
>
> So at a high level, yes.
First, thank you for raising it this way rather than submitting a PR !
In general things that compatibly and safely improve the user experience
are welcome.
So at a high level, yes. So the next level is the details to think about
it more ?
How important is smooth scrolling ? I've never noti
On Thu, 22 Feb 2024 11:11:01 GMT, Abhishek Kumar wrote:
> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed.
> Behavior is not similar to windows native application. Fix is to ensure that
> menu mnemonic state toggles between show and hide.
>
> Can be verified with S
Hello,
I would like to add smooth scrolling support to sun.awt.X11. At this
point of time I already have this feature implemented. The code can be
considered proof of concept right now, but it works and doesn't
introduce regressions in all test scenarios I've done so far.
Is this something that T
On Thu, 22 Feb 2024 14:08:36 GMT, Christoph Langer wrote:
> I think that's hard to find out. At least our regression testing did not show
> issues. The change probably needs more testing. On the other hand, I think
> the risk with that change is low since the environment that is addressed by
>
On Tue, 20 Feb 2024 21:01:11 GMT, Alisen Chung wrote:
>> Root cause of the test failure was fixed with
>> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
>> other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one addi
On Thu, 22 Feb 2024 17:16:56 GMT, Alisen Chung wrote:
>> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java
>> line 89:
>>
>>> 87: frame.setVisible(true);
>>> 88:
>>> 89: System.setProperty("sun.awt.exception.handler\n",
>>
>> Why is there \n in
On Thu, 22 Feb 2024 16:28:40 GMT, Per Minborg wrote:
>> src/java.desktop/unix/classes/sun/awt/X11/XEmbeddingContainer.java line 150:
>>
>>> 148: }
>>> 149: } finally {
>>> 150: Reference.reachabilityFence(data);
>>
>> Can you explain the need for this
On Thu, 22 Feb 2024 16:55:17 GMT, Alexander Zuev wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test strings and newlines, remove else
>
> test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInAction
On Tue, 20 Feb 2024 21:01:11 GMT, Alisen Chung wrote:
>> Root cause of the test failure was fixed with
>> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
>> other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one addi
On Wed, 21 Feb 2024 22:45:17 GMT, Brent Christian wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Suppress restricted warning
>
> src/java.desktop/unix/classes/sun/awt/X11/XEmbeddingContainer.java line 150:
>
>> 14
On Fri, 16 Feb 2024 22:46:26 GMT, Phil Race wrote:
> So if it is resolved as removing the test we'll have no open bug and no test
> .. both for an as yet unresolved problem.
> If this test is removed there needs to be a new bug with this test attached
> as a test case
I can create a new bug an
On Fri, 16 Feb 2024 21:50:09 GMT, Phil Race wrote:
> The first thing I worry about here is that the obvious implication is that we
> can now have zero monitors. Even if the monitor were not usable, that seems
> to have been "OK" in practice so long as we didn't assert out in a debug
> build. H
On Fri, 9 Feb 2024 14:59:06 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test with 'PassFailJFrame' with programmatically
> generating image and print , please review and let me know your suggestions.
This pull request has now been integrated.
Changeset: 724a2a2
On Thu, 22 Feb 2024 13:52:23 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> I have updated the test with 'PassFailJFrame' with programmatically
>> generating image and print , please review and let me know your suggestions.
>
> Renjith Kannath Pariyangad has updated the pull request
> Hi Reviewers,
> I have updated the test with 'PassFailJFrame' with programmatically
> generating image and print , please review and let me know your suggestions.
Renjith Kannath Pariyangad has updated the pull request incrementally with one
additional commit since the last revision:
Remove
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
Menu mnemonic doesn't toggle between show and hide state when F10 is pressed.
Behavior is not similar to windows native application. Fix is to ensure that
menu mnemonic state toggles between show and hide.
Can be verified with SwingSet2 application.
CI tests are green with the fix. Link posted
On Thu, 15 Feb 2024 15:41:57 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Replaced skipped exception with runtime exception
>
> test/jdk/java/awt/PrintJob/ImageTest/ImageTest.jav
On Wed, 14 Feb 2024 18:09:15 GMT, Per Minborg wrote:
>> This PR proposes to remove the use of `Unsafe` in the class
>> `XEmbeddingContainer ` and replace it with the supported FFM API.
>>
>> I tried to make this PR as small as possible while opening up for migration
>> of other classes later o
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
On Thu, 28 Dec 2023 09:48:52 GMT, Matthias Baesken wrote:
> When running with fastdebug binaries we run intermittent into the issue below
> in
> jtreg test
> java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java .
> Seems we miss checking of successful HBITMAP creation befor
On Mon, 19 Feb 2024 13:04:47 GMT, Matthias Baesken wrote:
> In AccessBridgeJavaEntryPoints.cpp we have a couple of exception checks with
> potential early returns. Those miss ReleaseStringChars .
> In other words, this CHECK should be placed next to where I can see the call
> that requires it.
On Fri, 12 Jan 2024 21:34:32 GMT, Laurent Bourgès wrote:
> - new executor modes (buffer & volatile)
> - support parallel rendering on several frames and / or screens
> - added robot calibration + optionally use rounded duration to min frame
> latency (120Hz)
> - give more statistics in verbose (
On Thu, 22 Feb 2024 06:35:19 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
28 matches
Mail list logo
