Re: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v7]

2024-02-29 Thread Phil Race
On Thu, 29 Feb 2024 22:24:14 GMT, Christoph Langer wrote: >> The assertions reported in the bug were observed spuriously and here and >> there broke tests in some Windows configurations. >> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), >> [JDK-8269529](https://bugs.op

RFR: 8195675: Call to insertText with single character from custom Input Method ignored

2024-02-29 Thread Steven Loomis
8195675: Call to insertText with single character from custom Input Method ignored - Commit messages: - 8195675: Update AWTView.m - 8195675: [MacOS] fix Keyman input methods on mac Changes: https://git.openjdk.org/jdk/pull/17921/files Webrev: https://webrevs.openjdk.org/?repo=jdk

Re: RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails

2024-02-29 Thread Prasanta Sadhukhan
On Thu, 29 Feb 2024 09:34:05 GMT, Prasanta Sadhukhan wrote: > Test failed with the exception java.lang.IllegalArgumentException: (start <= > value <= end) with no history of failing till date. > Investigation shows SpinnerDateModel constructor condition is not satisfied > because > It seems it

Integrated: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14

2024-02-29 Thread Prasanta Sadhukhan
On Thu, 29 Feb 2024 11:00:33 GMT, Prasanta Sadhukhan wrote: > javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java > is failing in macos14 due to apple os upgrade. More information in > [JDK-8316151](https://bugs.openjdk.org/browse/JDK-8316151) > problemlist the t

Re: RFR: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14

2024-02-29 Thread Guoxiong Li
On Thu, 29 Feb 2024 11:00:33 GMT, Prasanta Sadhukhan wrote: > javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java > is failing in macos14 due to apple os upgrade. More information in > [JDK-8316151](https://bugs.openjdk.org/browse/JDK-8316151) > problemlist the t

Re: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v7]

2024-02-29 Thread Christoph Langer
> The assertions reported in the bug were observed spuriously and here and > there broke tests in some Windows configurations. > For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), > [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or > [JDK-8323664](https://bugs.o

Re: RFR: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14

2024-02-29 Thread Phil Race
On Thu, 29 Feb 2024 11:00:33 GMT, Prasanta Sadhukhan wrote: > javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java > is failing in macos14 due to apple os upgrade. More information in > [JDK-8316151](https://bugs.openjdk.org/browse/JDK-8316151) > problemlist the t

Re: RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails

2024-02-29 Thread Phil Race
On Thu, 29 Feb 2024 09:34:05 GMT, Prasanta Sadhukhan wrote: > Test failed with the exception java.lang.IllegalArgumentException: (start <= > value <= end) with no history of failing till date. > Investigation shows SpinnerDateModel constructor condition is not satisfied > because > It seems it

Re: RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails

2024-02-29 Thread Phil Race
On Thu, 29 Feb 2024 09:34:05 GMT, Prasanta Sadhukhan wrote: > Test failed with the exception java.lang.IllegalArgumentException: (start <= > value <= end) with no history of failing till date. > Investigation shows SpinnerDateModel constructor condition is not satisfied > because > It seems it

Re: RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails

2024-02-29 Thread Alexandre Iline
On Thu, 29 Feb 2024 09:34:05 GMT, Prasanta Sadhukhan wrote: > Test failed with the exception java.lang.IllegalArgumentException: (start <= > value <= end) with no history of failing till date. > Investigation shows SpinnerDateModel constructor condition is not satisfied > because > It seems it

Re: RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails

2024-02-29 Thread Alexandre Iline
On Thu, 29 Feb 2024 09:34:05 GMT, Prasanta Sadhukhan wrote: > Test failed with the exception java.lang.IllegalArgumentException: (start <= > value <= end) with no history of failing till date. > Investigation shows SpinnerDateModel constructor condition is not satisfied > because > It seems it

Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v3]

2024-02-29 Thread Abhishek Kumar
On Thu, 29 Feb 2024 11:02:35 GMT, Alexey Ivanov wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comment update > > src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsMenuBarUI.java >

Re: RFR: 8185862: AWT Assertion Failure in ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) 'awt_Win32GraphicsDevice.cpp', at line 185 [v6]

2024-02-29 Thread Christoph Langer
On Fri, 23 Feb 2024 13:44:15 GMT, Christoph Langer wrote: >> The assertions reported in the bug were observed spuriously and here and >> there broke tests in some Windows configurations. >> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129), >> [JDK-8269529](https://bugs.op

RFR: 8286759: TextComponentPrintable: consequent -> consecutive positions

2024-02-29 Thread Alexey Ivanov
A trivial change in a comment: consequent → _consecutive_ positions. This was found in [a code review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for [JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285306). - Commit messages: - 8286759: TextComponentPrintab

RFR: 8327040: Problemlist ActionListenerCalledTwiceTest.java test failing in macos14

2024-02-29 Thread Prasanta Sadhukhan
javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java is failing in macos14 due to apple os upgrade. More information in [JDK-8316151](https://bugs.openjdk.org/browse/JDK-8316151) problemlist the test for now.. - Commit messages: - 8327040: Problemlist

Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v2]

2024-02-29 Thread Alexey Ivanov
On Thu, 29 Feb 2024 07:42:44 GMT, Abhishek Kumar wrote: > > This needs testing with popup menus and combobox popups. > > Popup menus doesn't show mnemonics in windows LAF by default. On press of alt > or F10, popup menu windows becomes invisible. This statement is generally false. Popup menus

Re: RFR: 8326458: Menu mnemonic doesn't toggle between show and hide in Windows LAF when F10 is pressed. [v3]

2024-02-29 Thread Alexey Ivanov
On Thu, 29 Feb 2024 07:48:09 GMT, Abhishek Kumar wrote: >> Menu mnemonic doesn't toggle between show and hide state when F10 is >> pressed. Behavior is not similar to windows native application. Fix is to >> ensure that menu mnemonic state toggles between show and hide. >> >> Can be verified w

Integrated: 8326948: Force English locale for timeout formatting

2024-02-29 Thread Alexey Ivanov
On Wed, 28 Feb 2024 12:20:04 GMT, Alexey Ivanov wrote: > If a test runs in non-English locale, the digits displayed in the timeout > could be locale-specific, which may be confusing. > > For example, in the Arabic locale `-Duser.language=ar`, the timeout is > displayed like this: > > Test tim

RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails

2024-02-29 Thread Prasanta Sadhukhan
Test failed with the exception java.lang.IllegalArgumentException: (start <= value <= end) with no history of failing till date. Investigation shows SpinnerDateModel constructor condition is not satisfied because It seems it's a leap year problem that is being manifested.. As per test, initDate

Re: RFR: 8326948: Force English locale for timeout formatting

2024-02-29 Thread Guoxiong Li
On Wed, 28 Feb 2024 12:20:04 GMT, Alexey Ivanov wrote: > If a test runs in non-English locale, the digits displayed in the timeout > could be locale-specific, which may be confusing. > > For example, in the Arabic locale `-Duser.language=ar`, the timeout is > displayed like this: > > Test tim

Integrated: JDK-8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns

2024-02-29 Thread Matthias Baesken
On Mon, 19 Feb 2024 13:04:47 GMT, Matthias Baesken wrote: > In AccessBridgeJavaEntryPoints.cpp we have a couple of exception checks with > potential early returns. Those miss ReleaseStringChars . This pull request has now been integrated. Changeset: d9ef16db Author:Matthias Baesken URL:

Re: RFR: JDK-8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns [v2]

2024-02-29 Thread Matthias Baesken
On Wed, 28 Feb 2024 13:30:18 GMT, Matthias Baesken wrote: >> In AccessBridgeJavaEntryPoints.cpp we have a couple of exception checks with >> potential early returns. Those miss ReleaseStringChars . > > Matthias Baesken has updated the pull request incrementally with one > additional commit sinc