On Tue, 5 Mar 2024 18:20:39 GMT, Alexey Ivanov wrote:
> It looks good to me.
>
> The only question I have is for the fallback in `awt_Win32GraphicsDevice.cpp`.
>
> Bailing out quickly makes the code cleaner. In this case, if `::GetDIBits`
> fails, we can bail out too.
>
> If the fallback is n
On Wed, 6 Mar 2024 07:50:08 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>> [JDK-8269529](https://bugs.ope
On Tue, 5 Mar 2024 18:00:51 GMT, Alexey Ivanov wrote:
>> Christoph Langer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> load awt.dll before display check
>
> src/java.desktop/windows/classes/sun/awt/PlatformGraphicsInfo.java line 35:
>
> The assertions reported in the bug were observed spuriously and here and
> there broke tests in some Windows configurations.
> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
> [JDK-8269529](https://bugs.openjdk.org/browse/JDK-8269529) or
> [JDK-8323664](https://bugs.o
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
On Tue, 5 Mar 2024 13:07:30 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Updated instruction
>
> test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java line 74:
>
>> 72:
On Thu, 22 Feb 2024 11:11:01 GMT, Abhishek Kumar wrote:
> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed.
> Behavior is not similar to windows native application. Fix is to ensure that
> menu mnemonic state toggles between show and hide.
>
> Can be verified with S
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
On Fri, 16 Feb 2024 08:45:59 GMT, Christoph Langer wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsDevice.cpp
>> line 191:
>>
>>> 189: return;
>>> 190: }
>>> 191: VERIFY(::GetDIBits(hBMDC, hBM, 0, 1, NULL, gpBitmapInfo,
>>> DIB_RGB_COLORS));
>>
>> I t
On Fri, 1 Mar 2024 08:01:08 GMT, Christoph Langer wrote:
>> The assertions reported in the bug were observed spuriously and here and
>> there broke tests in some Windows configurations.
>> For instance [JDK-8266129](https://bugs.openjdk.org/browse/JDK-8266129),
>> [JDK-8269529](https://bugs.ope
> The implementation of `Win32ShellFolder2.compareTo` is inconsistent: there
> are cases where
> `a < b & b < c but a == c`
> which *violates its general contract*.
>
> In particular, it happens for the personal folder (*Documents*) if it is
> listed *twice*: as a special and as a regular fo
The implementation of `Win32ShellFolder2.compareTo` is inconsistent: there are
cases where
`a < b & b < c but a == c`
which *violates its general contract*.
In particular, it happens for the personal folder (*Documents*) if it is listed
*twice*: as a special and as a regular folder.
The eva
Thanks, this was educational. I never even thought about how localization
might affect all this.
-Original Message-
From: Aleksei Ivanov
Sent: Tuesday, March 5, 2024 10:41 AM
To: Yagnatinsky, Mark : Markets Pre Trade ;
micklen...@gmail.com; client-libs-dev@openjdk.org
Subject: Re: how
On Mon, 4 Mar 2024 18:10:04 GMT, Phil Race wrote:
> And capitalise "We", and "In" since they begin sentences
I agree, yet it's not always followed in the comments.
> If we are going to fix that, we might as well fix the entire sentence.
Thank you for your suggestion. The sentence didn't sound
> A trivial change in a comment: consequent → _consecutive_ positions.
>
> This was found in [a code
> review](https://github.com/openjdk/jdk/pull/8328#discussion_r872596373) for
> [JDK-8285306](https://bugs.openjdk.org/browse/JDK-8285306).
Alexey Ivanov has updated the pull request incremental
Hello Mark,
As far as I know, the shortcuts are localisable. For example, you use
Ctrl+S to save a file in an English version, yet users of Spanish
version of Windows use Ctrl+G (for Guardar) instead.
At the same time, the most common actions — Cut, Copy and Paste as well
as Undo and Redo —
On Tue, 13 Feb 2024 12:06:46 GMT, Renjith Kannath Pariyangad
wrote:
>> test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 48:
>>
>>> 46: "For non-windows OS, this test PASSes.\n" +
>>> 47: "You must have at least 2 printers available to perform
>>> this test.
On Mon, 4 Mar 2024 06:48:18 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know y
On Mon, 4 Mar 2024 06:33:09 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know y
On Mon, 4 Mar 2024 06:33:09 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know y
On Tue, 5 Mar 2024 10:44:53 GMT, Tejesh R wrote:
>> Maxim Kartashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Made the test to waitForIdle()
>
> test/jdk/java/awt/Frame/Iconify/IconifiedToFront.java line 41:
>
>> 39:
>> 40: publi
On Tue, 13 Feb 2024 14:01:40 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Fixed compiler error
>
> test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 53:
>
>> 51:
On Mon, 4 Mar 2024 06:04:07 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know y
On Tue, 5 Mar 2024 12:17:07 GMT, Alexey Ivanov wrote:
>>>private static final int EXPECTED = 5;
>>
>> this var is used only in main, so I kept it as local variable.
>
> There's a difference between _a local variable_ that it is now and _a
> constant_ declared at the class level. In the latter c
On Tue, 5 Mar 2024 12:27:28 GMT, Abhishek Kumar wrote:
>> Menu mnemonic doesn't toggle between show and hide state when F10 is
>> pressed. Behavior is not similar to windows native application. Fix is to
>> ensure that menu mnemonic state toggles between show and hide.
>>
>> Can be verified wi
> Menu mnemonic doesn't toggle between show and hide state when F10 is pressed.
> Behavior is not similar to windows native application. Fix is to ensure that
> menu mnemonic state toggles between show and hide.
>
> Can be verified with SwingSet2 application.
> CI tests are green with the fix.
On Tue, 5 Mar 2024 12:13:05 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JMenuBar/TestMenuMnemonic.java line 58:
>>
>>> 56: public static void main(String[] args) throws Exception {
>>> 57:
>>> UIManager.setLookAndFeel("com.sun.java.swing.plaf.windows.WindowsLookAndFeel");
>>>
On Tue, 5 Mar 2024 11:44:56 GMT, Alexey Ivanov wrote:
>private static final int EXPECTED = 5;
this var is used only in main, so I kept it as local variable.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/17961#discussion_r1512718810
On Tue, 5 Mar 2024 06:08:00 GMT, Abhishek Kumar wrote:
>> Menu mnemonic doesn't toggle between show and hide state when F10 is
>> pressed. Behavior is not similar to windows native application. Fix is to
>> ensure that menu mnemonic state toggles between show and hide.
>>
>> Can be verified wi
On Tue, 5 Mar 2024 11:07:13 GMT, Alexey Ivanov wrote:
>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
>> synchronized.
>>
>> Without synchronization, a thread checks if `filesLoader` is not null and
>> creates a new `FilesLoader` thread. If the thread is pre-empted betw
On Tue, 5 Mar 2024 08:18:38 GMT, Prasanta Sadhukhan
wrote:
> Also, the enabled state are still not handled
The enabled state is not handled in Metal LAF also, tried adding the
enabledText property by setting ui property --
`UIManager.getDefaults().put("CheckBox.enabledText", checkboxColor);`
On Tue, 5 Mar 2024 09:24:52 GMT, Andrey Turbanov wrote:
>> Alexey Ivanov has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Replace synchronized invalidateFileCache with synchronized block inside
>> - Declare DoChangeContents constructo
> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
> synchronized.
>
> Without synchronization, a thread checks if `filesLoader` is not null and
> creates a new `FilesLoader` thread. If the thread is pre-empted between these
> two operations, another thread or even several t
On Tue, 5 Mar 2024 00:48:13 GMT, Sergey Bylokhov wrote:
>> Alexey Ivanov has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Replace synchronized invalidateFileCache with synchronized block inside
>> - Declare DoChangeContents constructo
On Tue, 5 Mar 2024 10:16:58 GMT, Maxim Kartashev wrote:
>> XToolkit implements `toFront()` essentially by sending the
>> `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when
>> the target window is in the iconified state. So the fix is to cancel that
>> state prior to
On Tue, 5 Mar 2024 09:31:25 GMT, Tejesh R wrote:
>> Maxim Kartashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed for Windows also
>>
>> And made the test not dependent on swing.
>
> test/jdk/java/awt/Frame/Iconify/Iconified
> XToolkit implements `toFront()` essentially by sending the
> `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when
> the target window is in the iconified state. So the fix is to cancel that
> state prior to sending the message.
>
> The test verifies that the fix works
On Tue, 5 Mar 2024 08:55:05 GMT, Maxim Kartashev wrote:
>> XToolkit implements `toFront()` essentially by sending the
>> `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when
>> the target window is in the iconified state. So the fix is to cancel that
>> state prior to
On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov wrote:
> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
> synchronized.
>
> Without synchronization, a thread checks if `filesLoader` is not null and
> creates a new `FilesLoader` thread. If the thread is pre-empted between t
On Fri, 23 Feb 2024 21:51:30 GMT, Phil Race wrote:
>> XToolkit implements `toFront()` essentially by sending the
>> `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when
>> the target window is in the iconified state. So the fix is to cancel that
>> state prior to sendi
On Mon, 4 Mar 2024 20:21:30 GMT, Alexey Ivanov wrote:
> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
> synchronized.
>
> Without synchronization, a thread checks if `filesLoader` is not null and
> creates a new `FilesLoader` thread. If the thread is pre-empted between t
> XToolkit implements `toFront()` essentially by sending the
> `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when
> the target window is in the iconified state. So the fix is to cancel that
> state prior to sending the message.
>
> The test verifies that the fix works
On Tue, 5 Mar 2024 05:28:01 GMT, Abhishek Kumar wrote:
>> JLabel text is not painted with the LAF defined foreground color in GTK LAF.
>> In GTK LAF the foreground color is retrieved by using native system APIs.
>> Fix is to return the foreground color if it is set by LAF defined property
>> o
On Tue, 5 Mar 2024 06:54:40 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JRadioButton/4314194/bug4314194.java line 43:
>>
>>> 41: import javax.swing.UIManager;
>>> 42: import javax.swing.UnsupportedLookAndFeelException;
>>> 43: import javax.swing.plaf.nimbus.NimbusLookAndFeel;
>>
>> this
45 matches
Mail list logo
