Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v4]

2024-04-11 Thread Abhishek Kumar
On Fri, 12 Apr 2024 04:06:09 GMT, Tejesh R wrote: >> Fix suggested in bug >> [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720) >> had a regression in Nimbus L&F yet it resolved the issue in other L&F. The >> better approach would be to handle `MultiResol

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-11 Thread Abhishek Kumar
On Mon, 8 Apr 2024 07:57:11 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame along with printer availability >> check. Please review and let me know your suggestions. >> >> Renjith. > > Renjith Kannath Pariyangad has updated the pull re

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-11 Thread Abhishek Kumar
On Fri, 12 Apr 2024 05:15:53 GMT, Renjith Kannath Pariyangad wrote: > Its working for me, please make sure you have configured pdf printer as your > default printer. In this test there is no option to select printer. Yeah... default was set to physical printer which is currently inaccessible.

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-11 Thread Renjith Kannath Pariyangad
On Mon, 8 Apr 2024 07:57:11 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame along with printer availability >> check. Please review and let me know your suggestions. >> >> Renjith. > > Renjith Kannath Pariyangad has updated the pull re

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-11 Thread Abhishek Kumar
On Fri, 12 Apr 2024 04:30:34 GMT, Renjith Kannath Pariyangad wrote: > Yes this will work on Print to pdf, I don't think physical printer is must. I am getting this dialog message "Printer status is not available at this time." - PR Comment: https://git.openjdk.org/jdk/pull/18624#i

Re: RFR: 8289770: Drop IS_WINVISTA macro from ShellFolder2.cpp

2024-04-11 Thread Tejesh R
On Thu, 11 Apr 2024 09:33:09 GMT, Alexey Ivanov wrote: > This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`. > > `IS_WINVISTA` was not used at all. > > `IS_WINXP` guarded support for icons with alpha channel. It is now safe to > assume Java runs on a Windows version

Re: RFR: 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame [v2]

2024-04-11 Thread Renjith Kannath Pariyangad
On Mon, 8 Apr 2024 07:57:11 GMT, Renjith Kannath Pariyangad wrote: >> Hi Reviewers, >> >> I have updated the test with PassFailJFrame along with printer availability >> check. Please review and let me know your suggestions. >> >> Renjith. > > Renjith Kannath Pariyangad has updated the pull re

Re: RFR: 8322140: javax/swing/JTable/JTableScrollPrintTest.java does not print the rows and columns of the table in Nimbus and Aqua LookAndFeel [v4]

2024-04-11 Thread Tejesh R
> Fix suggested in bug > [8210807](https://github.com/openjdk/jdk/commit/38bbbe7588c94d3a0edd1c120ba49cbd0851a720) > had a regression in Nimbus L&F yet it resolved the issue in other L&F. The > better approach would be to handle `MultiResolutionImages `in `PathGraphics` > class `getBufferedImag

Re: RFR: 8326734: text-decoration applied to lost when mixed with or [v2]

2024-04-11 Thread Harshitha Onkar
On Thu, 11 Apr 2024 17:20:12 GMT, Alexey Ivanov wrote: >> The value of the >> [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS >> property is not inherited correctly in Swing. If the `` element is >> mixed with `` or ``, only the value from the `style` attribute of >>

Re: RFR: 8303689: javac -Xlint could/should report on "dangling" doc comments [v2]

2024-04-11 Thread Jonathan Gibbons
> Please review the updates to support a proposed new > `-Xlint:dangling-doc-comments` option. > > The work can be thought of as in 3 parts: > > 1. An update to the `javac` internal class `DeferredLintHandler` so that it > is possible to specify the appropriately configured `Lint` object when i

Re: RFR: 8326734: text-decoration applied to lost when mixed with or [v2]

2024-04-11 Thread Alexey Ivanov
On Tue, 9 Apr 2024 20:24:06 GMT, Phil Race wrote: >> Because you didn't add the backticks ` around your sample, it's >> interpreted as HTML, and I can't really see it. >> >> I guess, the code was something line this: ``. >> >> If the both tags have the same value for the `text-decoration` prop

Re: RFR: 8326734: text-decoration applied to lost when mixed with or [v2]

2024-04-11 Thread Alexey Ivanov
> The value of the > [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS > property is not inherited correctly in Swing. If the `` element is > mixed with `` or ``, only the value from the `style` attribute of > `` is applied. > > The fix to this issue is not as simple as

Re: RFR: 8326734: text-decoration applied to lost when mixed with or

2024-04-11 Thread Alexey Ivanov
On Tue, 9 Apr 2024 20:59:53 GMT, Harshitha Onkar wrote: >> I'm pretty sure there are other cases where `text-decoration` isn't resolved >> correctly. It is not a goal to resolve all of the possible issues. >> >> I'll check whether this scenario can be handled easily. I don't think it is. >> If

Re: RFR: 8321428: Deprecate for removal the package java.beans.beancontext [v4]

2024-04-11 Thread Alexey Ivanov
On Wed, 10 Apr 2024 21:25:06 GMT, Larry Cable wrote: >> the beancontext package was added (by me) in JDK 1.2 to provide >> JavaBeans(tm) with a containment and services hierarchy. >> >> based upon concepts from OpenDoc, which was a popular component model at the >> time, the API pre-dated the

Re: RFR: 8330107: Split Awt2dLibraries.gmk into separate AWT and 2D files

2024-04-11 Thread Magnus Ihse Bursie
On Thu, 11 Apr 2024 13:53:23 GMT, Magnus Ihse Bursie wrote: > The file to build most of the java.desktop native libraries, t > Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate. > > I want to split it into two parts, one for the AWT libraries, and one for the > 2D libra

Re: RFR: 8330107: Split Awt2dLibraries.gmk into separate AWT and 2D files

2024-04-11 Thread Magnus Ihse Bursie
On Thu, 11 Apr 2024 13:53:23 GMT, Magnus Ihse Bursie wrote: > The file to build most of the java.desktop native libraries, t > Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate. > > I want to split it into two parts, one for the AWT libraries, and one for the > 2D libra

RFR: 8330107: Split Awt2dLibraries.gmk into separate AWT and 2D files

2024-04-11 Thread Magnus Ihse Bursie
The file to build most of the java.desktop native libraries, t Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate. I want to split it into two parts, one for the AWT libraries, and one for the 2D libraries. I also used this opportunity to change the order to be more logic

Re: RFR: 8289770: Drop IS_WINVISTA macro from ShellFolder2.cpp

2024-04-11 Thread Julian Waters
On Thu, 11 Apr 2024 09:33:09 GMT, Alexey Ivanov wrote: > This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`. > > `IS_WINVISTA` was not used at all. > > `IS_WINXP` guarded support for icons with alpha channel. It is now safe to > assume Java runs on a Windows version

Re: RFR: 8314592: Add shortcut to SymbolLookup::find

2024-04-11 Thread Maurizio Cimadamore
On Mon, 25 Mar 2024 14:56:23 GMT, Per Minborg wrote: > While `SymbolLookup` correctly uses an `Optional` return to denote whether a > symbol has been found by the lookup or not (which enables composition of > symbol lookups), many clients end up just calling `Optional::get`, or > `Optional::or

Re: RFR: 8314592: Add shortcut to SymbolLookup::find

2024-04-11 Thread Maurizio Cimadamore
On Mon, 25 Mar 2024 14:56:23 GMT, Per Minborg wrote: > While `SymbolLookup` correctly uses an `Optional` return to denote whether a > symbol has been found by the lookup or not (which enables composition of > symbol lookups), many clients end up just calling `Optional::get`, or > `Optional::or

RFR: 8314592: Add shortcut to SymbolLookup::find

2024-04-11 Thread Per Minborg
While `SymbolLookup` correctly uses an `Optional` return to denote whether a symbol has been found by the lookup or not (which enables composition of symbol lookups), many clients end up just calling `Optional::get`, or `Optional::orElseThrow()` on the result. This PR proposes to add a convenie

RFR: 8289770: Drop IS_WINVISTA macro from ShellFolder2.cpp

2024-04-11 Thread Alexey Ivanov
This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`. `IS_WINVISTA` was not used at all. `IS_WINXP` guarded support for icons with alpha channel. It is now safe to assume Java runs on a Windows version later than Windows XP. Java launchers specify 6.0 as the minimum OS