On Wed, 17 Apr 2024 06:18:39 GMT, Tejesh R wrote:
>> The logical || operator doesn't check second condition if first condition is
>> true. It checks second condition only if first one is false.
>> So as per current logic, if RED component is not equal, it doesn't check for
>> GREEN and BLUE com
On Wed, 17 Apr 2024 06:24:51 GMT, Tejesh R wrote:
>> Exactly, similar thing applies to && and hence in failure condition ||
>> checks for all the colors while && drops off at first failure only. Which is
>> why I suggested it would be better for failure cases.
>
> Yeah, its `!=` here right, the
On Wed, 17 Apr 2024 04:31:16 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is m
On Wed, 17 Apr 2024 06:09:32 GMT, Abhishek Kumar wrote:
>> I meant to use `&&` so that comparisons for failure case fails faster than
>> `||`.
>> Similar to this:
>> ` if ((c1.getRed() == c2.getRed())
>> && (c1.getBlue() == c2.getBlue())
>> && (c1.getGreen() == c2.getGre
On Wed, 17 Apr 2024 05:45:38 GMT, Tejesh R wrote:
>>> This condition can be optimized since the test is done for all LAF and for
>>> each this method is called twice. Instead of using ||, using && would
>>> optimized slightly. You can check for `true` where it checks for `==` and
>>> returns t
On Wed, 17 Apr 2024 05:17:03 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JComboBox/DisabledComboBoxFontTestAuto.java line 125:
>>
>>> 123: private static boolean isColorMatching(Color c1, Color c2) {
>>> 124: if ((c1.getRed() != c2.getRed())
>>> 125: || (c1.getBlue
On Wed, 17 Apr 2024 04:25:43 GMT, Tejesh R wrote:
> This condition can be optimized since the test is done for all LAF and for
> each this method is called twice. Instead of using ||, using && would
> optimized slightly. You can check for `true` where it checks for `==` and
> returns true. Its
On Wed, 17 Apr 2024 04:06:34 GMT, Tejesh R wrote:
> I guess `testDir` can be moved inside `testMethod()` method where it is used.
Updated.
-
PR Comment: https://git.openjdk.org/jdk/pull/18644#issuecomment-2060326726
On Tue, 16 Apr 2024 04:16:26 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is m
> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
> reason behind this issue was the size of image which is different and that
> results in incorrect pixel comparison. Fix is to ensure that correct pixel is
> matched and the pixel color should remain within tolerance.
>
On Tue, 16 Apr 2024 04:16:26 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is m
On Tue, 16 Apr 2024 04:16:26 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is m
On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie wrote:
>> The file to build most of the java.desktop native libraries,
>> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>>
>> I want to split it into two parts, one for the AWT libraries, and one for
>> the 2D li
On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie wrote:
>> The file to build most of the java.desktop native libraries,
>> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>>
>> I want to split it into two parts, one for the AWT libraries, and one for
>> the 2D li
On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie wrote:
>> The file to build most of the java.desktop native libraries,
>> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>>
>> I want to split it into two parts, one for the AWT libraries, and one for
>> the 2D li
On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie wrote:
>> The file to build most of the java.desktop native libraries,
>> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>>
>> I want to split it into two parts, one for the AWT libraries, and one for
>> the 2D li
On Mon, 1 Apr 2024 21:29:09 GMT, Harshitha Onkar wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition combined
>
> Changes requested by honkar (Reviewer).
@honkar-jdk There are few changes after you last re
On Mon, 15 Apr 2024 14:02:56 GMT, Per Minborg wrote:
>> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
>> symbol has been found by the lookup or not (which enables composition of
>> symbol lookups), many clients end up just calling `Optional::get`, or
>> `Optional
On Tue, 16 Apr 2024 06:58:19 GMT, Sergey Bylokhov wrote:
>> This clean-up PR removes unused Windows version macro from
>> `ShellFolder2.cpp`.
>>
>> `IS_WINVISTA` was not used at all.
>>
>> `IS_WINXP` guarded support for icons with alpha channel. It is now safe to
>> assume Java runs on a Wind
On Fri, 12 Apr 2024 22:44:35 GMT, Phil Race wrote:
>> @prrace I will need your assistance in confirming that my understanding
>> about the AWT vs 2D split is correct. In particular, `libosxui` gave me some
>> headache, but after trying to dig into the code my understanding ended up
>> being th
> The file to build most of the java.desktop native libraries,
> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>
> I want to split it into two parts, one for the AWT libraries, and one for the
> 2D libraries. I also used this opportunity to change the order to be mor
> The file to build most of the java.desktop native libraries,
> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>
> I want to split it into two parts, one for the AWT libraries, and one for the
> 2D libraries. I also used this opportunity to change the order to be mor
On Tue, 16 Apr 2024 07:13:02 GMT, Sergey Bylokhov wrote:
>> Updated.
>
> Can the initial bug "JComboBox has correct font color when disabled" be
> verified with this change?
This change works fine with initial bug. Test failed if I comment out the fix
proposed in initial bug for Nimbus LAF.
-
On Tue, 16 Apr 2024 07:13:48 GMT, Sergey Bylokhov wrote:
> As far as I understand the test creates two enabled-JComboBox, then disables
> both, and then compares the disabled and enabled images. Why there are some
> differences in sizes and colors?
Not sure about this.. but there is a mention
On Tue, 16 Apr 2024 04:16:26 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is m
On Tue, 16 Apr 2024 04:09:47 GMT, Abhishek Kumar wrote:
>> test/jdk/javax/swing/JComboBox/DisabledComboBoxFontTestAuto.java line 58:
>>
>>> 56:
>>> 57: private static void createCombo() {
>>> 58: combo = new JComboBox();
>>
>> If we can use unicode blank character instead of "Simpl
On Thu, 11 Apr 2024 09:33:09 GMT, Alexey Ivanov wrote:
> This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`.
>
> `IS_WINVISTA` was not used at all.
>
> `IS_WINXP` guarded support for icons with alpha channel. It is now safe to
> assume Java runs on a Windows version
27 matches
Mail list logo
