On Thu, 18 Apr 2024 15:18:56 GMT, Alexey Ivanov wrote:
> > Since the changes/restructuring is more, it would be better to add more
> > details in description which would help in review process.
>
> What details are you looking for?
>
> The purpose of the changes hasn't changed: make the code t
On Fri, 19 Apr 2024 00:58:00 GMT, Harshitha Onkar wrote:
> Tested on Ubuntu, changes look good.
>
> Minor: Test instructions can be rephrased for clarity. Copyright years need
> to be updated for some of source code files.
Updated.
> test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor
> JTabbedPane's content area, tab area and tab background color are not as
> expected when opaque is set to true or false.
> The proposed fix is to handle the TabbedPane's background color in installed
> LAFs. Manual test is added to support the fix and there is no regression
> caused by the fi
On Thu, 18 Apr 2024 20:44:13 GMT, Harshitha Onkar wrote:
> @TejeshR13 Based on the PR description the source code fix looks correct. I
> was unable to test it on my local Win machine due to printer issues. The
> Print to PDF option isn't working too. But this is something to do with my
> syste
On Wed, 17 Apr 2024 04:31:16 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is m
On Thu, 18 Apr 2024 04:47:15 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
On Thu, 18 Apr 2024 04:47:15 GMT, Abhishek Kumar wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to
On Thu, 4 Apr 2024 09:38:20 GMT, Prasanta Sadhukhan
wrote:
>> Test issue shows the End and Start buttons are not placed as per
>> instructions due to ComponentOrientation RTL was not honoured, as with
>> `getContentPane()` being removed from `add` call of JFrame, it was also
>> additionally r
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or imp
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or imp
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible to specify the appropriately configured `Lint` object when i
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible to specify the appropriately configured `Lint` object when i
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or imp
On Wed, 10 Apr 2024 04:32:53 GMT, Tejesh R wrote:
> Getting a theme for particular dpi failed in windows L&F during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjdk/jdk/commit/a63afa
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible to specify the appropriately configured `Lint` object when i
On Wed, 10 Apr 2024 04:32:53 GMT, Tejesh R wrote:
> Getting a theme for particular dpi failed in windows L&F during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjdk/jdk/commit/a63afa
Please review a set of updates to clean up use of `/**` comments in the
vicinity of declarations.
There are various categories of update:
* "Box comments" beginning with `/**`
* Misplaced doc comments before package or import statements
* Misplaced doc comments after the annotations for a declar
On Wed, 10 Apr 2024 04:32:53 GMT, Tejesh R wrote:
> Getting a theme for particular dpi failed in windows L&F during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjdk/jdk/commit/a63afa
On Wed, 10 Apr 2024 04:32:53 GMT, Tejesh R wrote:
> Getting a theme for particular dpi failed in windows L&F during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjdk/jdk/commit/a63afa
On Thu, 18 Apr 2024 11:32:13 GMT, Per Minborg wrote:
>> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
>> symbol has been found by the lookup or not (which enables composition of
>> symbol lookups), many clients end up just calling `Optional::get`, or
>> `Optional
On Thu, 18 Apr 2024 11:32:13 GMT, Per Minborg wrote:
>> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
>> symbol has been found by the lookup or not (which enables composition of
>> symbol lookups), many clients end up just calling `Optional::get`, or
>> `Optional
On Thu, 18 Apr 2024 04:03:38 GMT, Tejesh R wrote:
>> The main problem here is that we do not curate what font point size we
>> passed to freetype,
>> and would pass in one larger than freetype's maximum of FT_USHORT_MAX which
>> is USHRT_MAX.
>> This isn't documented, SFAICS, and is checked a c
On Mon, 8 Apr 2024 06:09:16 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> Added pageloader cancel before new page creation along with code
> restructuring. Moved all page loading calls inside synchronize to make it
> thread safe.
>
> Regards,
> Renjith.
Changes requested by aiv
On Wed, 17 Apr 2024 04:31:16 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is m
On Wed, 17 Apr 2024 09:55:43 GMT, Abhishek Kumar wrote:
> > As far as I understand the test creates two enabled-JComboBox, then
> > disables both, and then compares the disabled and enabled images. Why there
> > are some differences in sizes and colors?
>
> Difference in size is specific to LA
On Wed, 17 Apr 2024 04:31:16 GMT, Abhishek Kumar wrote:
>> Test was failing on GTK and Windows LAF due to pixel color mismatch. Th
>> reason behind this issue was the size of image which is different and that
>> results in incorrect pixel comparison. Fix is to ensure that correct pixel
>> is m
On Thu, 18 Apr 2024 05:07:04 GMT, Tejesh R wrote:
> Since the changes/restructuring is more, it would be better to add more
> details in description which would help in review process.
What details are you looking for?
The purpose of the changes hasn't changed: make the code thread-safe in reg
On Thu, 4 Apr 2024 12:07:46 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have updated the test with PassFailJFrame along with printer availability
> check. Please review and let me know your suggestions.
>
> Renjith.
This pull request has now been integrated.
Changeset: f713
On Thu, 18 Apr 2024 11:32:13 GMT, Per Minborg wrote:
>> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
>> symbol has been found by the lookup or not (which enables composition of
>> symbol lookups), many clients end up just calling `Optional::get`, or
>> `Optional
> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
> symbol has been found by the lookup or not (which enables composition of
> symbol lookups), many clients end up just calling `Optional::get`, or
> `Optional::orElseThrow()` on the result.
>
> This PR proposes to ad
On Thu, 11 Apr 2024 09:33:09 GMT, Alexey Ivanov wrote:
> This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`.
>
> `IS_WINVISTA` was not used at all.
>
> `IS_WINXP` guarded support for icons with alpha channel. It is now safe to
> assume Java runs on a Windows version
31 matches
Mail list logo
