On Fri, 19 Apr 2024 07:12:36 GMT, Tejesh R wrote:
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
> PassFa
> Getting a theme for particular dpi failed in windows L&F during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjdk/jdk/commit/a63afa4aa62863d1a199a0fb7d2f56ff8fcd04fd)
> getting a the
On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Added pageloader cancel before new page creation along with code
>> restructuring. Moved all page loading calls inside synchronize to make it
>> thread safe.
>>
>> Regards,
>> Renjith.
>
> Renjith Kann
On Mon, 22 Apr 2024 15:14:41 GMT, Alexey Ivanov wrote:
> Do you mind if I shorten the subject of the bug? _Printing JTable throws
> InternalError: HTHEME is null_?
Sure, it's better to shorten it.
-
PR Comment: https://git.openjdk.org/jdk/pull/18706#issuecomment-2071413388
On Tue, 9 Apr 2024 18:50:17 GMT, Phil Race wrote:
> The main problem here is that we do not curate what font point size we passed
> to freetype,
> and would pass in one larger than freetype's maximum of FT_USHORT_MAX which
> is USHRT_MAX.
> This isn't documented, SFAICS, and is checked a couple
On Tue, 9 Apr 2024 18:50:17 GMT, Phil Race wrote:
> The main problem here is that we do not curate what font point size we passed
> to freetype,
> and would pass in one larger than freetype's maximum of FT_USHORT_MAX which
> is USHRT_MAX.
> This isn't documented, SFAICS, and is checked a couple
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before package
On Fri, 19 Apr 2024 19:21:13 GMT, Jonathan Gibbons wrote:
>> Please review a set of updates to clean up use of `/**` comments in the
>> vicinity of declarations.
>>
>> There are various categories of update:
>>
>> * "Box comments" beginning with `/**`
>> * Misplaced doc comments before package
On Fri, 19 Apr 2024 15:16:41 GMT, Artem Semenov wrote:
> I replaced reflection with using an accessor
> @azuev-java please review
The problem with this fix is that on the test example attached to the bug any
attempt of navigation trough the items of JTree whole voice over is enabled
causes jav
On Fri, 19 Apr 2024 07:12:36 GMT, Tejesh R wrote:
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
> PassFa
On Fri, 19 Apr 2024 07:12:36 GMT, Tejesh R wrote:
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
> PassFa
On Thu, 4 Apr 2024 09:38:20 GMT, Prasanta Sadhukhan
wrote:
>> Test issue shows the End and Start buttons are not placed as per
>> instructions due to ComponentOrientation RTL was not honoured, as with
>> `getContentPane()` being removed from `add` call of JFrame, it was also
>> additionally r
On Mon, 22 Apr 2024 17:38:59 GMT, Jonathan Gibbons wrote:
> The document [How to Write Doc Comments for the Javadoc
> Tool](https://www.oracle.com/uk/technical-resources/articles/java/javadoc-tool.html)
> is depressingly obsolete, as indicated by this text towards the end:
I know. Yet there's
On Fri, 19 Apr 2024 19:29:31 GMT, Alexey Ivanov wrote:
> > We do not have an overall style guide. The conventional wisdom for editing
> > any existing file is to follow the style in that file, if such a style can
> > be discerned.
>
> That's what I do.
>
> I saw either style used in JDK. Yet
On Fri, 19 Apr 2024 07:12:36 GMT, Tejesh R wrote:
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
> PassFa
On Mon, 22 Apr 2024 07:03:54 GMT, Tejesh R wrote:
>> Yes, `openTheme()` actually returns 0. Hence I used `null` && `0` checker.
>
> Moved the failure handling to `openThemeImpl()`.
> Yes, `openTheme()` actually returns 0. …
This is why it can't be `null`.
-
PR Review Comment: http
On Mon, 22 Apr 2024 07:08:00 GMT, Tejesh R wrote:
>> Getting a theme for particular dpi failed in windows L&F during print test.
>> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
>> was independent of DPI. After the fix
>> (https://github.com/openjdk/jdk/commit/a6
On Mon, 22 Apr 2024 07:08:00 GMT, Tejesh R wrote:
>> Getting a theme for particular dpi failed in windows L&F during print test.
>> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
>> was independent of DPI. After the fix
>> (https://github.com/openjdk/jdk/commit/a6
On Mon, 22 Apr 2024 08:41:13 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/JEditorPane.java line 483:
>>
>>> 481: // The same page with different reference
>>> 482: if (reference != null) {
>>> 483: scrollToReference(reference);
>>
>>
On Mon, 22 Apr 2024 08:46:53 GMT, Per Minborg wrote:
>> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
>> symbol has been found by the lookup or not (which enables composition of
>> symbol lookups), many clients end up just calling `Optional::get`, or
>> `Optional
On Mon, 22 Apr 2024 09:57:28 GMT, Artem Semenov wrote:
>> src/java.desktop/share/classes/sun/swing/SwingAccessor.java line 331:
>>
>>> 329: var access = accessibleJTreeNodeCreateAccessor;
>>> 330: if (access == null) {
>>> 331: ensureClassInitialized(JTree.class);
>>
On Fri, 19 Apr 2024 20:24:38 GMT, Chen Liang wrote:
>> I replaced reflection with using an accessor
>> @azuev-java please review
>
> src/java.desktop/share/classes/sun/swing/SwingAccessor.java line 331:
>
>> 329: var access = accessibleJTreeNodeCreateAccessor;
>> 330: if (access
> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
> symbol has been found by the lookup or not (which enables composition of
> symbol lookups), many clients end up just calling `Optional::get`, or
> `Optional::orElseThrow()` on the result.
>
> This PR proposes to ad
On Mon, 22 Apr 2024 07:19:04 GMT, Tejesh R wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Rearranged if based on suggesion
>
> src/java.desktop/share/classes/javax/swing/JEditorPane.java line 483:
>
On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Added pageloader cancel before new page creation along with code
>> restructuring. Moved all page loading calls inside synchronize to make it
>> thread safe.
>>
>> Regards,
>> Renjith.
>
> Renjith Kann
On Mon, 22 Apr 2024 07:00:52 GMT, Tejesh R wrote:
>> I agree. The current approach calls `openThemeImpl` three times: once or
>> twice with the passed `dpi` and then once with `defaultDPI` as the fallback.
>> Moreover, it *leaks theme handles* if `openThemeImpl` returns non-zero value
>> and i
On Fri, 19 Apr 2024 19:46:01 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 120:
>>
>>> 118: // this should be called only with writeLock held
>>> 119: private static Long getThemeImpl(String widget, int dpi) {
>>> 120: if (ope
> Getting a theme for particular dpi failed in windows L&F during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
> (https://github.com/openjdk/jdk/commit/a63afa4aa62863d1a199a0fb7d2f56ff8fcd04fd)
> getting a the
28 matches
Mail list logo
